Hi Doug,
Commit
4b9796b0a6fb ("IB/hfi1: Use accessor to determine ring size")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
On 8/31/2017 5:50 PM, Stephen Rothwell wrote:
> Hi Doug,
>
> Commit
>
> 4b9796b0a6fb ("IB/hfi1: Use accessor to determine ring size")
>
> is missing a Signed-off-by from its author.
>
What's the best way to fix this? I can rebase, but I know Linus hates
that. What about git note?
--
Doug Ledford <[email protected]>
GPG Key ID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
On Fri, Sep 1, 2017 at 5:06 AM, Doug Ledford <[email protected]> wrote:
> On 8/31/2017 5:50 PM, Stephen Rothwell wrote:
>> Hi Doug,
>>
>> Commit
>>
>> 4b9796b0a6fb ("IB/hfi1: Use accessor to determine ring size")
>>
>> is missing a Signed-off-by from its author.
>>
>
> What's the best way to fix this? I can rebase, but I know Linus hates
> that. What about git note?
We don't end up using (or forwarding) git notes, so that won't help.
Generally, the answer to missing sign-offs is "don't do that again" if
it's not something major and there isn't a _pattern_ of it happening.
In this case, it's a one-liner patch from a developer who has lots of
other sign-offs, from a company that is very aware of his work and the
GPL, and an active contributor. so it's not like it has any legal
implications.
If it was some big important patch from a more questionable source,
and we'd be worried about covering the legal side, it would be a
different issue. As it is, it falls under "mistakes happen, not a big
deal, try to avoid it in the future".
If it *was* a bigger issue and you really want to make sure that the
chain is there for new contributors etc, rebasing to fix sign-offs
ends up being the best (still bad) solution.
Linus