2010-11-02 07:20:33

by gimli

[permalink] [raw]
Subject: [PATCH 4/6] MacBookAir3,1(3,2) hid support

This patch add support for the MacBookAir3,1 and MacBookAir3,2 to the hid
driver.

Signed-off-by: Edgar (gimli) Hucek <[email protected]>

Attachments:
hid_macbookair.patch (5.92 kB)

2010-11-02 16:55:45

by Henrik Rydberg

[permalink] [raw]
Subject: Re: [PATCH 4/6] MacBookAir3,1(3,2) hid support

On 11/02/2010 08:20 AM, gimli wrote:

> This patch add support for the MacBookAir3,1 and MacBookAir3,2 to the hid
> driver.
>
> Signed-off-by: Edgar (gimli) Hucek <[email protected]>
>


Hi Edgar,

thanks for the information. Are the device ids correlated to the 13'' and 11''
versions of these machines? If so, why are they mapped to the same keyboard? The
apple_fn_keys also covers the existing Macbook Airs, but appears not to be used
for any of the new device ids.

Thanks,
Henrik

2010-11-03 09:42:02

by gimli

[permalink] [raw]
Subject: Re: [PATCH 4/6] MacBookAir3,1(3,2) hid support

On Tue, 02 Nov 2010 17:55:27 +0100, Henrik Rydberg <[email protected]>
wrote:
> On 11/02/2010 08:20 AM, gimli wrote:
>
>> This patch add support for the MacBookAir3,1 and MacBookAir3,2 to the
hid
>> driver.
>>
>> Signed-off-by: Edgar (gimli) Hucek <[email protected]>
>>
>
>
> Hi Edgar,
>
> thanks for the information. Are the device ids correlated to the 13'' and
> 11''
> versions of these machines? If so, why are they mapped to the same
> keyboard? The
> apple_fn_keys also covers the existing Macbook Airs, but appears not to
be
> used
> for any of the new device ids.

The keyboard layout changed on the new Air's. Thats the reason why i use
a new apple_fn_keys for the new Air's.

lg

Edgar (gimli) Hucek

> Thanks,
> Henrik
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel"
in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/

2010-11-03 10:09:10

by Henrik Rydberg

[permalink] [raw]
Subject: Re: [PATCH 4/6] MacBookAir3,1(3,2) hid support

On 11/03/2010 10:41 AM, gimli wrote:

> On Tue, 02 Nov 2010 17:55:27 +0100, Henrik Rydberg <[email protected]>
> wrote:
>> On 11/02/2010 08:20 AM, gimli wrote:
>>
>>> This patch add support for the MacBookAir3,1 and MacBookAir3,2 to the
> hid
>>> driver.
>>>
>>> Signed-off-by: Edgar (gimli) Hucek <[email protected]>
>>>
>>
>>
>> Hi Edgar,
>>
>> thanks for the information. Are the device ids correlated to the 13'' and
>> 11''
>> versions of these machines? If so, why are they mapped to the same
>> keyboard? The
>> apple_fn_keys also covers the existing Macbook Airs, but appears not to
> be
>> used
>> for any of the new device ids.
>
> The keyboard layout changed on the new Air's. Thats the reason why i use
> a new apple_fn_keys for the new Air's.


Thanks for the clarification, it all makes sense.

Did you consider using quirks for the keyboard layouts instead? Either way,

Acked-by: Henrik Rydberg <[email protected]>

Thanks,
Henrik