2024-04-23 21:52:15

by Greg KH

[permalink] [raw]
Subject: [PATCH 5.15 00/71] 5.15.157-rc1 review

This is the start of the stable review cycle for the 5.15.157 release.
There are 71 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.

Responses should be made by Thu, 25 Apr 2024 21:38:28 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.157-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>
Linux 5.15.157-rc1

Arınç ÜNAL <[email protected]>
net: dsa: mt7530: fix enabling EEE on MT7531 switch on all boards

Arınç ÜNAL <[email protected]>
net: dsa: mt7530: fix improper frames on all 25MHz and 40MHz XTAL MT7530

Vladimir Oltean <[email protected]>
net: dsa: introduce preferred_default_local_cpu_port and use on MT7530

Arınç ÜNAL <[email protected]>
net: dsa: mt7530: set all CPU ports in MT7531_CPU_PMAP

Jeongjun Park <[email protected]>
nilfs2: fix OOB in nilfs_set_de_type

Dave Airlie <[email protected]>
nouveau: fix instmem race condition around ptr stores

Zack Rusin <[email protected]>
drm/vmwgfx: Sort primary plane formats by order of preference

xinhui pan <[email protected]>
drm/amdgpu: validate the parameters of bo mapping operations more clearly

Carlos Llamas <[email protected]>
binder: check offset alignment in binder_get_object()

Yuntao Wang <[email protected]>
init/main.c: Fix potential static_command_line memory overflow

Yaxiong Tian <[email protected]>
arm64: hibernate: Fix level3 translation fault in swsusp_save()

Sandipan Das <[email protected]>
KVM: x86/pmu: Do not mask LVTPC when handling a PMI on AMD platforms

Sean Christopherson <[email protected]>
KVM: x86: Snapshot if a vCPU's vendor model is AMD vs. Intel compatible

Alan Stern <[email protected]>
fs: sysfs: Fix reference leak in sysfs_break_active_protection()

Samuel Thibault <[email protected]>
speakup: Avoid crash on very long word

Alexander Usyskin <[email protected]>
mei: me: disable RPL-S on SPS and IGN firmwares

Norihiko Hama <[email protected]>
usb: gadget: f_ncm: Fix UAF ncm object at re-bind after usb ep transport error

Kai-Heng Feng <[email protected]>
usb: Disable USB3 LPM at shutdown

Minas Harutyunyan <[email protected]>
usb: dwc2: host: Fix dereference issue in DDMA completion flow.

Greg Kroah-Hartman <[email protected]>
Revert "usb: cdc-wdm: close race between read and workqueue"

Daniele Palmas <[email protected]>
USB: serial: option: add Telit FN920C04 rmnet compositions

Vanillan Wang <[email protected]>
USB: serial: option: add Rolling RW101-GL and RW135-GL support

Jerry Meng <[email protected]>
USB: serial: option: support Quectel EM060K sub-models

Coia Prant <[email protected]>
USB: serial: option: add Lonsung U8300/U9300 product

Chuanhong Guo <[email protected]>
USB: serial: option: add support for Fibocom FM650/FG650

bolan wang <[email protected]>
USB: serial: option: add Fibocom FM135-GL variants

Finn Thain <[email protected]>
serial/pmac_zilog: Remove flawed mitigation for rx irq flood

Nikita Zhandarovich <[email protected]>
comedi: vmk80xx: fix incomplete endpoint checking

Gil Fine <[email protected]>
thunderbolt: Fix wake configurations after device unplug

Gil Fine <[email protected]>
thunderbolt: Avoid notify PM core about runtime PM resume

Eric Biggers <[email protected]>
x86/cpufeatures: Fix dependencies for GFNI, VAES, and VPCLMULQDQ

Josh Poimboeuf <[email protected]>
x86/bugs: Fix BHI retpoline check

Stephen Boyd <[email protected]>
clk: Get runtime PM before walking tree during disable_unused

Stephen Boyd <[email protected]>
clk: Initialize struct clk_core kref earlier

Konrad Dybcio <[email protected]>
clk: Print an info line before disabling unused clocks

Claudiu Beznea <[email protected]>
clk: remove extra empty line

Stephen Boyd <[email protected]>
clk: Mark 'all_lists' as const

Stephen Boyd <[email protected]>
clk: Remove prepare_lock hold assertion in __clk_release()

Dmitry Baryshkov <[email protected]>
drm/panel: visionox-rm69299: don't unregister DSI device

Mikhail Kobuk <[email protected]>
drm: nv04: Fix out of bounds access

Peter Oberparleiter <[email protected]>
s390/cio: fix race condition during online processing

Peter Oberparleiter <[email protected]>
s390/qdio: handle deferred cc1

Michael Guralnik <[email protected]>
RDMA/mlx5: Fix port number for counter query in multi-port configuration

Mark Zhang <[email protected]>
RDMA/cm: Print the old state when cm_destroy_id gets timeout

Yanjun.Zhu <[email protected]>
RDMA/rxe: Fix the problem "mutex_destroy missing"

Siddharth Vadapalli <[email protected]>
net: ethernet: ti: am65-cpsw-nuss: cleanup DMA Channels before using them

Arınç ÜNAL <[email protected]>
net: dsa: mt7530: fix mirroring frames received on local port

Lei Chen <[email protected]>
tun: limit printing rate when illegal packet received by tun dev

Kuniyuki Iwashima <[email protected]>
af_unix: Don't peek OOB data without MSG_OOB.

Kuniyuki Iwashima <[email protected]>
af_unix: Call manage_oob() for every skb in unix_stream_read_generic().

Pablo Neira Ayuso <[email protected]>
netfilter: flowtable: incorrect pppoe tuple

Pablo Neira Ayuso <[email protected]>
netfilter: flowtable: validate pppoe header

Vlad Buslov <[email protected]>
netfilter: nf_flow_table: count pending offload workqueue tasks

Florian Westphal <[email protected]>
netfilter: nft_set_pipapo: do not free live element

Pablo Neira Ayuso <[email protected]>
netfilter: br_netfilter: skip conntrack input hook for promisc packets

Ziyang Xuan <[email protected]>
netfilter: nf_tables: Fix potential data-race in __nft_obj_type_get()

Ziyang Xuan <[email protected]>
netfilter: nf_tables: Fix potential data-race in __nft_expr_type_get()

Chuck Lever <[email protected]>
Revert "lockd: introduce safe async lock op"

Siddh Raman Pant <[email protected]>
Revert "tracing/trigger: Fix to return error if failed to alloc snapshot"

Zheng Yejian <[email protected]>
kprobes: Fix possible use-after-free issue on kprobe registration

Daniel Borkmann <[email protected]>
bpf: Fix ringbuf memory type confusion when passing to helpers

Daniel Borkmann <[email protected]>
bpf: Fix out of bounds access for ringbuf helpers

Daniel Borkmann <[email protected]>
bpf: Generally fix helper register offset check

Daniel Borkmann <[email protected]>
bpf: Generalize check_ctx_reg for reuse with other types

Kumar Kartikeya Dwivedi <[email protected]>
bpf: Extend kfunc with PTR_TO_CTX, PTR_TO_MEM argument support

Yuanhe Shu <[email protected]>
selftests/ftrace: Limit length in subsystem-enable tests

Steven Rostedt (Google) <[email protected]>
SUNRPC: Fix rpcgss_context trace event acceptor field

Boris Burkov <[email protected]>
btrfs: record delayed inode root in transaction

Namjae Jeon <[email protected]>
ksmbd: do not set SMB2_GLOBAL_CAP_ENCRYPTION for SMB 3.1.1

Namjae Jeon <[email protected]>
ksmbd: validate payload size in ipc response

Namjae Jeon <[email protected]>
ksmbd: don't send oplock break if rename fails


-------------

Diffstat:

Documentation/filesystems/nfs/exporting.rst | 7 -
Makefile | 4 +-
arch/arm64/mm/pageattr.c | 3 -
arch/x86/include/asm/kvm_host.h | 1 +
arch/x86/kernel/cpu/bugs.c | 11 +-
arch/x86/kernel/cpu/cpuid-deps.c | 6 +-
arch/x86/kvm/cpuid.c | 1 +
arch/x86/kvm/cpuid.h | 10 ++
arch/x86/kvm/lapic.c | 3 +-
arch/x86/kvm/mmu/mmu.c | 2 +-
arch/x86/kvm/x86.c | 2 +-
drivers/accessibility/speakup/main.c | 2 +-
drivers/android/binder.c | 4 +-
drivers/clk/clk.c | 154 ++++++++++++++++-----
drivers/comedi/drivers/vmk80xx.c | 35 ++---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 72 ++++++----
drivers/gpu/drm/nouveau/nouveau_bios.c | 13 +-
drivers/gpu/drm/nouveau/nvkm/subdev/instmem/nv50.c | 7 +-
drivers/gpu/drm/panel/panel-visionox-rm69299.c | 2 -
drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 4 +-
drivers/infiniband/core/cm.c | 11 +-
drivers/infiniband/hw/mlx5/mad.c | 3 +-
drivers/infiniband/sw/rxe/rxe.c | 2 +
drivers/misc/mei/pci-me.c | 2 +-
drivers/net/dsa/mt7530.c | 60 +++++---
drivers/net/dsa/mt7530.h | 6 +
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 18 +++
drivers/net/tun.c | 18 +--
drivers/s390/cio/device.c | 13 +-
drivers/s390/cio/qdio_main.c | 28 +++-
drivers/thunderbolt/switch.c | 50 +++++--
drivers/thunderbolt/tb.c | 4 +-
drivers/thunderbolt/tb.h | 3 +-
drivers/thunderbolt/usb4.c | 13 +-
drivers/tty/serial/pmac_zilog.c | 14 --
drivers/usb/class/cdc-wdm.c | 6 +-
drivers/usb/core/port.c | 4 +-
drivers/usb/dwc2/hcd_ddma.c | 4 +-
drivers/usb/gadget/function/f_ncm.c | 4 +-
drivers/usb/serial/option.c | 40 ++++++
fs/btrfs/delayed-inode.c | 3 +
fs/ksmbd/ksmbd_netlink.h | 3 +-
fs/ksmbd/mgmt/share_config.c | 7 +-
fs/ksmbd/smb2ops.c | 10 +-
fs/ksmbd/smb2pdu.c | 3 +-
fs/ksmbd/transport_ipc.c | 37 +++++
fs/lockd/svclock.c | 4 +-
fs/nfsd/nfs4state.c | 10 +-
fs/nilfs2/dir.c | 2 +-
fs/sysfs/file.c | 2 +
include/linux/bpf.h | 9 +-
include/linux/bpf_verifier.h | 4 +-
include/linux/exportfs.h | 14 --
include/net/dsa.h | 8 ++
include/net/net_namespace.h | 6 +
include/net/netfilter/nf_flow_table.h | 33 ++++-
include/net/netns/flow_table.h | 14 ++
include/trace/events/rpcgss.h | 4 +-
init/main.c | 2 +
kernel/bpf/btf.c | 93 ++++++++++---
kernel/bpf/verifier.c | 66 ++++++---
kernel/kprobes.c | 18 ++-
kernel/trace/trace_events_trigger.c | 6 +-
net/bridge/br_input.c | 15 +-
net/bridge/br_netfilter_hooks.c | 6 +
net/bridge/br_private.h | 1 +
net/bridge/netfilter/nf_conntrack_bridge.c | 14 +-
net/dsa/dsa2.c | 24 +++-
net/netfilter/Kconfig | 9 ++
net/netfilter/Makefile | 1 +
net/netfilter/nf_flow_table_core.c | 62 ++++++++-
net/netfilter/nf_flow_table_inet.c | 3 +-
net/netfilter/nf_flow_table_ip.c | 10 +-
net/netfilter/nf_flow_table_offload.c | 17 ++-
net/netfilter/nf_flow_table_procfs.c | 80 +++++++++++
net/netfilter/nf_tables_api.c | 16 ++-
net/netfilter/nft_set_pipapo.c | 14 +-
net/unix/af_unix.c | 12 +-
.../ftrace/test.d/event/subsystem-enable.tc | 6 +-
79 files changed, 973 insertions(+), 321 deletions(-)




2024-04-23 23:00:21

by SeongJae Park

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/71] 5.15.157-rc1 review

Hello,

On Tue, 23 Apr 2024 14:39:13 -0700 Greg Kroah-Hartman <[email protected]> wrote:

> This is the start of the stable review cycle for the 5.15.157 release.
> There are 71 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 25 Apr 2024 21:38:28 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.157-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.

This rc kernel passes DAMON functionality test[1] on my test machine.
Attaching the test results summary below. Please note that I retrieved the
kernel from linux-stable-rc tree[2].

Tested-by: SeongJae Park <[email protected]>

[1] https://github.com/awslabs/damon-tests/tree/next/corr
[2] 70f39a25a6b8 ("Linux 5.15.157-rc1")

Thanks,
SJ

[...]

---

ok 1 selftests: damon: debugfs_attrs.sh
ok 1 selftests: damon-tests: kunit.sh
ok 2 selftests: damon-tests: huge_count_read_write.sh
ok 3 selftests: damon-tests: buffer_overflow.sh
ok 4 selftests: damon-tests: rm_contexts.sh
ok 5 selftests: damon-tests: record_null_deref.sh
ok 6 selftests: damon-tests: dbgfs_target_ids_read_before_terminate_race.sh
ok 7 selftests: damon-tests: dbgfs_target_ids_pid_leak.sh
ok 8 selftests: damon-tests: damo_tests.sh
ok 9 selftests: damon-tests: masim-record.sh
ok 10 selftests: damon-tests: build_i386.sh
ok 11 selftests: damon-tests: build_arm64.sh
ok 12 selftests: damon-tests: build_m68k.sh
ok 13 selftests: damon-tests: build_i386_idle_flag.sh
ok 14 selftests: damon-tests: build_i386_highpte.sh
ok 15 selftests: damon-tests: build_nomemcg.sh
[33m
[92mPASS [39m

2024-04-23 23:32:44

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/71] 5.15.157-rc1 review

On 4/23/24 14:39, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.157 release.
> There are 71 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 25 Apr 2024 21:38:28 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.157-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
BMIPS_GENERIC:

Tested-by: Florian Fainelli <[email protected]>
--
Florian


2024-04-24 07:25:27

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/71] 5.15.157-rc1 review

Hi!

> This is the start of the stable review cycle for the 5.15.157 release.
> There are 71 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.

CIP testing did not find any problems here:

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.15.y

Tested-by: Pavel Machek (CIP) <[email protected]>

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Attachments:
(No filename) (661.00 B)
signature.asc (201.00 B)
Download all attachments

2024-04-24 07:32:37

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/71] 5.15.157-rc1 review

Hi!

> This is the start of the stable review cycle for the 5.15.157 release.
> There are 71 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.

I realise 5.10 is not released, yet, but current queue results in
problems.

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y
https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/jobs/6700369930

kernel/trace/ring_buffer.c: In function 'rb_tail_page_update':
2028kernel/trace/ring_buffer.c:1479:7: error: implicit declaration of function 'try_cmpxchg'; did you mean 'xa_cmpxchg'? [-Werror=implicit-function-declaration]
2029 1479 | if (try_cmpxchg(&cpu_buffer->tail_page, &tail_page, next_page))
2030 | ^~~~~~~~~~~
2031 | xa_cmpxchg

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Attachments:
(No filename) (1.01 kB)
signature.asc (201.00 B)
Download all attachments

2024-04-24 07:58:06

by Naresh Kamboju

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/71] 5.15.157-rc1 review

On Wed, 24 Apr 2024 at 03:16, Greg Kroah-Hartman
<[email protected]> wrote:
>
> This is the start of the stable review cycle for the 5.15.157 release.
> There are 71 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 25 Apr 2024 21:38:28 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.157-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h


The s390 defconfig build failed with gcc-12 and clang-17 on the Linux
stable-rc linux.5.15.y branch.

Reported-by: Linux Kernel Functional Testing <[email protected]>

Build log:
---
drivers/s390/cio/qdio_main.c: In function 'qdio_int_handler':
drivers/s390/cio/qdio_main.c:761:52: error: incompatible type for
argument 2 of 'ccw_device_start'
761 | rc = ccw_device_start(cdev, irq_ptr->ccw,
intparm, 0, 0);
| ~~~~~~~^~~~~
| |
| struct ccw1
In file included from arch/s390/include/asm/qdio.h:13,
from drivers/s390/cio/qdio_main.c:18:
arch/s390/include/asm/ccwdev.h:172:50: note: expected 'struct ccw1 *'
but argument is of type 'struct ccw1'
172 | extern int ccw_device_start(struct ccw_device *, struct ccw1 *,
| ^~~~~~~~~~~~~
make[3]: *** [scripts/Makefile.build:289: drivers/s390/cio/qdio_main.o] Error 1


Suspected commit:
--------
s390/qdio: handle deferred cc1
[ Upstream commit 607638faf2ff1cede37458111496e7cc6c977f6f ]

Steps to reproduce:
---
# tuxmake --runtime podman --target-arch s390 --toolchain gcc-12
--kconfig defconfig


Links:
- https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.15.y/build/v5.15.156-72-g70f39a25a6b8/testrun/23638097/suite/build/test/gcc-12-defconfig/details/
- https://storage.tuxsuite.com/public/linaro/lkft/builds/2fWFs1EvyrjLKUD3D6ODW0Agksv/

--
Linaro LKFT
https://lkft.linaro.org

2024-04-24 08:28:52

by Ron Economos

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/71] 5.15.157-rc1 review

On 4/23/24 2:39 PM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.157 release.
> There are 71 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 25 Apr 2024 21:38:28 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.157-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
Built and booted successfully on RISC-V RV64 (HiFive Unmatched).

Tested-by: Ron Economos <[email protected]>

2024-04-24 09:31:20

by Harshit Mogalapalli

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/71] 5.15.157-rc1 review

Hi Greg,

On 24/04/24 03:09, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.157 release.
> There are 71 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 25 Apr 2024 21:38:28 +0000.
> Anything received after that time might be too late.
>
No problems seen on x86_64 and aarch64 with our testing.

Tested-by: Harshit Mogalapalli <[email protected]>

Thanks,
Harshit
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.157-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
> -------

2024-04-24 09:49:03

by Peter Oberparleiter

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/71] 5.15.157-rc1 review

On 24.04.2024 09:57, Naresh Kamboju wrote:
> On Wed, 24 Apr 2024 at 03:16, Greg Kroah-Hartman
> <[email protected]> wrote:
>>
>> This is the start of the stable review cycle for the 5.15.157 release.
>> There are 71 patches in this series, all will be posted as a response
>> to this one. If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Thu, 25 Apr 2024 21:38:28 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.157-rc1.gz
>> or in the git tree and branch at:
>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
>
>
> The s390 defconfig build failed with gcc-12 and clang-17 on the Linux
> stable-rc linux.5.15.y branch.
>
> Reported-by: Linux Kernel Functional Testing <[email protected]>
>
> Build log:
> ---
> drivers/s390/cio/qdio_main.c: In function 'qdio_int_handler':
> drivers/s390/cio/qdio_main.c:761:52: error: incompatible type for
> argument 2 of 'ccw_device_start'
> 761 | rc = ccw_device_start(cdev, irq_ptr->ccw,
> intparm, 0, 0);
> | ~~~~~~~^~~~~
> | |
> | struct ccw1
> In file included from arch/s390/include/asm/qdio.h:13,
> from drivers/s390/cio/qdio_main.c:18:
> arch/s390/include/asm/ccwdev.h:172:50: note: expected 'struct ccw1 *'
> but argument is of type 'struct ccw1'
> 172 | extern int ccw_device_start(struct ccw_device *, struct ccw1 *,
> | ^~~~~~~~~~~~~
> make[3]: *** [scripts/Makefile.build:289: drivers/s390/cio/qdio_main.o] Error 1
>
>
> Suspected commit:
> --------
> s390/qdio: handle deferred cc1
> [ Upstream commit 607638faf2ff1cede37458111496e7cc6c977f6f ]

This is due to a type change of field 'ccw' in 'struct qdio_irq' that
was introduced in v5.17 via commit 718ce9e10171 ("s390/qdio: avoid
allocating the qdio_irq with GFP_DMA").

The following change to commit 607638faf2ff ("s390/qdio: handle deferred
cc1") fixes the compile error on v5.15:

--- a/drivers/s390/cio/qdio_main.c
+++ b/drivers/s390/cio/qdio_main.c
@@ -758,7 +758,7 @@ void qdio_int_handler(struct ccw_device *cdev, unsigned long intparm,

if (rc == -EAGAIN) {
DBF_DEV_EVENT(DBF_INFO, irq_ptr, "qint retry");
- rc = ccw_device_start(cdev, irq_ptr->ccw, intparm, 0, 0);
+ rc = ccw_device_start(cdev, &irq_ptr->ccw, intparm, 0, 0);
if (!rc)
return;
DBF_ERROR("%4x RETRY ERR", irq_ptr->schid.sch_no);


2024-04-25 09:00:07

by Jon Hunter

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/71] 5.15.157-rc1 review

On Tue, 23 Apr 2024 14:39:13 -0700, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.15.157 release.
> There are 71 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 25 Apr 2024 21:38:28 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.157-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

All tests passing for Tegra ...

Test results for stable-v5.15:
10 builds: 10 pass, 0 fail
26 boots: 26 pass, 0 fail
102 tests: 102 pass, 0 fail

Linux version: 5.15.157-rc1-g70f39a25a6b8
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
tegra20-ventana, tegra210-p2371-2180,
tegra210-p3450-0000, tegra30-cardhu-a04

Tested-by: Jon Hunter <[email protected]>

Jon

2024-04-27 14:26:15

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH 5.15 00/71] 5.15.157-rc1 review

On Wed, Apr 24, 2024 at 11:21:05AM +0200, Peter Oberparleiter wrote:
> On 24.04.2024 09:57, Naresh Kamboju wrote:
> > On Wed, 24 Apr 2024 at 03:16, Greg Kroah-Hartman
> > <[email protected]> wrote:
> >>
> >> This is the start of the stable review cycle for the 5.15.157 release.
> >> There are 71 patches in this series, all will be posted as a response
> >> to this one. If anyone has any issues with these being applied, please
> >> let me know.
> >>
> >> Responses should be made by Thu, 25 Apr 2024 21:38:28 +0000.
> >> Anything received after that time might be too late.
> >>
> >> The whole patch series can be found in one patch at:
> >> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.15.157-rc1.gz
> >> or in the git tree and branch at:
> >> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.15.y
> >> and the diffstat can be found below.
> >>
> >> thanks,
> >>
> >> greg k-h
> >
> >
> > The s390 defconfig build failed with gcc-12 and clang-17 on the Linux
> > stable-rc linux.5.15.y branch.
> >
> > Reported-by: Linux Kernel Functional Testing <[email protected]>
> >
> > Build log:
> > ---
> > drivers/s390/cio/qdio_main.c: In function 'qdio_int_handler':
> > drivers/s390/cio/qdio_main.c:761:52: error: incompatible type for
> > argument 2 of 'ccw_device_start'
> > 761 | rc = ccw_device_start(cdev, irq_ptr->ccw,
> > intparm, 0, 0);
> > | ~~~~~~~^~~~~
> > | |
> > | struct ccw1
> > In file included from arch/s390/include/asm/qdio.h:13,
> > from drivers/s390/cio/qdio_main.c:18:
> > arch/s390/include/asm/ccwdev.h:172:50: note: expected 'struct ccw1 *'
> > but argument is of type 'struct ccw1'
> > 172 | extern int ccw_device_start(struct ccw_device *, struct ccw1 *,
> > | ^~~~~~~~~~~~~
> > make[3]: *** [scripts/Makefile.build:289: drivers/s390/cio/qdio_main.o] Error 1
> >
> >
> > Suspected commit:
> > --------
> > s390/qdio: handle deferred cc1
> > [ Upstream commit 607638faf2ff1cede37458111496e7cc6c977f6f ]
>
> This is due to a type change of field 'ccw' in 'struct qdio_irq' that
> was introduced in v5.17 via commit 718ce9e10171 ("s390/qdio: avoid
> allocating the qdio_irq with GFP_DMA").
>
> The following change to commit 607638faf2ff ("s390/qdio: handle deferred
> cc1") fixes the compile error on v5.15:
>
> --- a/drivers/s390/cio/qdio_main.c
> +++ b/drivers/s390/cio/qdio_main.c
> @@ -758,7 +758,7 @@ void qdio_int_handler(struct ccw_device *cdev, unsigned long intparm,
>
> if (rc == -EAGAIN) {
> DBF_DEV_EVENT(DBF_INFO, irq_ptr, "qint retry");
> - rc = ccw_device_start(cdev, irq_ptr->ccw, intparm, 0, 0);
> + rc = ccw_device_start(cdev, &irq_ptr->ccw, intparm, 0, 0);
> if (!rc)
> return;
> DBF_ERROR("%4x RETRY ERR", irq_ptr->schid.sch_no);
>
>

Fix now made, thanks for this!

greg k-h