2022-05-01 09:24:41

by Caleb Connolly

Subject: [PATCH v14 04/10] dt-bindings: iio: adc: document qcom-spmi-rradc

Add dt-binding docs for the Qualcomm SPMI RRADC found in PMICs like
PMI8998 and PMI8994

Signed-off-by: Caleb Connolly <[email protected]>
---
.../bindings/iio/adc/qcom,spmi-rradc.yaml | 51 +++++++++++++++++++
1 file changed, 51 insertions(+)
create mode 100644 Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml

diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml
new file mode 100644
index 000000000000..c8cbfd3444be
--- /dev/null
+++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml
@@ -0,0 +1,51 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/iio/adc/qcom,spmi-rradc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm's SPMI PMIC Round Robin ADC
+
+maintainers:
+ - Caleb Connolly <[email protected]>
+
+description: |
+ The Qualcomm SPMI Round Robin ADC (RRADC) provides interface to clients to
+ read the voltage, current and temperature for supported peripherals such as
+ the battery thermistor die temperature, charger temperature, USB and DC input
+ voltage / current and battery ID resistor.
+
+properties:
+ compatible:
+ enum:
+ - qcom,pmi8998-rradc
+ - qcom,pm660-rradc
+
+ reg:
+ maxItems: 1
+
+ qcom,batt-id-delay-ms:
+ description: Sets the hardware settling time for the battery ID resistor.
+ enum: [0, 1, 4, 12, 20, 40, 60, 80]
+
+ "#io-channel-cells":
+ const: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ pmic {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ pmic_rradc: adc@4500 {
+ compatible = "qcom,pmi8998-rradc";
+ reg = <0x4500>;
+ #io-channel-cells = <1>;
+ };
+ };
--
2.36.0

2022-05-02 23:29:57

by Krzysztof Kozlowski

Subject: Re: [PATCH v14 04/10] dt-bindings: iio: adc: document qcom-spmi-rradc

On 30/04/2022 00:08, Caleb Connolly wrote:
> Add dt-binding docs for the Qualcomm SPMI RRADC found in PMICs like
> PMI8998 and PMI8994
>
> Signed-off-by: Caleb Connolly <[email protected]>

You got my review tag, didn't you? Any changes in this patch?

Best regards,
Krzysztof

2022-05-02 23:35:48

by Caleb Connolly

Subject: Re: [PATCH v14 04/10] dt-bindings: iio: adc: document qcom-spmi-rradc

On 30/04/2022 15:44, Krzysztof Kozlowski wrote:
> On 30/04/2022 00:08, Caleb Connolly wrote:
>> Add dt-binding docs for the Qualcomm SPMI RRADC found in PMICs like
>> PMI8998 and PMI8994
>>
>> Signed-off-by: Caleb Connolly <[email protected]>
>
> You got my review tag, didn't you? Any changes in this patch?
Yes, I did, and applied your suggestion, apologies I totally forgot to
pick it up.

Shall I resend? Or who will be taking this patch? Would they maybe be
happy to add it?
>
> Best regards,
> Krzysztof

--
Kind Regards,
Caleb (they/he)

2022-05-03 01:12:51

by Krzysztof Kozlowski

Subject: Re: [PATCH v14 04/10] dt-bindings: iio: adc: document qcom-spmi-rradc

On 30/04/2022 00:08, Caleb Connolly wrote:
> Add dt-binding docs for the Qualcomm SPMI RRADC found in PMICs like
> PMI8998 and PMI8994
>
> Signed-off-by: Caleb Connolly <[email protected]>



Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2022-06-14 10:51:22

by Jonathan Cameron

Subject: Re: [PATCH v14 04/10] dt-bindings: iio: adc: document qcom-spmi-rradc

On Fri, 29 Apr 2022 23:08:59 +0100
Caleb Connolly <[email protected]> wrote:

> Add dt-binding docs for the Qualcomm SPMI RRADC found in PMICs like
> PMI8998 and PMI8994
>
> Signed-off-by: Caleb Connolly <[email protected]>
Reviewed-by: Jonathan Cameron <[email protected]>
#to let Lee pick it up via mfd if he prefers.

Thanks,

Jonathan

> ---
> .../bindings/iio/adc/qcom,spmi-rradc.yaml | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml
> new file mode 100644
> index 000000000000..c8cbfd3444be
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/adc/qcom,spmi-rradc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm's SPMI PMIC Round Robin ADC
> +
> +maintainers:
> + - Caleb Connolly <[email protected]>
> +
> +description: |
> + The Qualcomm SPMI Round Robin ADC (RRADC) provides interface to clients to
> + read the voltage, current and temperature for supported peripherals such as
> + the battery thermistor die temperature, charger temperature, USB and DC input
> + voltage / current and battery ID resistor.
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,pmi8998-rradc
> + - qcom,pm660-rradc
> +
> + reg:
> + maxItems: 1
> +
> + qcom,batt-id-delay-ms:
> + description: Sets the hardware settling time for the battery ID resistor.
> + enum: [0, 1, 4, 12, 20, 40, 60, 80]
> +
> + "#io-channel-cells":
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + pmic {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + pmic_rradc: adc@4500 {
> + compatible = "qcom,pmi8998-rradc";
> + reg = <0x4500>;
> + #io-channel-cells = <1>;
> + };
> + };