Hi Lukasz,
I love your patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on linux/master rafael-pm/linux-next linus/master v5.17-rc6 next-20220301]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Lukasz-Luba/Introduce-opp-microwatt-and-Energy-Model-from-DT/20220301-173700
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arc-randconfig-r014-20220301 (https://download.01.org/0day-ci/archive/20220302/[email protected]/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/e1e83de9bf2f261cb3e5eb9f53bde3c83c6e0647
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Lukasz-Luba/Introduce-opp-microwatt-and-Energy-Model-from-DT/20220301-173700
git checkout e1e83de9bf2f261cb3e5eb9f53bde3c83c6e0647
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>
All errors (new ones prefixed by >>):
drivers/opp/of.c: In function 'dev_pm_opp_of_register_em':
>> drivers/opp/of.c:1572:22: error: 'struct em_data_callback' has no member named 'active_power'
1572 | em_cb.active_power = _get_dt_power;
| ^
vim +1572 drivers/opp/of.c
1540
1541 /**
1542 * dev_pm_opp_of_register_em() - Attempt to register an Energy Model
1543 * @dev : Device for which an Energy Model has to be registered
1544 * @cpus : CPUs for which an Energy Model has to be registered. For
1545 * other type of devices it should be set to NULL.
1546 *
1547 * This checks whether the "dynamic-power-coefficient" devicetree property has
1548 * been specified, and tries to register an Energy Model with it if it has.
1549 * Having this property means the voltages are known for OPPs and the EM
1550 * might be calculated.
1551 */
1552 int dev_pm_opp_of_register_em(struct device *dev, struct cpumask *cpus)
1553 {
1554 struct em_data_callback em_cb = EM_DATA_CB(_get_power);
1555 struct device_node *np;
1556 int ret, nr_opp;
1557 u32 cap;
1558
1559 if (IS_ERR_OR_NULL(dev)) {
1560 ret = -EINVAL;
1561 goto failed;
1562 }
1563
1564 nr_opp = dev_pm_opp_get_opp_count(dev);
1565 if (nr_opp <= 0) {
1566 ret = -EINVAL;
1567 goto failed;
1568 }
1569
1570 /* First, try to find more precised Energy Model in DT */
1571 if (_of_has_opp_microwatt_property(dev)) {
> 1572 em_cb.active_power = _get_dt_power;
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]
On 3/1/22 16:58, kernel test robot wrote:
> Hi Lukasz,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on robh/for-next]
> [also build test ERROR on linux/master rafael-pm/linux-next linus/master v5.17-rc6 next-20220301]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Lukasz-Luba/Introduce-opp-microwatt-and-Energy-Model-from-DT/20220301-173700
> base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
> config: arc-randconfig-r014-20220301 (https://download.01.org/0day-ci/archive/20220302/[email protected]/config)
> compiler: arceb-elf-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/0day-ci/linux/commit/e1e83de9bf2f261cb3e5eb9f53bde3c83c6e0647
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Lukasz-Luba/Introduce-opp-microwatt-and-Energy-Model-from-DT/20220301-173700
> git checkout e1e83de9bf2f261cb3e5eb9f53bde3c83c6e0647
> # save the config file to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash drivers/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <[email protected]>
>
> All errors (new ones prefixed by >>):
>
> drivers/opp/of.c: In function 'dev_pm_opp_of_register_em':
>>> drivers/opp/of.c:1572:22: error: 'struct em_data_callback' has no member named 'active_power'
> 1572 | em_cb.active_power = _get_dt_power;
> | ^
>
Indeed, this structure is an empty definition for !EM kernels.
Let me create a fix for that.