Zwane's comment was correct, it needs to be CONFIG_X86_IO_APIC.
IMO this stuff really wants to be moved to __setup(),
to clean up the ifdefs and modularize the code.
===== arch/i386/kernel/setup.c 1.93 vs edited =====
--- 1.93/arch/i386/kernel/setup.c Wed Aug 20 14:15:34 2003
+++ edited/arch/i386/kernel/setup.c Wed Aug 20 21:27:05 2003
@@ -543,12 +543,12 @@
if (!acpi_force) acpi_disabled = 1;
}
-#ifdef CONFIG_X86_LOCAL_APIC
+#ifdef CONFIG_X86_IO_APIC
/* disable IO-APIC */
else if (!memcmp(from, "noapic", 6)) {
skip_ioapic_setup = 1;
}
-#endif /* CONFIG_X86_LOCAL_APIC */
+#endif /* CONFIG_X86_IO_APIC */
#endif /* CONFIG_ACPI_BOOT */
/*
On Thu, Aug 21, 2003 at 01:21:40AM -0400, Jeff Garzik wrote:
> Zwane's comment was correct, it needs to be CONFIG_X86_IO_APIC.
Does this also apply to 2.4.22-rc2?
I must use noapic on my system and 2.4.22 does ignore it, while
2.4.21 doesn't.
Regards
Ingo Oeser
On Fri, Aug 22, 2003 at 11:09:20AM +0200, Ingo Oeser wrote:
> On Thu, Aug 21, 2003 at 01:21:40AM -0400, Jeff Garzik wrote:
> > Zwane's comment was correct, it needs to be CONFIG_X86_IO_APIC.
>
> Does this also apply to 2.4.22-rc2?
>
> I must use noapic on my system and 2.4.22 does ignore it, while
> 2.4.21 doesn't.
Marcelo just pulled a bunch of ACPI fixes, so I would check the latest
BK, or wait for tonight's BK snapshot.
So, yes, it does apply to 2.4.22-rc2, but the Intel guys may have taken
care of it already.
Jeff
Looks like it's still ignored there (in BK). We did not realize the
problem we worked on ACPI problems. We'll look at the problem.
Thanks,
Jun
> -----Original Message-----
> From: Jeff Garzik [mailto:[email protected]]
> Sent: Friday, August 22, 2003 8:27 AM
> To: Ingo Oeser
> Cc: [email protected]
> Subject: Re: [patch] noapic should depend on ioapic config not local
>
> On Fri, Aug 22, 2003 at 11:09:20AM +0200, Ingo Oeser wrote:
> > On Thu, Aug 21, 2003 at 01:21:40AM -0400, Jeff Garzik wrote:
> > > Zwane's comment was correct, it needs to be CONFIG_X86_IO_APIC.
> >
> > Does this also apply to 2.4.22-rc2?
> >
> > I must use noapic on my system and 2.4.22 does ignore it, while
> > 2.4.21 doesn't.
>
> Marcelo just pulled a bunch of ACPI fixes, so I would check the latest
> BK, or wait for tonight's BK snapshot.
>
> So, yes, it does apply to 2.4.22-rc2, but the Intel guys may have
taken
> care of it already.
>
> Jeff
>
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe
linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
Yes, Marcelo pulled the fix for this into 2.4.22 from the acpi tree this
morning.
Let me know if you have any problems with it going forward.
Thanks,
-Len
> -----Original Message-----
> From: Nakajima, Jun
> Sent: Friday, August 22, 2003 7:12 PM
> To: Jeff Garzik; Ingo Oeser
> Cc: [email protected]
> Subject: RE: [patch] noapic should depend on ioapic config not local
>
>
> Looks like it's still ignored there (in BK). We did not realize the
> problem we worked on ACPI problems. We'll look at the problem.
>
> Thanks,
> Jun
>
> > -----Original Message-----
> > From: Jeff Garzik [mailto:[email protected]]
> > Sent: Friday, August 22, 2003 8:27 AM
> > To: Ingo Oeser
> > Cc: [email protected]
> > Subject: Re: [patch] noapic should depend on ioapic config not local
> >
> > On Fri, Aug 22, 2003 at 11:09:20AM +0200, Ingo Oeser wrote:
> > > On Thu, Aug 21, 2003 at 01:21:40AM -0400, Jeff Garzik wrote:
> > > > Zwane's comment was correct, it needs to be CONFIG_X86_IO_APIC.
> > >
> > > Does this also apply to 2.4.22-rc2?
> > >
> > > I must use noapic on my system and 2.4.22 does ignore it, while
> > > 2.4.21 doesn't.
> >
> > Marcelo just pulled a bunch of ACPI fixes, so I would check
> the latest
> > BK, or wait for tonight's BK snapshot.
> >
> > So, yes, it does apply to 2.4.22-rc2, but the Intel guys may have
> taken
> > care of it already.
> >
> > Jeff
> >
> >
> >
> > -
> > To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> > the body of a message to [email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
> -
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
Actually, it was a typo, "noapci" vs. "noacpi" :-<
"noapic" was recognized there ("noacpi" was not, we need to specify like
"pci=noacpi"), and I/O APIC(s) were correctly ignored (w/ ACPI or w/o
ACPI).
Thanks,
Jun
> -----Original Message-----
> From: Brown, Len
> Sent: Friday, August 22, 2003 6:26 PM
> To: Nakajima, Jun; Jeff Garzik; Ingo Oeser
> Cc: [email protected]
> Subject: RE: [patch] noapic should depend on ioapic config not local
>
> Yes, Marcelo pulled the fix for this into 2.4.22 from the acpi tree
this
> morning.
> Let me know if you have any problems with it going forward.
>
> Thanks,
> -Len
>
>
> > -----Original Message-----
> > From: Nakajima, Jun
> > Sent: Friday, August 22, 2003 7:12 PM
> > To: Jeff Garzik; Ingo Oeser
> > Cc: [email protected]
> > Subject: RE: [patch] noapic should depend on ioapic config not local
> >
> >
> > Looks like it's still ignored there (in BK). We did not realize the
> > problem we worked on ACPI problems. We'll look at the problem.
> >
> > Thanks,
> > Jun
> >
> > > -----Original Message-----
> > > From: Jeff Garzik [mailto:[email protected]]
> > > Sent: Friday, August 22, 2003 8:27 AM
> > > To: Ingo Oeser
> > > Cc: [email protected]
> > > Subject: Re: [patch] noapic should depend on ioapic config not
local
> > >
> > > On Fri, Aug 22, 2003 at 11:09:20AM +0200, Ingo Oeser wrote:
> > > > On Thu, Aug 21, 2003 at 01:21:40AM -0400, Jeff Garzik wrote:
> > > > > Zwane's comment was correct, it needs to be
CONFIG_X86_IO_APIC.
> > > >
> > > > Does this also apply to 2.4.22-rc2?
> > > >
> > > > I must use noapic on my system and 2.4.22 does ignore it, while
> > > > 2.4.21 doesn't.
> > >
> > > Marcelo just pulled a bunch of ACPI fixes, so I would check
> > the latest
> > > BK, or wait for tonight's BK snapshot.
> > >
> > > So, yes, it does apply to 2.4.22-rc2, but the Intel guys may have
> > taken
> > > care of it already.
> > >
> > > Jeff
> > >
> > >
> > >
> > > -
> > > To unsubscribe from this list: send the line "unsubscribe
> > linux-kernel" in
> > > the body of a message to [email protected]
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > > Please read the FAQ at http://www.tux.org/lkml/
> > -
> > To unsubscribe from this list: send the line "unsubscribe
> > linux-kernel" in
> > the body of a message to [email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
> >
> -
> To unsubscribe from this list: send the line "unsubscribe
linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/