2011-02-22 01:22:16

by Tomoya MORINAGA

[permalink] [raw]
Subject: spi_topcliff_pch: reload issue

Hi,

issue: after reload the spi module, it can't do SPI communication.

We have faced issue when execute the following command.
insmod xxx.ko(Then, /dev/spidev0.0 is created with success)
rmmod xxx.ko (Then, /dev/spidev0.0 is deleted with success)
insmod xxx.ko(Then, /dev/spidev0.0 is created, however, below error message is showed)

0000:02:0c.1: registered master spi0
0000:02:0c.1: chipselect 0 already in use
0000:02:0c.1: can't create new device for spidev

Do you have any information about the above ?

kernel=2.6.37 on FC14

With Best Regards,
-----------------------------------------
Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.


2011-02-22 12:00:39

by Tomoya MORINAGA

[permalink] [raw]
Subject: RE: spi_topcliff_pch: reload issue

Hi,

Previous my question included mistake.
I show modified below.

insmod spi_topcliff_pch.ko(Then, both /dev/spidev0.0/1.0 are created with success)
rmmod spi_topcliff_pch.ko (Then, both /dev/spidev0.0/1.0 are NOT deleted.)
insmod spi_topcliff_pch.ko(Then, kernel error occurred. Attached err_log)

I attached source code(power management is not updated) and kernel error log.

Do you have any information about the above ?

With Best Regards,
-----------------------------------------
Tomoya MORINAGA
OKI SEMICONDUCTOR CO., LTD.

> -----Original Message-----
> From: Tomoya MORINAGA [mailto:[email protected]]
> Sent: Tuesday, February 22, 2011 10:22 AM
> To: 'David Brownell'; 'Grant Likely';
> '[email protected]';
> '[email protected]'
> Cc: '[email protected]'; '[email protected]';
> '[email protected]'; '[email protected]'; Toshiharu Okada
> Subject: spi_topcliff_pch: reload issue
>
> Hi,
>
> issue: after reload the spi module, it can't do SPI communication.
>
> We have faced issue when execute the following command.
> insmod xxx.ko(Then, /dev/spidev0.0 is created with success)
> rmmod xxx.ko (Then, /dev/spidev0.0 is deleted with success)
> insmod xxx.ko(Then, /dev/spidev0.0 is created, however, below
> error message is showed)
>
> 0000:02:0c.1: registered master spi0
> 0000:02:0c.1: chipselect 0 already in use
> 0000:02:0c.1: can't create new device for spidev
>
> Do you have any information about the above ?
>
> kernel=2.6.37 on FC14
>
> With Best Regards,
> -----------------------------------------
> Tomoya MORINAGA
> OKI SEMICONDUCTOR CO., LTD.


Attachments:
spi_topcliff_pch.c (34.26 kB)
err_log (5.99 kB)
Download all attachments

2011-03-02 22:08:06

by Grant Likely

[permalink] [raw]
Subject: Re: spi_topcliff_pch: reload issue

On Tue, Feb 22, 2011 at 10:22:11AM +0900, Tomoya MORINAGA wrote:
> Hi,
>
> issue: after reload the spi module, it can't do SPI communication.
>
> We have faced issue when execute the following command.
> insmod xxx.ko(Then, /dev/spidev0.0 is created with success)
> rmmod xxx.ko (Then, /dev/spidev0.0 is deleted with success)
> insmod xxx.ko(Then, /dev/spidev0.0 is created, however, below error message is showed)
>
> 0000:02:0c.1: registered master spi0
> 0000:02:0c.1: chipselect 0 already in use
> 0000:02:0c.1: can't create new device for spidev
>
> Do you have any information about the above ?

Nope, I'm not an expert on that driver, but it definitely looks like a
bug! :-) It *looks* like the spi_device slaves are not getting unregistered
when the driver unloads. That's where I would start investigating.
The bug could either be in core code or the device driver itself, but
I don't know without digging deeper.

g.