2023-01-12 15:18:35

by 李扬韬

Subject: [PATCH 1/3] f2fs: clarify compress level bit offset

commit 3fde13f817e2 ("f2fs: compress: support compress level") introduce
compress level, which macro(COMPRESS_LEVEL_OFFSET) is 8, But use wrong
comment about compress level.

Let's fix it.

Signed-off-by: Yangtao Li <[email protected]>
---
include/linux/f2fs_fs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/f2fs_fs.h b/include/linux/f2fs_fs.h
index ee0d75d9a302..1701f25117ea 100644
--- a/include/linux/f2fs_fs.h
+++ b/include/linux/f2fs_fs.h
@@ -315,7 +315,7 @@ struct f2fs_inode {
__u8 i_log_cluster_size; /* log of cluster size */
__le16 i_compress_flag; /* compress flag */
/* 0 bit: chksum flag
- * [10,15] bits: compress level
+ * [8,15] bits: compress level
*/
__le32 i_extra_end[0]; /* for attribute size calculation */
} __packed;
--
2.25.1

2023-01-28 06:53:00

by Chao Yu

Subject: Re: [PATCH 1/3] f2fs: clarify compress level bit offset

On 2023/1/12 21:34, Yangtao Li wrote:
> commit 3fde13f817e2 ("f2fs: compress: support compress level") introduce
> compress level, which macro(COMPRESS_LEVEL_OFFSET) is 8, But use wrong
> comment about compress level.
>
> Let's fix it.
>
> Signed-off-by: Yangtao Li <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,

2023-01-30 23:03:44

by patchwork-bot+f2fs

Subject: Re: [f2fs-dev] [PATCH 1/3] f2fs: clarify compress level bit offset

Hello:

This series was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:

On Thu, 12 Jan 2023 21:34:43 +0800 you wrote:
> commit 3fde13f817e2 ("f2fs: compress: support compress level") introduce
> compress level, which macro(COMPRESS_LEVEL_OFFSET) is 8, But use wrong
> comment about compress level.
>
> Let's fix it.
>
> Signed-off-by: Yangtao Li <[email protected]>
>
> [...]

Here is the summary with links:
- [f2fs-dev,1/3] f2fs: clarify compress level bit offset
https://git.kernel.org/jaegeuk/f2fs/c/9adc6c8ff3da
- [f2fs-dev,2/3] f2fs: add F2FS_IOC_SET_COMPRESS_OPTION_V2 ioctl
(no matching commit)
- [f2fs-dev,3/3] f2fs: add F2FS_IOC_GET_COMPRESS_OPTION_V2 ioctl
(no matching commit)

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html