2024-04-23 18:29:34

by Prabhakar

Subject: [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list

From: Lad Prabhakar <[email protected]>

Group single const value items into an enum list.

Signed-off-by: Lad Prabhakar <[email protected]>
---
v1->v2
- Updated commit message
- Grouped single const value items into an enum list.
---
.../devicetree/bindings/mmc/renesas,sdhi.yaml | 18 +++++++-----------
1 file changed, 7 insertions(+), 11 deletions(-)

diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
index 29f2400247eb..2bf90095742b 100644
--- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
+++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
@@ -13,15 +13,13 @@ properties:
compatible:
oneOf:
- items:
- - const: renesas,sdhi-sh73a0 # R-Mobile APE6
- - items:
- - const: renesas,sdhi-r7s72100 # RZ/A1H
- - items:
- - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
- - items:
- - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
- - items:
- - const: renesas,sdhi-r8a7740 # R-Mobile A1
+ - enum:
+ - renesas,sdhi-sh73a0 # R-Mobile APE6
+ - renesas,sdhi-r7s72100 # RZ/A1H
+ - renesas,sdhi-r7s9210 # SH-Mobile AG5
+ - renesas,sdhi-r8a73a4 # R-Mobile APE6
+ - renesas,sdhi-r8a7740 # R-Mobile A1
+ - renesas,sdhi-mmc-r8a77470 # RZ/G1C
- items:
- enum:
- renesas,sdhi-r8a7778 # R-Car M1
@@ -40,8 +38,6 @@ properties:
- renesas,sdhi-r8a7793 # R-Car M2-N
- renesas,sdhi-r8a7794 # R-Car E2
- const: renesas,rcar-gen2-sdhi # R-Car Gen2 and RZ/G1
- - items:
- - const: renesas,sdhi-mmc-r8a77470 # RZ/G1C (SDHI/MMC IP)
- items:
- enum:
- renesas,sdhi-r8a774a1 # RZ/G2M
--
2.34.1

2024-04-24 05:43:04

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list

On 23/04/2024 20:24, Prabhakar wrote:
> From: Lad Prabhakar <[email protected]>
>
> Group single const value items into an enum list.
>
> Signed-off-by: Lad Prabhakar <[email protected]>
> ---
> v1->v2
> - Updated commit message
> - Grouped single const value items into an enum list.
> ---
> .../devicetree/bindings/mmc/renesas,sdhi.yaml | 18 +++++++-----------
> 1 file changed, 7 insertions(+), 11 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> index 29f2400247eb..2bf90095742b 100644
> --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> @@ -13,15 +13,13 @@ properties:
> compatible:
> oneOf:
> - items:
> - - const: renesas,sdhi-sh73a0 # R-Mobile APE6
> - - items:
> - - const: renesas,sdhi-r7s72100 # RZ/A1H
> - - items:
> - - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
> - - items:
> - - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
> - - items:
> - - const: renesas,sdhi-r8a7740 # R-Mobile A1
> + - enum:

You wanted to drop the items, but I still see it here.

> + - renesas,sdhi-sh73a0 # R-Mobile APE6
> + - renesas,sdhi-r7s72100 # RZ/A1H
> + - renesas,sdhi-r7s9210 # SH-Mobile AG5
> + - renesas,sdhi-r8a73a4 # R-Mobile APE6
> + - renesas,sdhi-r8a7740 # R-Mobile A1
> + - renesas,sdhi-mmc-r8a77470 # RZ/G1C

Keep list alphabetically ordered.



Best regards,
Krzysztof

2024-04-25 15:44:31

by Prabhakar

Subject: Re: [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list

Hi Krzysztof,

Thank you for the review.

On Wed, Apr 24, 2024 at 6:42 AM Krzysztof Kozlowski <[email protected]> wrote:
>
> On 23/04/2024 20:24, Prabhakar wrote:
> > From: Lad Prabhakar <[email protected]>
> >
> > Group single const value items into an enum list.
> >
> > Signed-off-by: Lad Prabhakar <[email protected]>
> > ---
> > v1->v2
> > - Updated commit message
> > - Grouped single const value items into an enum list.
> > ---
> > .../devicetree/bindings/mmc/renesas,sdhi.yaml | 18 +++++++-----------
> > 1 file changed, 7 insertions(+), 11 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > index 29f2400247eb..2bf90095742b 100644
> > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > @@ -13,15 +13,13 @@ properties:
> > compatible:
> > oneOf:
> > - items:
> > - - const: renesas,sdhi-sh73a0 # R-Mobile APE6
> > - - items:
> > - - const: renesas,sdhi-r7s72100 # RZ/A1H
> > - - items:
> > - - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
> > - - items:
> > - - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
> > - - items:
> > - - const: renesas,sdhi-r8a7740 # R-Mobile A1
> > + - enum:
>
> You wanted to drop the items, but I still see it here.
>
Ah, I missed that.

> > + - renesas,sdhi-sh73a0 # R-Mobile APE6
> > + - renesas,sdhi-r7s72100 # RZ/A1H
> > + - renesas,sdhi-r7s9210 # SH-Mobile AG5
> > + - renesas,sdhi-r8a73a4 # R-Mobile APE6
> > + - renesas,sdhi-r8a7740 # R-Mobile A1
> > + - renesas,sdhi-mmc-r8a77470 # RZ/G1C
>
> Keep list alphabetically ordered.
>
This list is sorted based on SoC, I will sort it alphabetically.

Geert is that OK with you?

Cheers,
Prabhakar

2024-04-25 17:13:09

by Geert Uytterhoeven

Subject: Re: [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list

Hi Prabhakar,

On Thu, Apr 25, 2024 at 5:44 PM Lad, Prabhakar
<[email protected]> wrote:
> On Wed, Apr 24, 2024 at 6:42 AM Krzysztof Kozlowski <[email protected]> wrote:
> > On 23/04/2024 20:24, Prabhakar wrote:
> > > From: Lad Prabhakar <[email protected]>
> > >
> > > Group single const value items into an enum list.
> > >
> > > Signed-off-by: Lad Prabhakar <[email protected]>
> > > ---
> > > v1->v2
> > > - Updated commit message
> > > - Grouped single const value items into an enum list.
> > > ---
> > > .../devicetree/bindings/mmc/renesas,sdhi.yaml | 18 +++++++-----------
> > > 1 file changed, 7 insertions(+), 11 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > > index 29f2400247eb..2bf90095742b 100644
> > > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > > @@ -13,15 +13,13 @@ properties:
> > > compatible:
> > > oneOf:
> > > - items:
> > > - - const: renesas,sdhi-sh73a0 # R-Mobile APE6
> > > - - items:
> > > - - const: renesas,sdhi-r7s72100 # RZ/A1H
> > > - - items:
> > > - - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
> > > - - items:
> > > - - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
> > > - - items:
> > > - - const: renesas,sdhi-r8a7740 # R-Mobile A1
> > > + - enum:
> >
> > You wanted to drop the items, but I still see it here.
> >
> Ah, I missed that.
>
> > > + - renesas,sdhi-sh73a0 # R-Mobile APE6
> > > + - renesas,sdhi-r7s72100 # RZ/A1H
> > > + - renesas,sdhi-r7s9210 # SH-Mobile AG5
> > > + - renesas,sdhi-r8a73a4 # R-Mobile APE6
> > > + - renesas,sdhi-r8a7740 # R-Mobile A1
> > > + - renesas,sdhi-mmc-r8a77470 # RZ/G1C
> >
> > Keep list alphabetically ordered.
> >
> This list is sorted based on SoC, I will sort it alphabetically.
>
> Geert is that OK with you?

Usually we sort alphabetically by compatible value.

(FTR, sh73a0 is sometimes called r8a73a0).

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2024-04-25 18:35:35

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list

On 25/04/2024 19:11, Geert Uytterhoeven wrote:
>>
>>>> + - renesas,sdhi-sh73a0 # R-Mobile APE6
>>>> + - renesas,sdhi-r7s72100 # RZ/A1H
>>>> + - renesas,sdhi-r7s9210 # SH-Mobile AG5
>>>> + - renesas,sdhi-r8a73a4 # R-Mobile APE6
>>>> + - renesas,sdhi-r8a7740 # R-Mobile A1
>>>> + - renesas,sdhi-mmc-r8a77470 # RZ/G1C
>>>
>>> Keep list alphabetically ordered.
>>>
>> This list is sorted based on SoC, I will sort it alphabetically.
>>
>> Geert is that OK with you?
>
> Usually we sort alphabetically by compatible value.

BTW, it is also fine if you keep some other sorting rule there, which is
in general known to interested parties. Although I would argue that most
people adding new entries are not aware of such rules, thus they add
things to the end increasing the chances for conflicts.

Best regards,
Krzysztof

2024-04-25 18:56:19

by Prabhakar

Subject: Re: [PATCH v2 1/3] dt-bindings: mmc: renesas,sdhi: Group single const value items into an enum list

Hi Geert,

On Thu, Apr 25, 2024 at 6:11 PM Geert Uytterhoeven <[email protected]> wrote:
>
> Hi Prabhakar,
>
> On Thu, Apr 25, 2024 at 5:44 PM Lad, Prabhakar
> <[email protected]> wrote:
> > On Wed, Apr 24, 2024 at 6:42 AM Krzysztof Kozlowski <[email protected]> wrote:
> > > On 23/04/2024 20:24, Prabhakar wrote:
> > > > From: Lad Prabhakar <[email protected]>
> > > >
> > > > Group single const value items into an enum list.
> > > >
> > > > Signed-off-by: Lad Prabhakar <[email protected]>
> > > > ---
> > > > v1->v2
> > > > - Updated commit message
> > > > - Grouped single const value items into an enum list.
> > > > ---
> > > > .../devicetree/bindings/mmc/renesas,sdhi.yaml | 18 +++++++-----------
> > > > 1 file changed, 7 insertions(+), 11 deletions(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > > > index 29f2400247eb..2bf90095742b 100644
> > > > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > > > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml
> > > > @@ -13,15 +13,13 @@ properties:
> > > > compatible:
> > > > oneOf:
> > > > - items:
> > > > - - const: renesas,sdhi-sh73a0 # R-Mobile APE6
> > > > - - items:
> > > > - - const: renesas,sdhi-r7s72100 # RZ/A1H
> > > > - - items:
> > > > - - const: renesas,sdhi-r7s9210 # SH-Mobile AG5
> > > > - - items:
> > > > - - const: renesas,sdhi-r8a73a4 # R-Mobile APE6
> > > > - - items:
> > > > - - const: renesas,sdhi-r8a7740 # R-Mobile A1
> > > > + - enum:
> > >
> > > You wanted to drop the items, but I still see it here.
> > >
> > Ah, I missed that.
> >
> > > > + - renesas,sdhi-sh73a0 # R-Mobile APE6
> > > > + - renesas,sdhi-r7s72100 # RZ/A1H
> > > > + - renesas,sdhi-r7s9210 # SH-Mobile AG5
> > > > + - renesas,sdhi-r8a73a4 # R-Mobile APE6
> > > > + - renesas,sdhi-r8a7740 # R-Mobile A1
> > > > + - renesas,sdhi-mmc-r8a77470 # RZ/G1C
> > >
> > > Keep list alphabetically ordered.
> > >
> > This list is sorted based on SoC, I will sort it alphabetically.
> >
> > Geert is that OK with you?
>
> Usually we sort alphabetically by compatible value.
>
Thank you for the confirmation.

> (FTR, sh73a0 is sometimes called r8a73a0).
>
Got that.

Cheers,
Prabhakar