2024-03-26 13:49:35

by Adrián Larumbe

Subject: [PATCH] ABI: sysfs-driver-panfrost-profiling: fix indentation problem

Also add a newline character at the end of the last one.

Fixes: b12f3ea7c188 ("drm/panfrost: Replace fdinfo's profiling debugfs knob with sysfs")
Reported-by: Stephen Rothwell <[email protected]>
Closes: https://lore.kernel.org/dri-devel/[email protected]/
Signed-off-by: Adrián Larumbe <[email protected]>
---
Documentation/ABI/testing/sysfs-driver-panfrost-profiling | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/ABI/testing/sysfs-driver-panfrost-profiling b/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
index 1d8bb0978920..7597c420e54b 100644
--- a/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
+++ b/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
@@ -7,4 +7,4 @@ Description:
Valid values are:
0: Don't enable fdinfo job profiling sources.
1: Enable fdinfo job profiling sources, this enables both the GPU's
- timestamp and cycle counter registers.
\ No newline at end of file
+ timestamp and cycle counter registers.
--
2.43.0

2024-03-26 22:07:09

by Randy Dunlap

Subject: Re: [PATCH] ABI: sysfs-driver-panfrost-profiling: fix indentation problem

On 3/26/24 06:48, Adrián Larumbe wrote:
> Also add a newline character at the end of the last one.
>
> Fixes: b12f3ea7c188 ("drm/panfrost: Replace fdinfo's profiling debugfs knob with sysfs")
> Reported-by: Stephen Rothwell <[email protected]>
> Closes: https://lore.kernel.org/dri-devel/[email protected]/
> Signed-off-by: Adrián Larumbe <[email protected]>

Acked-by: Randy Dunlap <[email protected]>
Tested-by: Randy Dunlap <[email protected]>

Thanks.

> ---
> Documentation/ABI/testing/sysfs-driver-panfrost-profiling | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-driver-panfrost-profiling b/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
> index 1d8bb0978920..7597c420e54b 100644
> --- a/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
> +++ b/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
> @@ -7,4 +7,4 @@ Description:
> Valid values are:
> 0: Don't enable fdinfo job profiling sources.
> 1: Enable fdinfo job profiling sources, this enables both the GPU's
> - timestamp and cycle counter registers.
> \ No newline at end of file
> + timestamp and cycle counter registers.

--
#Randy

2024-03-27 16:03:22

by Steven Price

Subject: Re: [PATCH] ABI: sysfs-driver-panfrost-profiling: fix indentation problem

On 26/03/2024 13:48, Adrián Larumbe wrote:
> Also add a newline character at the end of the last one.
>
> Fixes: b12f3ea7c188 ("drm/panfrost: Replace fdinfo's profiling debugfs knob with sysfs")
> Reported-by: Stephen Rothwell <[email protected]>
> Closes: https://lore.kernel.org/dri-devel/[email protected]/
> Signed-off-by: Adrián Larumbe <[email protected]>

Looks reasonable, the other option is to make this a proper ReST list,
but it's probably not worth it with just two values.

Reviewed-by: Steven Price <[email protected]>

> ---
> Documentation/ABI/testing/sysfs-driver-panfrost-profiling | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-driver-panfrost-profiling b/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
> index 1d8bb0978920..7597c420e54b 100644
> --- a/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
> +++ b/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
> @@ -7,4 +7,4 @@ Description:
> Valid values are:
> 0: Don't enable fdinfo job profiling sources.
> 1: Enable fdinfo job profiling sources, this enables both the GPU's
> - timestamp and cycle counter registers.
> \ No newline at end of file
> + timestamp and cycle counter registers.

2024-03-28 15:42:58

by Steven Price

Subject: Re: [PATCH] ABI: sysfs-driver-panfrost-profiling: fix indentation problem

On 26/03/2024 13:48, Adrián Larumbe wrote:
> Also add a newline character at the end of the last one.
>
> Fixes: b12f3ea7c188 ("drm/panfrost: Replace fdinfo's profiling debugfs knob with sysfs")
> Reported-by: Stephen Rothwell <[email protected]>
> Closes: https://lore.kernel.org/dri-devel/[email protected]/
> Signed-off-by: Adrián Larumbe <[email protected]>

Queued to drm-misc-next

Thanks,

Steve

> ---
> Documentation/ABI/testing/sysfs-driver-panfrost-profiling | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-driver-panfrost-profiling b/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
> index 1d8bb0978920..7597c420e54b 100644
> --- a/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
> +++ b/Documentation/ABI/testing/sysfs-driver-panfrost-profiling
> @@ -7,4 +7,4 @@ Description:
> Valid values are:
> 0: Don't enable fdinfo job profiling sources.
> 1: Enable fdinfo job profiling sources, this enables both the GPU's
> - timestamp and cycle counter registers.
> \ No newline at end of file
> + timestamp and cycle counter registers.