2020-05-28 15:09:33

by Colin King

Subject: [PATCH][next] RDMA/hns: remove duplicate assignment to pointer raq

From: Colin Ian King <[email protected]>

The pointer raq is being assigned twice. Fix this by removing
one of the redundant assignments.

Fixes: 14ba87304bf9 ("RDMA/hns: Remove redundant type cast for general pointers")
Addressses-Coverity: ("Evaluation order violation")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
index 8ff6b922b4d7..d02207cd30df 100644
--- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
+++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
@@ -1146,7 +1146,7 @@ static void hns_roce_db_free(struct hns_roce_dev *hr_dev)
static int hns_roce_raq_init(struct hns_roce_dev *hr_dev)
{
struct hns_roce_v1_priv *priv = hr_dev->priv;
- struct hns_roce_raq_table *raq = raq = &priv->raq_table;
+ struct hns_roce_raq_table *raq = &priv->raq_table;
struct device *dev = &hr_dev->pdev->dev;
int raq_shift = 0;
dma_addr_t addr;
--
2.25.1

2020-05-29 07:30:43

by oulijun

Subject: Re: [PATCH][next] RDMA/hns: remove duplicate assignment to pointer raq

在 2020/5/28 23:04, Colin King 写道:
> From: Colin Ian King <[email protected]>
>
> The pointer raq is being assigned twice. Fix this by removing
> one of the redundant assignments.
>
> Fixes: 14ba87304bf9 ("RDMA/hns: Remove redundant type cast for general pointers")
> Addressses-Coverity: ("Evaluation order violation")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> index 8ff6b922b4d7..d02207cd30df 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> @@ -1146,7 +1146,7 @@ static void hns_roce_db_free(struct hns_roce_dev *hr_dev)
> static int hns_roce_raq_init(struct hns_roce_dev *hr_dev)
> {
> struct hns_roce_v1_priv *priv = hr_dev->priv;
> - struct hns_roce_raq_table *raq = raq = &priv->raq_table;
> + struct hns_roce_raq_table *raq = &priv->raq_table;
> struct device *dev = &hr_dev->pdev->dev;
> int raq_shift = 0;
> dma_addr_t addr;
>
thanks

2020-05-29 18:23:14

by Jason Gunthorpe

Subject: Re: [PATCH][next] RDMA/hns: remove duplicate assignment to pointer raq

On Thu, May 28, 2020 at 04:04:27PM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The pointer raq is being assigned twice. Fix this by removing
> one of the redundant assignments.
>
> Fixes: 14ba87304bf9 ("RDMA/hns: Remove redundant type cast for general pointers")
> Addressses-Coverity: ("Evaluation order violation")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next

Thanks,
Jason