2022-10-17 19:41:12

by Caleb Connolly

[permalink] [raw]
Subject: [PATCH v3] arm64: dts: qcom: pmi8998: add rradc node

Add a DT node for the Round Robin ADC found in the PMI8998 PMIC.

The RRADC reports PMIC die and skin temperatures, as well as
battery/charger thermals. It also reports USB and DC charger voltage and
current measurements.

Signed-off-by: Caleb Connolly <[email protected]>
---
This patch introduces a new dtbs_check warning which will be fixed by
https://lore.kernel.org/linux-arm-msm/[email protected]/

V2: https://lore.kernel.org/linux-arm-msm/[email protected]/
Changes since v2:
* Remove 'status = "okay";'

V1:
https://lore.kernel.org/linux-arm-msm/[email protected]/
Changes since v1:
* Change node name from adc@ to rradc@, see linked patch
* Enable the RRADC by default, rather than per-device
---
arch/arm64/boot/dts/qcom/pmi8998.dtsi | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
index 6d3d212560c1..08c9ec2cafa6 100644
--- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
@@ -18,6 +18,12 @@ pmi8998_gpio: gpios@c000 {
interrupt-controller;
#interrupt-cells = <2>;
};
+
+ pmi8998_rradc: rradc@4500 {
+ compatible = "qcom,pmi8998-rradc";
+ reg = <0x4500>;
+ #io-channel-cells = <1>;
+ };
};

pmi8998_lsid1: pmic@3 {
--
2.38.0


2022-10-17 19:45:43

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH v3] arm64: dts: qcom: pmi8998: add rradc node

On 2022-10-17 21:09, Caleb Connolly wrote:
> Add a DT node for the Round Robin ADC found in the PMI8998 PMIC.
>
> The RRADC reports PMIC die and skin temperatures, as well as
> battery/charger thermals. It also reports USB and DC charger voltage
> and
> current measurements.
>
> Signed-off-by: Caleb Connolly <[email protected]>
> ---
> This patch introduces a new dtbs_check warning which will be fixed by
> https://lore.kernel.org/linux-arm-msm/[email protected]/
>
> V2:
> https://lore.kernel.org/linux-arm-msm/[email protected]/
> Changes since v2:
> * Remove 'status = "okay";'
>
> V1:
> https://lore.kernel.org/linux-arm-msm/[email protected]/
> Changes since v1:
> * Change node name from adc@ to rradc@, see linked patch
> * Enable the RRADC by default, rather than per-device
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/pmi8998.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> index 6d3d212560c1..08c9ec2cafa6 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> @@ -18,6 +18,12 @@ pmi8998_gpio: gpios@c000 {
> interrupt-controller;
> #interrupt-cells = <2>;
> };
> +
> + pmi8998_rradc: rradc@4500 {
> + compatible = "qcom,pmi8998-rradc";
> + reg = <0x4500>;
> + #io-channel-cells = <1>;
> + };
> };
>
> pmi8998_lsid1: pmic@3 {

2022-10-17 20:55:56

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3] arm64: dts: qcom: pmi8998: add rradc node

On 17/10/2022 15:09, Caleb Connolly wrote:
> Add a DT node for the Round Robin ADC found in the PMI8998 PMIC.
>
> The RRADC reports PMIC die and skin temperatures, as well as
> battery/charger thermals. It also reports USB and DC charger voltage and
> current measurements.
>
> Signed-off-by: Caleb Connolly <[email protected]>
> ---
> This patch introduces a new dtbs_check warning which will be fixed by
> https://lore.kernel.org/linux-arm-msm/[email protected]/
>
> V2: https://lore.kernel.org/linux-arm-msm/[email protected]/
> Changes since v2:
> * Remove 'status = "okay";'
>
> V1:
> https://lore.kernel.org/linux-arm-msm/[email protected]/
> Changes since v1:
> * Change node name from adc@ to rradc@, see linked patch
> * Enable the RRADC by default, rather than per-device
> ---
> arch/arm64/boot/dts/qcom/pmi8998.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> index 6d3d212560c1..08c9ec2cafa6 100644
> --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> @@ -18,6 +18,12 @@ pmi8998_gpio: gpios@c000 {
> interrupt-controller;
> #interrupt-cells = <2>;
> };
> +
> + pmi8998_rradc: rradc@4500 {

No, generic node names so adc. Please do not send DTS patches separate
from the bindings.

Best regards,
Krzysztof