2018-11-07 07:19:20

by Yi Wang

Subject: [PATCH] cpuset: remove set but not used variable 'cs'

This fixes the following warning:
kernel/cgroup/cpuset.c: In function ‘cpuset_cancel_attach’:
kernel/cgroup/cpuset.c:1501:17: warning: variable ‘cs’ set but not used [-Wunused-but-set-variable]
struct cpuset *cs;
^

Signed-off-by: Yi Wang <[email protected]>
---
kernel/cgroup/cpuset.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index 266f10c..784f948 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -1498,10 +1498,8 @@ static int cpuset_can_attach(struct cgroup_taskset *tset)
static void cpuset_cancel_attach(struct cgroup_taskset *tset)
{
struct cgroup_subsys_state *css;
- struct cpuset *cs;

cgroup_taskset_first(tset, &css);
- cs = css_cs(css);

mutex_lock(&cpuset_mutex);
css_cs(css)->attach_in_progress--;
--
1.8.3.1

2018-11-07 22:10:45

by Tom Hromatka

Subject: Re: [PATCH] cpuset: remove set but not used variable 'cs'

On 11/07/2018 12:18 AM, Yi Wang wrote:
> This fixes the following warning:
> kernel/cgroup/cpuset.c: In function ‘cpuset_cancel_attach’:
> kernel/cgroup/cpuset.c:1501:17: warning: variable ‘cs’ set but not used [-Wunused-but-set-variable]
> struct cpuset *cs;
> ^
>
> Signed-off-by: Yi Wang <[email protected]>


Reviewed-by: Tom Hromatka <[email protected]>


> ---
> kernel/cgroup/cpuset.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
> index 266f10c..784f948 100644
> --- a/kernel/cgroup/cpuset.c
> +++ b/kernel/cgroup/cpuset.c
> @@ -1498,10 +1498,8 @@ static int cpuset_can_attach(struct cgroup_taskset *tset)
> static void cpuset_cancel_attach(struct cgroup_taskset *tset)
> {
> struct cgroup_subsys_state *css;
> - struct cpuset *cs;
>
> cgroup_taskset_first(tset, &css);
> - cs = css_cs(css);
>
> mutex_lock(&cpuset_mutex);
> css_cs(css)->attach_in_progress--;
>