2022-04-25 22:23:03

by Christopher Obbard

Subject: [PATCH v2 1/3] media: dt-bindings: media: rockchip-vdec: Add RK3328 compatible

Document the RK3328 compatible for rockchip-vdec.

Signed-off-by: Christopher Obbard <[email protected]>
---
Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 3 +++
1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
index 089f11d21b25..ce06835e8d61 100644
--- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
+++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
@@ -20,6 +20,9 @@ properties:
- items:
- const: rockchip,rk3228-vdec
- const: rockchip,rk3399-vdec
+ - items:
+ - const: rockchip,rk3328-vdec
+ - const: rockchip,rk3399-vdec

reg:
maxItems: 1
--
2.34.1

2022-04-26 15:12:09

by Christopher Obbard

Subject: Re: [PATCH v2 1/3] media: dt-bindings: media: rockchip-vdec: Add RK3328 compatible

On 25/04/2022 19:07, Krzysztof Kozlowski wrote:
> On 25/04/2022 14:32, Christopher Obbard wrote:
>> Document the RK3328 compatible for rockchip-vdec.
>>
>> Signed-off-by: Christopher Obbard <[email protected]>
>> ---
>> Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
>> index 089f11d21b25..ce06835e8d61 100644
>> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
>> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
>> @@ -20,6 +20,9 @@ properties:
>> - items:
>> - const: rockchip,rk3228-vdec
>> - const: rockchip,rk3399-vdec
>> + - items:
>> + - const: rockchip,rk3328-vdec
>> + - const: rockchip,rk3399-vdec
>
>
> This should be rather an enum with rk3228, so:
> - enum
> - rockchip,rk3228-vdec
> - rockchip,rk3328-vdec
> - const: rockchip,rk3399-vdec


Thanks for your patience with reviewing the series. I sent v3 which
should finally solve this now.

Cheers!

Chris

2022-04-27 10:58:34

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 1/3] media: dt-bindings: media: rockchip-vdec: Add RK3328 compatible

On 25/04/2022 14:32, Christopher Obbard wrote:
> Document the RK3328 compatible for rockchip-vdec.
>
> Signed-off-by: Christopher Obbard <[email protected]>
> ---
> Documentation/devicetree/bindings/media/rockchip,vdec.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> index 089f11d21b25..ce06835e8d61 100644
> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> @@ -20,6 +20,9 @@ properties:
> - items:
> - const: rockchip,rk3228-vdec
> - const: rockchip,rk3399-vdec
> + - items:
> + - const: rockchip,rk3328-vdec
> + - const: rockchip,rk3399-vdec


This should be rather an enum with rk3228, so:
- enum
- rockchip,rk3228-vdec
- rockchip,rk3328-vdec
- const: rockchip,rk3399-vdec

Best regards,
Krzysztof