2017-07-18 21:45:16

by Rob Herring (Arm)

Subject: [PATCH] spmi: Convert to using %pOF instead of full_name

Now that we have a custom printf format specifier, convert users of
full_name to use %pOF instead. This is preparation to remove storing
of the full path string for each node.

Signed-off-by: Rob Herring <[email protected]>
---
drivers/spmi/spmi.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
index 2b9b0941d9eb..c14b4201210c 100644
--- a/drivers/spmi/spmi.c
+++ b/drivers/spmi/spmi.c
@@ -454,27 +454,25 @@ static void of_spmi_register_devices(struct spmi_controller *ctrl)
struct spmi_device *sdev;
u32 reg[2];

- dev_dbg(&ctrl->dev, "adding child %s\n", node->full_name);
+ dev_dbg(&ctrl->dev, "adding child %pOF\n", node);

err = of_property_read_u32_array(node, "reg", reg, 2);
if (err) {
dev_err(&ctrl->dev,
- "node %s err (%d) does not have 'reg' property\n",
- node->full_name, err);
+ "node %pOF err (%d) does not have 'reg' property\n",
+ node, err);
continue;
}

if (reg[1] != SPMI_USID) {
dev_err(&ctrl->dev,
- "node %s contains unsupported 'reg' entry\n",
- node->full_name);
+ "node %pOF contains unsupported 'reg' entry\n",
+ node);
continue;
}

if (reg[0] >= SPMI_MAX_SLAVE_ID) {
- dev_err(&ctrl->dev,
- "invalid usid on node %s\n",
- node->full_name);
+ dev_err(&ctrl->dev, "invalid usid on node %pOF\n", node);
continue;
}

--
2.11.0

2017-08-09 21:50:57

by Rob Herring (Arm)

Subject: Re: [PATCH] spmi: Convert to using %pOF instead of full_name

+Stephen

On Tue, Jul 18, 2017 at 4:43 PM, Rob Herring <[email protected]> wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> drivers/spmi/spmi.c | 14 ++++++--------
> 1 file chqanged, 6 insertions(+), 8 deletions(-)

Looks like I missed Stephen recently being added as maintainer. Do you
need me to resend this?

Rob

2017-08-09 22:14:08

by Stephen Boyd

Subject: Re: [PATCH] spmi: Convert to using %pOF instead of full_name

On 08/09/2017 02:50 PM, Rob Herring wrote:
> +Stephen
>
> On Tue, Jul 18, 2017 at 4:43 PM, Rob Herring <[email protected]> wrote:
>> Now that we have a custom printf format specifier, convert users of
>> full_name to use %pOF instead. This is preparation to remove storing
>> of the full path string for each node.
>>
>> Signed-off-by: Rob Herring <[email protected]>
>> ---
>> drivers/spmi/spmi.c | 14 ++++++--------
>> 1 file chqanged, 6 insertions(+), 8 deletions(-)
> Looks like I missed Stephen recently being added as maintainer. Do you
> need me to resend this?
>

Greg is still applying the patches, unless he doesn't want to do it. I'm
just "R" for reviewer.

Reviewed-by: Stephen Boyd <[email protected]>

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project