On 11/08/2017 06:27 PM, Bjorn Helgaas wrote:
> On Wed, Nov 08, 2017 at 12:45:49PM +0000, Joao Pinto wrote:
>> Hello to all,
>>
>> Às 12:56 AM de 11/8/2017, Bjorn Helgaas escreveu:
>>> On Fri, Nov 03, 2017 at 02:47:05PM +0100, Niklas Cassel wrote:
>>>> Use the DMA-API to get the MSI address. This address will be written to
>>>> our PCI config space and to the register which determines which AXI
>>>> address the DWC IP will spoof for incoming MSI irqs.
>>>>
>>>> Since it is a PCIe endpoint device, rather than the CPU, that is supposed
>>>> to write to the MSI address, the proper way to get the MSI address is by
>>>> using the DMA API, not by using virt_to_phys().
>>>>
>>>> Using virt_to_phys() might work on some systems, but using the DMA API
>>>> should work on all systems.
>>>>
>>>> This is essentially the same thing as allocating a buffer in a driver
>>>> to which the endpoint will write to. To do this, we use the DMA API.
>>>>
>>>> Signed-off-by: Niklas Cassel <[email protected]>
>>>
>>> I'm expecting Jingoo and/or Joao to chime in and ack the
>>> DesignWare-related patches. I think all the others are in
>>> pretty good shape.
>>>
>>>> ---
>>>> drivers/pci/dwc/pcie-designware-host.c | 15 ++++++++++++---
>>>> drivers/pci/dwc/pcie-designware.h | 3 ++-
>>>> 2 files changed, 14 insertions(+), 4 deletions(-)
>>>> ...
>>
>> Let me test this patch-set in my setup first!
>> I will give feedback until Friday.
>
> OK, thanks. This may push this series out until v4.16 because the
> v4.15 merge window will probably open Sunday, and I don't like to add
> code during the window and merge it immediately.
>
I suspected as much. The general rule seems to be that
a patch has to be in linux-next for at least 2 weeks
before sending it to Linus.
No worries, there is not really a rush.
Regards,
Niklas
From 1583519754802665867@xxx Wed Nov 08 17:28:39 +0000 2017
X-GM-THRID: 1583053296841603702
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread