2021-09-17 13:38:15

by Rajesh Patil

Subject: [PATCH V8 1/8] dt-bindings: spi: Add sc7280 support

Add compatible for sc7280 SoC.

Signed-off-by: Rajesh Patil <[email protected]>
---
Changes in V8:
- As per Doug's comments, added "qcom,sc7280-qspi" compatible

Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
index ef5698f..31711fe 100644
--- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
+++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
@@ -21,7 +21,10 @@ allOf:
properties:
compatible:
items:
- - const: qcom,sdm845-qspi
+ - enum:
+ - qcom,sdm845-qspi
+ - qcom,sc7280-qspi
+
- const: qcom,qspi-v1

reg:
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

2021-09-18 03:16:49

by Rob Herring (Arm)

Subject: Re: [PATCH V8 1/8] dt-bindings: spi: Add sc7280 support

On Fri, 17 Sep 2021 15:18:00 +0530, Rajesh Patil wrote:
> Add compatible for sc7280 SoC.
>
> Signed-off-by: Rajesh Patil <[email protected]>
> ---
> Changes in V8:
> - As per Doug's comments, added "qcom,sc7280-qspi" compatible
>
> Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml:25:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1529304

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.

2021-09-18 03:53:46

by Doug Anderson

Subject: Re: [PATCH V8 1/8] dt-bindings: spi: Add sc7280 support

Hi,

On Fri, Sep 17, 2021 at 2:49 AM Rajesh Patil <[email protected]> wrote:
>
> Add compatible for sc7280 SoC.
>
> Signed-off-by: Rajesh Patil <[email protected]>
> ---
> Changes in V8:
> - As per Doug's comments, added "qcom,sc7280-qspi" compatible
>
> Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
> index ef5698f..31711fe 100644
> --- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
> @@ -21,7 +21,10 @@ allOf:
> properties:
> compatible:
> items:
> - - const: qcom,sdm845-qspi
> + - enum:
> + - qcom,sdm845-qspi
> + - qcom,sc7280-qspi

Other than the fact that the indentation is wrong (as Rob's bot
found), this looks good to me. Feel free to add my Reviewed-by when
you fix the indentation. In theory you could also be nice and add the
sc7180-qspi at the same time, I think.

-Doug

2021-09-21 04:13:18

by Rajesh Patil

Subject: Re: [PATCH V8 1/8] dt-bindings: spi: Add sc7280 support

On 2021-09-18 01:32, Doug Anderson wrote:
> Hi,
>
> On Fri, Sep 17, 2021 at 2:49 AM Rajesh Patil <[email protected]>
> wrote:
>>
>> Add compatible for sc7280 SoC.
>>
>> Signed-off-by: Rajesh Patil <[email protected]>
>> ---
>> Changes in V8:
>> - As per Doug's comments, added "qcom,sc7280-qspi" compatible
>>
>> Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5
>> ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
>> b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
>> index ef5698f..31711fe 100644
>> --- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
>> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
>> @@ -21,7 +21,10 @@ allOf:
>> properties:
>> compatible:
>> items:
>> - - const: qcom,sdm845-qspi
>> + - enum:
>> + - qcom,sdm845-qspi
>> + - qcom,sc7280-qspi
>
> Other than the fact that the indentation is wrong (as Rob's bot
> found), this looks good to me. Feel free to add my Reviewed-by when
> you fix the indentation. In theory you could also be nice and add the
> sc7180-qspi at the same time, I think.
>
> -Doug

Okay

2021-09-21 06:26:39

by Rajesh Patil

Subject: Re: [PATCH V8 1/8] dt-bindings: spi: Add sc7280 support

On 2021-09-18 01:32, Doug Anderson wrote:
> Hi,
>
> On Fri, Sep 17, 2021 at 2:49 AM Rajesh Patil <[email protected]>
> wrote:
>>
>> Add compatible for sc7280 SoC.
>>
>> Signed-off-by: Rajesh Patil <[email protected]>
>> ---
>> Changes in V8:
>> - As per Doug's comments, added "qcom,sc7280-qspi" compatible
>>
>> Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml | 5
>> ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
>> b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
>> index ef5698f..31711fe 100644
>> --- a/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
>> +++ b/Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.yaml
>> @@ -21,7 +21,10 @@ allOf:
>> properties:
>> compatible:
>> items:
>> - - const: qcom,sdm845-qspi
>> + - enum:
>> + - qcom,sdm845-qspi
>> + - qcom,sc7280-qspi
>
> Other than the fact that the indentation is wrong (as Rob's bot
> found), this looks good to me. Feel free to add my Reviewed-by when
> you fix the indentation. In theory you could also be nice and add the
> sc7180-qspi at the same time, I think.
>
> -Doug

Adding dt-bindings for sc7180 will send in the follow-up patches.