2023-04-10 16:26:50

by Daniel Golle

[permalink] [raw]
Subject: [PATCH v3 0/2] i2c: i2c-mt65xx: add support for MT7981

Add support for the I2C units found in the MediaTek MT7981 and MT7988
SoCs. Just like other recent MediaTek I2C units that also uses v3
register offsets (which differ from v2 only by OFFSET_SLAVE_ADDR being
0x94 instead of 0x4).

Corresponding commit in MediaTek's SDK:
https://git01.mediatek.com/plugins/gitiles/openwrt/feeds/mtk-openwrt-feeds/+/472dc5cf11d4359cb3e3f80577dba22df0696e43/target/linux/mediatek/patches-5.4/0901-i2c-busses-add-mt7981-support.patch

Changes since v2:
* bindings come before patches using them
* remove reduntant word 'bindings' from dt-bindings commit

Changes since v1:
* add missing commit description
* add link to commit in MediaTek's SDK to cover letter

Daniel Golle (2):
dt-bindings: i2c: i2c-mt65xx: add MediaTek MT7981 SoC
i2c: mediatek: add support for MT7981 SoC

.../devicetree/bindings/i2c/i2c-mt65xx.yaml | 1 +
drivers/i2c/busses/i2c-mt65xx.c | 13 +++++++++++++
2 files changed, 14 insertions(+)


base-commit: e134c93f788fb93fd6a3ec3af9af850a2048c7e6
--
2.40.0


2023-04-10 16:27:21

by Daniel Golle

[permalink] [raw]
Subject: [PATCH v3 2/2] i2c: mediatek: add support for MT7981 SoC

Add support for the I2C units found in the MediaTek MT7981 and MT7988
SoCs. Just like other recent MediaTek I2C units that also uses v3
register offsets (which differ from v2 only by OFFSET_SLAVE_ADDR being
0x94 instead of 0x4).

Signed-off-by: Daniel Golle <[email protected]>
---
drivers/i2c/busses/i2c-mt65xx.c | 13 +++++++++++++
1 file changed, 13 insertions(+)

diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
index 59eaefe999b11..a43c4d77739ab 100644
--- a/drivers/i2c/busses/i2c-mt65xx.c
+++ b/drivers/i2c/busses/i2c-mt65xx.c
@@ -431,6 +431,18 @@ static const struct mtk_i2c_compatible mt8168_compat = {
.max_dma_support = 33,
};

+static const struct mtk_i2c_compatible mt7981_compat = {
+ .regs = mt_i2c_regs_v3,
+ .pmic_i2c = 0,
+ .dcm = 0,
+ .auto_restart = 1,
+ .aux_len_reg = 1,
+ .timing_adjust = 1,
+ .dma_sync = 1,
+ .ltiming_adjust = 1,
+ .max_dma_support = 33
+};
+
static const struct mtk_i2c_compatible mt7986_compat = {
.quirks = &mt7622_i2c_quirks,
.regs = mt_i2c_regs_v1,
@@ -516,6 +528,7 @@ static const struct of_device_id mtk_i2c_of_match[] = {
{ .compatible = "mediatek,mt6577-i2c", .data = &mt6577_compat },
{ .compatible = "mediatek,mt6589-i2c", .data = &mt6589_compat },
{ .compatible = "mediatek,mt7622-i2c", .data = &mt7622_compat },
+ { .compatible = "mediatek,mt7981-i2c", .data = &mt7981_compat },
{ .compatible = "mediatek,mt7986-i2c", .data = &mt7986_compat },
{ .compatible = "mediatek,mt8168-i2c", .data = &mt8168_compat },
{ .compatible = "mediatek,mt8173-i2c", .data = &mt8173_compat },
--
2.40.0

2023-04-10 16:28:20

by Daniel Golle

[permalink] [raw]
Subject: [PATCH v3 1/2] dt-bindings: i2c: i2c-mt65xx: add MediaTek MT7981 SoC

Add compatible string for the I2C controllers found in the MediaTek
MT7981 SoC.

Signed-off-by: Daniel Golle <[email protected]>
---
Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml
index 685da4df688d6..fda0467cdd954 100644
--- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml
+++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.yaml
@@ -23,6 +23,7 @@ properties:
- const: mediatek,mt6577-i2c
- const: mediatek,mt6589-i2c
- const: mediatek,mt7622-i2c
+ - const: mediatek,mt7981-i2c
- const: mediatek,mt7986-i2c
- const: mediatek,mt8168-i2c
- const: mediatek,mt8173-i2c
--
2.40.0

2023-04-11 05:56:17

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] dt-bindings: i2c: i2c-mt65xx: add MediaTek MT7981 SoC

On 10/04/2023 18:19, Daniel Golle wrote:
> Add compatible string for the I2C controllers found in the MediaTek
> MT7981 SoC.
>
> Signed-off-by: Daniel Golle <[email protected]>

Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

Subject: Re: [PATCH v3 2/2] i2c: mediatek: add support for MT7981 SoC

Il 10/04/23 18:19, Daniel Golle ha scritto:
> Add support for the I2C units found in the MediaTek MT7981 and MT7988
> SoCs. Just like other recent MediaTek I2C units that also uses v3
> register offsets (which differ from v2 only by OFFSET_SLAVE_ADDR being
> 0x94 instead of 0x4).
>
> Signed-off-by: Daniel Golle <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

Subject: Re: [PATCH v3 1/2] dt-bindings: i2c: i2c-mt65xx: add MediaTek MT7981 SoC

Il 10/04/23 18:19, Daniel Golle ha scritto:
> Add compatible string for the I2C controllers found in the MediaTek
> MT7981 SoC.
>
> Signed-off-by: Daniel Golle <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>


2023-04-11 08:32:47

by Alexandre Mergnat

[permalink] [raw]
Subject: Re: [PATCH v3 2/2] i2c: mediatek: add support for MT7981 SoC

On 10/04/2023 18:19, Daniel Golle wrote:
> Add support for the I2C units found in the MediaTek MT7981 and MT7988
> SoCs. Just like other recent MediaTek I2C units that also uses v3
> register offsets (which differ from v2 only by OFFSET_SLAVE_ADDR being
> 0x94 instead of 0x4).

Reviewed-by: Alexandre Mergnat <[email protected]>

2023-04-13 16:47:57

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH v3 2/2] i2c: mediatek: add support for MT7981 SoC

On Mon, Apr 10, 2023 at 05:19:38PM +0100, Daniel Golle wrote:
> Add support for the I2C units found in the MediaTek MT7981 and MT7988
> SoCs. Just like other recent MediaTek I2C units that also uses v3
> register offsets (which differ from v2 only by OFFSET_SLAVE_ADDR being
> 0x94 instead of 0x4).
>
> Signed-off-by: Daniel Golle <[email protected]>

Applied to for-next, thanks!


Attachments:
(No filename) (397.00 B)
signature.asc (849.00 B)
Download all attachments

2023-04-13 16:48:55

by Wolfram Sang

[permalink] [raw]
Subject: Re: [PATCH v3 1/2] dt-bindings: i2c: i2c-mt65xx: add MediaTek MT7981 SoC

On Mon, Apr 10, 2023 at 05:19:21PM +0100, Daniel Golle wrote:
> Add compatible string for the I2C controllers found in the MediaTek
> MT7981 SoC.
>
> Signed-off-by: Daniel Golle <[email protected]>

Applied to for-next, thanks!


Attachments:
(No filename) (242.00 B)
signature.asc (849.00 B)
Download all attachments