2023-12-05 19:23:06

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.4 00/90] 5.4.263-rc3 review

This is the start of the stable review cycle for the 5.4.263 release.
There are 90 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.

Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.263-rc3.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>
Linux 5.4.263-rc3

Adrian Hunter <[email protected]>
mmc: block: Retry commands in CQE error recovery

Zheng Yongjun <[email protected]>
mmc: core: convert comma to semicolon

Adrian Hunter <[email protected]>
mmc: cqhci: Fix task clearing in CQE error recovery

Adrian Hunter <[email protected]>
mmc: cqhci: Warn of halt or task clear failure

Adrian Hunter <[email protected]>
mmc: cqhci: Increase recovery halt timeout

Christoph Niedermaier <[email protected]>
cpufreq: imx6q: Don't disable 792 Mhz OPP unnecessarily

Christoph Niedermaier <[email protected]>
cpufreq: imx6q: don't warn for disabling a non-existing frequency

Quinn Tran <[email protected]>
scsi: qla2xxx: Fix system crash due to bad pointer access

Bart Van Assche <[email protected]>
scsi: qla2xxx: Use scsi_cmd_to_rq() instead of scsi_cmnd.request

Bart Van Assche <[email protected]>
scsi: core: Introduce the scsi_cmd_to_rq() function

Bart Van Assche <[email protected]>
scsi: qla2xxx: Simplify the code for aborting SCSI commands

Mimi Zohar <[email protected]>
ima: detect changes to the backing overlay file

Konstantin Khlebnikov <[email protected]>
ovl: skip overlayfs superblocks at global sync

Amir Goldstein <[email protected]>
ima: annotate iint mutex to avoid lockdep false positive warnings

Helge Deller <[email protected]>
fbdev: stifb: Make the STI next font pointer a 32-bit signed offset

Linus Walleij <[email protected]>
mtd: cfi_cmdset_0001: Byte swap OTP info

Jean-Philippe Brucker <[email protected]>
mtd: cfi_cmdset_0001: Support the absence of protection registers

Heiko Carstens <[email protected]>
s390/cmma: fix detection of DAT pages

Alexander Gordeev <[email protected]>
s390/mm: fix phys vs virt confusion in mark_kernel_pXd() functions family

Steve French <[email protected]>
smb3: fix touch -h of symlink

Claudiu Beznea <[email protected]>
net: ravb: Start TX queues after HW initialization succeeded

Claudiu Beznea <[email protected]>
net: ravb: Use pm_runtime_resume_and_get()

Yoshihiro Shimoda <[email protected]>
ravb: Fix races between ravb_tx_timeout_work() and net related ops

Furong Xu <[email protected]>
net: stmmac: xgmac: Disable FPE MMC interrupts

Zhengchao Shao <[email protected]>
ipv4: igmp: fix refcnt uaf issue when receiving igmp query packet

Max Nguyen <[email protected]>
Input: xpad - add HyperX Clutch Gladiate Support

Filipe Manana <[email protected]>
btrfs: make error messages more clear when getting a chunk map

Jann Horn <[email protected]>
btrfs: send: ensure send_fd is writable

Filipe Manana <[email protected]>
btrfs: fix off-by-one when checking chunk map includes logical address

Qu Wenruo <[email protected]>
btrfs: add dmesg output for first mount and last unmount of a filesystem

Timothy Pearson <[email protected]>
powerpc: Don't clobber f0/vs0 during fp|altivec register save

Markus Weippert <[email protected]>
bcache: revert replacing IS_ERR_OR_NULL with IS_ERR

Wu Bo <[email protected]>
dm verity: don't perform FEC for failed readahead IO

Mikulas Patocka <[email protected]>
dm-verity: align struct dm_verity_fec_io properly

Kailang Yang <[email protected]>
ALSA: hda/realtek: Add supported ALC257 for ChromeOS

Kailang Yang <[email protected]>
ALSA: hda/realtek: Headset Mic VREF to 100%

Takashi Iwai <[email protected]>
ALSA: hda: Disable power-save on KONTRON SinglePC

Adrian Hunter <[email protected]>
mmc: block: Do not lose cache flush during CQE error recovery

Yang Yingliang <[email protected]>
firewire: core: fix possible memory leak in create_units()

Maria Yu <[email protected]>
pinctrl: avoid reload of p state in list iteration

Keith Busch <[email protected]>
io_uring: fix off-by one bvec index

Johan Hovold <[email protected]>
USB: dwc3: qcom: fix wakeup after probe deferral

Johan Hovold <[email protected]>
USB: dwc3: qcom: fix resource leaks on probe deferral

Ricardo Ribalda <[email protected]>
usb: dwc3: set the dma max_seg_size

Oliver Neukum <[email protected]>
USB: dwc2: write HCINT with INTMASK applied

Lech Perczak <[email protected]>
USB: serial: option: don't claim interface 4 for ZTE MF290

Puliang Lu <[email protected]>
USB: serial: option: fix FM101R-GL defines

Victor Fragoso <[email protected]>
USB: serial: option: add Fibocom L7xx modules

Rand Deeb <[email protected]>
bcache: prevent potential division by zero error

Coly Li <[email protected]>
bcache: check return value from btree_node_alloc_replacement()

Mikulas Patocka <[email protected]>
dm-delay: fix a race between delay_presuspend and delay_bio

Long Li <[email protected]>
hv_netvsc: Mark VF as slave before exposing it to user-mode

Haiyang Zhang <[email protected]>
hv_netvsc: Fix race of register_netdevice_notifier and VF register

Asuna Yang <[email protected]>
USB: serial: option: add Luat Air72*U series products

Jan Höppner <[email protected]>
s390/dasd: protect device queue against concurrent access

Coly Li <[email protected]>
bcache: replace a mistaken IS_ERR() by IS_ERR_OR_NULL() in btree_gc_coalesce()

Hans de Goede <[email protected]>
ACPI: resource: Skip IRQ override on ASUS ExpertBook B1402CVA

Andrew Murray <[email protected]>
KVM: arm64: limit PMU version to PMUv3 for ARMv8.1

Andrew Murray <[email protected]>
arm64: cpufeature: Extract capped perfmon fields

Zhang Yi <[email protected]>
ext4: make sure allocate pending entry not fail

Baokun Li <[email protected]>
ext4: fix slab-use-after-free in ext4_es_insert_extent()

Baokun Li <[email protected]>
ext4: using nofail preallocation in ext4_es_insert_extent()

Baokun Li <[email protected]>
ext4: using nofail preallocation in ext4_es_insert_delayed_block()

Baokun Li <[email protected]>
ext4: using nofail preallocation in ext4_es_remove_extent()

Baokun Li <[email protected]>
ext4: use pre-allocated es in __es_remove_extent()

Baokun Li <[email protected]>
ext4: use pre-allocated es in __es_insert_extent()

Baokun Li <[email protected]>
ext4: factor out __es_alloc_extent() and __es_free_extent()

Baokun Li <[email protected]>
ext4: add a new helper to check if es must be kept

Huacai Chen <[email protected]>
MIPS: KVM: Fix a build warning about variable set but not used

Christoph Hellwig <[email protected]>
nvmet: nul-terminate the NQNs passed in the connect command

Chaitanya Kulkarni <[email protected]>
nvmet: remove unnecessary ctrl parameter

David Howells <[email protected]>
afs: Fix file locking on R/O volumes to operate in local mode

David Howells <[email protected]>
afs: Return ENOENT if no cell DNS record can be found

Samuel Holland <[email protected]>
net: axienet: Fix check for partial TX checksum

Raju Rangoju <[email protected]>
amd-xgbe: propagate the correct speed and duplex status

Raju Rangoju <[email protected]>
amd-xgbe: handle the corner-case during tx completion

Raju Rangoju <[email protected]>
amd-xgbe: handle corner-case during sfp hotplug

Stefano Stabellini <[email protected]>
arm/xen: fix xen_vcpu_info allocation alignment

Jose Ignacio Tornos Martinez <[email protected]>
net: usb: ax88179_178a: fix failed operations during ax88179_reset

Kunwu Chan <[email protected]>
ipv4: Correct/silence an endian warning in __ip_do_redirect

Charles Yi <[email protected]>
HID: fix HID device resource race between HID core and debugging support

Benjamin Tissoires <[email protected]>
HID: core: store the unique system identifier in hid_device

Jonas Karlman <[email protected]>
drm/rockchip: vop: Fix color for RGB888/BGR888 format on VOP full

Chen Ni <[email protected]>
ata: pata_isapnp: Add missing error check for devm_ioport_map()

Marek Vasut <[email protected]>
drm/panel: simple: Fix Innolux G101ICE-L01 timings

Marek Vasut <[email protected]>
drm/panel: simple: Fix Innolux G101ICE-L01 bus flags

David Howells <[email protected]>
afs: Make error on cell lookup failure consistent with OpenAFS

Nathan Chancellor <[email protected]>
PCI: keystone: Drop __init from ks_pcie_add_pcie_{ep,port}()

Christopher Bednarz <[email protected]>
RDMA/irdma: Prevent zero-length STAG registration

Saravana Kannan <[email protected]>
driver core: Release all resources during unbind before updating device links


-------------

Diffstat:

Makefile | 4 +-
arch/arm/xen/enlighten.c | 3 +-
arch/arm64/include/asm/cpufeature.h | 23 ++
arch/arm64/include/asm/sysreg.h | 6 +
arch/arm64/kvm/sys_regs.c | 10 +
arch/mips/kvm/mmu.c | 3 +-
arch/powerpc/kernel/fpu.S | 13 +
arch/powerpc/kernel/vector.S | 2 +
arch/s390/mm/page-states.c | 14 +-
drivers/acpi/resource.c | 7 +
drivers/ata/pata_isapnp.c | 3 +
drivers/base/dd.c | 4 +-
drivers/cpufreq/imx6q-cpufreq.c | 32 +--
drivers/firewire/core-device.c | 11 +-
drivers/gpu/drm/panel/panel-simple.c | 13 +-
drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 14 +-
drivers/hid/hid-core.c | 16 +-
drivers/hid/hid-debug.c | 3 +
drivers/infiniband/hw/i40iw/i40iw_ctrl.c | 6 +
drivers/infiniband/hw/i40iw/i40iw_type.h | 2 +
drivers/infiniband/hw/i40iw/i40iw_verbs.c | 10 +-
drivers/input/joystick/xpad.c | 2 +
drivers/md/bcache/btree.c | 6 +-
drivers/md/bcache/sysfs.c | 2 +-
drivers/md/dm-delay.c | 17 +-
drivers/md/dm-verity-fec.c | 3 +-
drivers/md/dm-verity-target.c | 4 +-
drivers/md/dm-verity.h | 6 -
drivers/mmc/core/block.c | 2 +
drivers/mmc/core/core.c | 15 +-
drivers/mmc/host/cqhci.c | 44 ++--
drivers/mtd/chips/cfi_cmdset_0001.c | 29 +-
drivers/net/ethernet/amd/xgbe/xgbe-drv.c | 14 +
drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c | 11 +-
drivers/net/ethernet/amd/xgbe/xgbe-mdio.c | 14 +-
drivers/net/ethernet/renesas/ravb_main.c | 20 +-
drivers/net/ethernet/stmicro/stmmac/mmc_core.c | 4 +
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
drivers/net/hyperv/netvsc_drv.c | 41 ++-
drivers/net/usb/ax88179_178a.c | 4 +-
drivers/nvme/target/core.c | 21 +-
drivers/nvme/target/fabrics-cmd.c | 15 +-
drivers/nvme/target/nvmet.h | 5 +-
drivers/pci/controller/dwc/pci-keystone.c | 8 +-
drivers/pinctrl/core.c | 6 +-
drivers/s390/block/dasd.c | 24 +-
drivers/scsi/qla2xxx/qla_def.h | 3 -
drivers/scsi/qla2xxx/qla_isr.c | 5 -
drivers/scsi/qla2xxx/qla_os.c | 39 +--
drivers/usb/dwc2/hcd_intr.c | 15 +-
drivers/usb/dwc3/core.c | 2 +
drivers/usb/dwc3/dwc3-qcom.c | 17 +-
drivers/usb/serial/option.c | 11 +-
drivers/video/fbdev/sticore.h | 2 +-
fs/afs/dynroot.c | 4 +-
fs/afs/super.c | 2 +
fs/afs/vl_rotate.c | 10 +
fs/btrfs/disk-io.c | 1 +
fs/btrfs/send.c | 2 +-
fs/btrfs/super.c | 5 +-
fs/btrfs/volumes.c | 9 +-
fs/cifs/cifsfs.c | 1 +
fs/ext4/extents_status.c | 306 +++++++++++++++-------
fs/io_uring.c | 2 +-
fs/overlayfs/super.c | 5 +-
fs/sync.c | 3 +-
include/linux/fs.h | 2 +
include/linux/hid.h | 5 +
include/scsi/scsi_cmnd.h | 6 +
net/ipv4/igmp.c | 6 +-
net/ipv4/route.c | 2 +-
security/integrity/iint.c | 48 +++-
security/integrity/ima/ima_api.c | 5 +
security/integrity/ima/ima_main.c | 16 +-
security/integrity/integrity.h | 2 +
sound/pci/hda/hda_intel.c | 2 +
sound/pci/hda/patch_realtek.c | 12 +
77 files changed, 753 insertions(+), 315 deletions(-)



2023-12-05 21:49:03

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 5.4 00/90] 5.4.263-rc3 review

On 12/5/23 11:22, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.263 release.
> There are 90 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.263-rc3.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
BMIPS_GENERIC:

Tested-by: Florian Fainelli <[email protected]>
--
Florian

2023-12-06 11:19:28

by Harshit Mogalapalli

[permalink] [raw]
Subject: Re: [PATCH 5.4 00/90] 5.4.263-rc3 review

Hi Greg,

On 06/12/23 12:52 am, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.263 release.
> There are 90 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000.
> Anything received after that time might be too late.
>

No problems seen on x86_64 and aarch64 with our testing.

Tested-by: Harshit Mogalapalli <[email protected]>

Thanks,
Harshit
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.263-rc3.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

2023-12-06 11:49:53

by Jon Hunter

[permalink] [raw]
Subject: Re: [PATCH 5.4 00/90] 5.4.263-rc3 review

On Wed, 06 Dec 2023 04:22:16 +0900, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.263 release.
> There are 90 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.263-rc3.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

All tests passing for Tegra ...

Test results for stable-v5.4:
10 builds: 10 pass, 0 fail
24 boots: 24 pass, 0 fail
54 tests: 54 pass, 0 fail

Linux version: 5.4.263-rc3-g97430ed51c91
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra20-ventana,
tegra210-p2371-2180, tegra210-p3450-0000,
tegra30-cardhu-a04

Tested-by: Jon Hunter <[email protected]>

Jon

2023-12-06 13:16:36

by Naresh Kamboju

[permalink] [raw]
Subject: Re: [PATCH 5.4 00/90] 5.4.263-rc3 review

On Wed, 6 Dec 2023 at 00:52, Greg Kroah-Hartman
<[email protected]> wrote:
>
> This is the start of the stable review cycle for the 5.4.263 release.
> There are 90 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.263-rc3.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h


Results from Linaro's test farm.
No regressions on arm64, arm, x86_64, and i386.

Tested-by: Linux Kernel Functional Testing <[email protected]>

## Build
* kernel: 5.4.263-rc3
* git: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
* git branch: linux-5.4.y
* git commit: 97430ed51c915b4a8037655ac6656a644fd42e9e
* git describe: v5.4.262-91-g97430ed51c91
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.4.y/build/v5.4.262-91-g97430ed51c91

## Test Regressions (compared to v5.4.262)

## Metric Regressions (compared to v5.4.262)

## Test Fixes (compared to v5.4.262)

## Metric Fixes (compared to v5.4.262)

## Test result summary
total: 90072, pass: 70700, fail: 2384, skip: 16945, xfail: 43

## Build Summary
* arc: 5 total, 5 passed, 0 failed
* arm: 148 total, 129 passed, 19 failed
* arm64: 47 total, 45 passed, 2 failed
* i386: 30 total, 24 passed, 6 failed
* mips: 27 total, 27 passed, 0 failed
* parisc: 3 total, 0 passed, 3 failed
* powerpc: 32 total, 32 passed, 0 failed
* riscv: 15 total, 15 passed, 0 failed
* s390: 8 total, 8 passed, 0 failed
* sh: 10 total, 10 passed, 0 failed
* sparc: 8 total, 8 passed, 0 failed
* x86_64: 41 total, 41 passed, 0 failed

## Test suites summary
* boot
* kselftest-android
* kselftest-arm64
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-drivers-dma-buf
* kselftest-efivarfs
* kselftest-exec
* kselftest-filesystems
* kselftest-filesystems-binderfs
* kselftest-filesystems-epoll
* kselftest-firmware
* kselftest-fpu
* kselftest-ftrace
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-ir
* kselftest-kcmp
* kselftest-kexec
* kselftest-kvm
* kselftest-lib
* kselftest-membarrier
* kselftest-memfd
* kselftest-memory-hotplug
* kselftest-mincore
* kselftest-mount
* kselftest-mqueue
* kselftest-net
* kselftest-net-forwarding
* kselftest-net-mptcp
* kselftest-netfilter
* kselftest-nsfs
* kselftest-openat2
* kselftest-pid_namespace
* kselftest-pidfd
* kselftest-proc
* kselftest-pstore
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-sigaltstack
* kselftest-size
* kselftest-tc-testing
* kselftest-timens
* kselftest-timers
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user
* kselftest-user_events
* kselftest-vDSO
* kselftest-vm
* kselftest-watchdog
* kselftest-x86
* kselftest-zram
* kunit
* log-parser-boot
* log-parser-test
* ltp-cap_bounds
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-filecaps
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-fsx
* ltp-hugetlb
* ltp-io
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-pty
* ltp-sched
* ltp-securebits
* ltp-smoke
* ltp-syscalls
* ltp-tracing
* perf
* rcutorture

--
Linaro LKFT
https://lkft.linaro.org

2023-12-06 16:06:23

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH 5.4 00/90] 5.4.263-rc3 review

On 12/5/23 12:22, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.263 release.
> There are 90 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.4.263-rc3.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.4.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>

Compiled and booted on my test system. No dmesg regressions.

Tested-by: Shuah Khan <[email protected]>

thanks,
-- Shuah

2023-12-06 18:44:30

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 5.4 00/90] 5.4.263-rc3 review

On Wed, Dec 06, 2023 at 04:22:16AM +0900, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.263 release.
> There are 90 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000.
> Anything received after that time might be too late.
>

Build results:
total: 152 pass: 152 fail: 0
Qemu test results:
total: 462 pass: 462 fail: 0

Tested-by: Guenter Roeck <[email protected]>

Guenter

2023-12-08 18:09:34

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 5.4 00/90] 5.4.263-rc3 review

On 12/5/23 11:22, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.4.263 release.
> There are 90 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000.
> Anything received after that time might be too late.
>
[ ... ]
> Qu Wenruo <[email protected]>
> btrfs: add dmesg output for first mount and last unmount of a filesystem
>

This patch results in the following code in fs/btrfs/disk-io.c:open_ctree():

struct btrfs_super_block *disk_super;
... (no access to disk_super)
btrfs_info(fs_info, "first mount of filesystem %pU", disk_super->fsid);

which I would assume _should_ result in btrfs crashes. No idea why that isn't
actually happening or why gcc doesn't complain. Building allmodconfig with
clang does complain, but doesn't bail out.

s/btrfs/disk-io.c:2832:55: warning: variable 'disk_super' is uninitialized when used here [-Wuninitialized]
btrfs_info(fs_info, "first mount of filesystem %pU", disk_super->fsid);
^~~~~~~~~~

The actual log output is:

[ 7.302427] BTRFS info (device nvme0n1): first mount of filesystem (efault)

It might be a good idea to either revert this patch or fix it up
(though I don't know how to fix it up).

Guenter

2023-12-11 14:57:04

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.4 00/90] 5.4.263-rc3 review

On Fri, Dec 08, 2023 at 10:09:17AM -0800, Guenter Roeck wrote:
> On 12/5/23 11:22, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.4.263 release.
> > There are 90 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 07 Dec 2023 18:32:16 +0000.
> > Anything received after that time might be too late.
> >
> [ ... ]
> > Qu Wenruo <[email protected]>
> > btrfs: add dmesg output for first mount and last unmount of a filesystem
> >
>
> This patch results in the following code in fs/btrfs/disk-io.c:open_ctree():
>
> struct btrfs_super_block *disk_super;
> ... (no access to disk_super)
> btrfs_info(fs_info, "first mount of filesystem %pU", disk_super->fsid);
>
> which I would assume _should_ result in btrfs crashes. No idea why that isn't
> actually happening or why gcc doesn't complain. Building allmodconfig with
> clang does complain, but doesn't bail out.
>
> s/btrfs/disk-io.c:2832:55: warning: variable 'disk_super' is uninitialized when used here [-Wuninitialized]
> btrfs_info(fs_info, "first mount of filesystem %pU", disk_super->fsid);
> ^~~~~~~~~~
>
> The actual log output is:
>
> [ 7.302427] BTRFS info (device nvme0n1): first mount of filesystem (efault)
>
> It might be a good idea to either revert this patch or fix it up
> (though I don't know how to fix it up).

yeah, that doesn't look good, now reverted, thanks!

greg k-h