2023-10-09 11:46:06

by Arnd Bergmann

Subject: [PATCH] clk: imx: imx8: build base support for scu clk

From: Arnd Bergmann <[email protected]>

There is now a dependency on a function from the clk.c file, so
this also needs to be built:

aarch64-linux-ld: Unexpected GOT/PLT entries detected!
aarch64-linux-ld: Unexpected run-time procedure linkages detected!
aarch64-linux-ld: drivers/clk/imx/clk-imx8-acm.o: in function `imx8_acm_clk_probe':
clk-imx8-acm.c:(.text+0xbf0): undefined reference to `imx_check_clk_hws'

Fixes: d3a0946d7ac9a ("clk: imx: imx8: add audio clock mux driver")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/clk/imx/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/Kconfig b/drivers/clk/imx/Kconfig
index db3bca5f4ec9c..c6d3fda330341 100644
--- a/drivers/clk/imx/Kconfig
+++ b/drivers/clk/imx/Kconfig
@@ -6,6 +6,7 @@ config MXC_CLK

config MXC_CLK_SCU
tristate
+ select MXC_CLK

config CLK_IMX1
def_bool SOC_IMX1
--
2.39.2

2023-10-09 11:49:00

by Peng Fan

Subject: RE: [PATCH] clk: imx: imx8: build base support for scu clk

> Subject: [PATCH] clk: imx: imx8: build base support for scu clk
>
> From: Arnd Bergmann <[email protected]>
>
> There is now a dependency on a function from the clk.c file, so this also needs
> to be built:
>
> aarch64-linux-ld: Unexpected GOT/PLT entries detected!
> aarch64-linux-ld: Unexpected run-time procedure linkages detected!
> aarch64-linux-ld: drivers/clk/imx/clk-imx8-acm.o: in function
> `imx8_acm_clk_probe':
> clk-imx8-acm.c:(.text+0xbf0): undefined reference to `imx_check_clk_hws'
>
> Fixes: d3a0946d7ac9a ("clk: imx: imx8: add audio clock mux driver")
> Signed-off-by: Arnd Bergmann <[email protected]>

Acked-by: Peng Fan <[email protected]>

2023-10-10 18:57:06

by Stephen Boyd

Subject: Re: [PATCH] clk: imx: imx8: build base support for scu clk

Quoting Arnd Bergmann (2023-10-09 04:44:55)
> From: Arnd Bergmann <[email protected]>
>
> There is now a dependency on a function from the clk.c file, so
> this also needs to be built:
>
> aarch64-linux-ld: Unexpected GOT/PLT entries detected!
> aarch64-linux-ld: Unexpected run-time procedure linkages detected!
> aarch64-linux-ld: drivers/clk/imx/clk-imx8-acm.o: in function `imx8_acm_clk_probe':
> clk-imx8-acm.c:(.text+0xbf0): undefined reference to `imx_check_clk_hws'
>
> Fixes: d3a0946d7ac9a ("clk: imx: imx8: add audio clock mux driver")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---

Is this another https://lore.kernel.org/r/[email protected]

2023-10-10 19:27:32

by Arnd Bergmann

Subject: Re: [PATCH] clk: imx: imx8: build base support for scu clk

On Tue, Oct 10, 2023, at 20:56, Stephen Boyd wrote:
> Quoting Arnd Bergmann (2023-10-09 04:44:55)
>> From: Arnd Bergmann <[email protected]>
>>
>> There is now a dependency on a function from the clk.c file, so
>> this also needs to be built:
>>
>> aarch64-linux-ld: Unexpected GOT/PLT entries detected!
>> aarch64-linux-ld: Unexpected run-time procedure linkages detected!
>> aarch64-linux-ld: drivers/clk/imx/clk-imx8-acm.o: in function `imx8_acm_clk_probe':
>> clk-imx8-acm.c:(.text+0xbf0): undefined reference to `imx_check_clk_hws'
>>
>> Fixes: d3a0946d7ac9a ("clk: imx: imx8: add audio clock mux driver")
>> Signed-off-by: Arnd Bergmann <[email protected]>
>> ---
>
> Is this another
> https://lore.kernel.org/r/[email protected]

I think that's correct and my patch is not needed any more now.
It looks like it was already obsolete when I sent it, but I can't
find out why that is. I'll let you know if it comes back.

Arnd