2022-06-09 03:33:57

by ChiYuan Huang

Subject: [PATCH v3 1/2] dt-bindings: backlight: rt4831: Add the new ocp level property

From: ChiYuan Huang <[email protected]>

Add 'richtek,bled-ocp-microamp' property to make it chooseable.

The wrong backlight ocp level may affect the backlight channel output
current smaller than configured.

Signed-off-by: ChiYuan Huang <[email protected]>
---
Since v3:
- Refine the description for backlight ocp property.
- Use the enum to list the supported value.

Since v2:
- Change the property name from 'richtek,bled-ocp-sel' to 'richtek,bled-ocp-microamp'.

---
.../devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml
index e0ac686..99e9e13 100644
--- a/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml
+++ b/Documentation/devicetree/bindings/leds/backlight/richtek,rt4831-backlight.yaml
@@ -47,6 +47,11 @@ properties:
minimum: 0
maximum: 3

+ richtek,bled-ocp-microamp:
+ description: |
+ Backlight over current protection level.
+ enum: [900000, 1200000, 1500000, 1800000]
+
richtek,channel-use:
description: |
Backlight LED channel to be used.
--
2.7.4

2022-06-09 09:31:29

by Daniel Thompson

Subject: Re: [PATCH v3 1/2] dt-bindings: backlight: rt4831: Add the new ocp level property

On Thu, Jun 09, 2022 at 10:22:18AM +0800, cy_huang wrote:
> From: ChiYuan Huang <[email protected]>
>
> Add 'richtek,bled-ocp-microamp' property to make it chooseable.
>
> The wrong backlight ocp level may affect the backlight channel output
> current smaller than configured.
>
> Signed-off-by: ChiYuan Huang <[email protected]>

Reviewed-by: Daniel Thompson <[email protected]>


Daniel.

2022-06-09 10:38:26

by Krzysztof Kozlowski

Subject: Re: [PATCH v3 1/2] dt-bindings: backlight: rt4831: Add the new ocp level property

On 09/06/2022 04:22, cy_huang wrote:
> From: ChiYuan Huang <[email protected]>
>
> Add 'richtek,bled-ocp-microamp' property to make it chooseable.
>
> The wrong backlight ocp level may affect the backlight channel output
> current smaller than configured.
>
> Signed-off-by: ChiYuan Huang <[email protected]>
> ---
> Since v3:
> - Refine the description for backlight ocp property.
> - Use the enum to list the supported value.
>
> Since v2:
> - Change the property name from 'richtek,bled-ocp-sel' to 'richtek,bled-ocp-microamp'.
>


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof