2024-05-21 10:43:08

by Markus Elfring

[permalink] [raw]
Subject: Re: [v2] platform/x86: ISST: fix use-after-free in tpmi_sst_dev_remove()

>>>>>> …
>>>>>>> Fix this by reordering the kfree() post the dereference.

> We'll not waste our time in wordsmithing commit messages to perfection,

I hope that you would also like to avoid typos in change descriptions.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n45


> the current one is good enough as was stated to you already.

I dared to present some wording concerns according to the running patch review.

Regards,
Markus


2024-05-21 12:17:24

by Ilpo Järvinen

[permalink] [raw]
Subject: Re: [v2] platform/x86: ISST: fix use-after-free in tpmi_sst_dev_remove()

On Tue, 21 May 2024, Markus Elfring wrote:

> >>>>>> …
> >>>>>>> Fix this by reordering the kfree() post the dereference.
> …
> > We'll not waste our time in wordsmithing commit messages to perfection,
>
> I hope that you would also like to avoid typos in change descriptions.

Now you start derailing this with off-topic references to hypothetical
"typos".

> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.9#n45
>
>
> > the current one is good enough as was stated to you already.
>
> I dared to present some wording concerns according to the running patch review.

No, your latest replies were not anymore about wording concerns but
complaining about process.

Your wording concerns were already replied but after that you kept on
arguing.

--
i.