This seems to be missing the corresponding mpt2 updates. Nak to
anything that gets these drivers further out of sync.
Btw, I still need a second ACK for
http://www.spinics.net/lists/linux-scsi/msg82027.html
as well, so we can start getting rid of this duplication mess.
Hi Chris,
There are no corresponding mpt2sas driver's patches, The last phase
for mpt2sas drivers is Phase20 and this phase driver is already exits
in the upstream kernel. Also mpt2sas driver is completely in maintains
mode and there won't be any new features.
Whereas mpt3sas is at its initial baseline with a healthy road map
ahead and also we are planning to use same mpt3sas driver for next
upcoming Avago IT HBA's. So merging mpt2sas driver with mpt3sas driver
may break mpt2sas driver functionality in future, also it will be over
head of the maintainer to always check for the backward compatibility
of merged driver with the mpt2sas driver.
Regards,
Sreekanth
On Sun, Apr 5, 2015 at 9:39 PM, Christoph Hellwig <[email protected]> wrote:
> This seems to be missing the corresponding mpt2 updates. Nak to
> anything that gets these drivers further out of sync.
>
> Btw, I still need a second ACK for
> http://www.spinics.net/lists/linux-scsi/msg82027.html
> as well, so we can start getting rid of this duplication mess.
On Wed, Apr 08, 2015 at 11:13:04AM +0530, Sreekanth Reddy wrote:
> Hi Chris,
>
> There are no corresponding mpt2sas driver's patches, The last phase
> for mpt2sas drivers is Phase20 and this phase driver is already exits
> in the upstream kernel. Also mpt2sas driver is completely in maintains
> mode and there won't be any new features.
But we'll still need all the bugfixes for existing users.
So a big NAK from me for any mpt3 patches that aren't urgen bug fixes
before we finally got the two drivers merged.
Christoph,
We had internal discussion with our engineering and management on this
topic. We are committed to provide bug fixes ( Only bug fixes and no new
features) across both the SAS2 and SAS3 source trees. We prefer the SAS2
and SAS3 drivers to stay separate and the reason is; merging of the
drivers is a time consuming and error prone task and with SAS2 products at
the maintenance mode we are thinking it will be risky to do the merge for
now.
Going forward for our future products we will be providing a merged
driver (with common source separated out and having multiple kernel
modules compiled out of single source directory for each of our products)
to avoid maintenance overhead.
So please let us know whether the current patches can be ACKED if we
provide the applicable bug fixes to SAS2 or you see any other issues?.
Thanks
Sathya
-----Original Message-----
From: Christoph Hellwig [mailto:[email protected]]
Sent: Tuesday, April 21, 2015 6:14 AM
To: Sreekanth Reddy
Cc: Christoph Hellwig; [email protected]; Martin K. Petersen;
[email protected]; James E.J. Bottomley; Sathya Prakash; Kashyap
Desai; [email protected]; Tomas Henzl
Subject: Re: [PATCH 00/20] mpt3sas: driver update
On Wed, Apr 08, 2015 at 11:13:04AM +0530, Sreekanth Reddy wrote:
> Hi Chris,
>
> There are no corresponding mpt2sas driver's patches, The last phase
> for mpt2sas drivers is Phase20 and this phase driver is already exits
> in the upstream kernel. Also mpt2sas driver is completely in maintains
> mode and there won't be any new features.
But we'll still need all the bugfixes for existing users.
So a big NAK from me for any mpt3 patches that aren't urgen bug fixes
before we finally got the two drivers merged.