2020-04-30 11:58:22

by Markus Elfring

[permalink] [raw]
Subject: Re: [PATCH v2] drm/mcde: dsi: Fix return value check in mcde_dsi_bind()

> The of_drm_find_bridge() function returns NULL on error, it doesn't return
> error pointers so this check doesn't work.

How do you think about a wording variant like the following?

Change description:
An error pointer check was performed after a call of the
function “of_drm_find_bridge” despite of the detail
that failures are indicated for the bridge search
by null pointers instead.
Thus adjust a check for the failure predicate
and the corresponding exception handling.


Regards,
Markus