2006-03-03 18:01:04

by Adrian Bunk

Subject: [2.4 patch] Corrected faulty syntax in drivers/input/Config.in

From: "Stefan-W. Hahn" <[email protected]>

If statement in drivers/input/Config.in for "make xconfig" corrected.


Signed-off-by: Stefan-W. Hahn <[email protected]>
Signed-off-by: Adrian Bunk <[email protected]>

---

This patch was sent by Stefan-W. Hahn on:
- 26 Feb 2006

--- a/drivers/input/Config.in
+++ b/drivers/input/Config.in
@@ -8,7 +8,7 @@ comment 'Input core support'
tristate 'Input core support' CONFIG_INPUT
dep_tristate ' Keyboard support' CONFIG_INPUT_KEYBDEV $CONFIG_INPUT

-if [ "$CONFIG_INPUT_KEYBDEV" == "n" ]; then
+if [ "$CONFIG_INPUT_KEYBDEV" = "n" ]; then
bool ' Use dummy keyboard driver' CONFIG_DUMMY_KEYB $CONFIG_INPUT
fi

2006-03-03 20:26:36

by Nick Warne

Subject: Re: [2.4 patch] Corrected faulty syntax in drivers/input/Config.in

> If statement in drivers/input/Config.in for "make xconfig" corrected.
>
>
> Signed-off-by: Stefan-W. Hahn <[email protected]>
> Signed-off-by: Adrian Bunk <[email protected]>
>
> ---
>
> This patch was sent by Stefan-W. Hahn on:
> - 26 Feb 2006
>
> --- a/drivers/input/Config.in
> +++ b/drivers/input/Config.in
> @@ -8,7 +8,7 @@ comment 'Input core support'
> tristate 'Input core support' CONFIG_INPUT
> dep_tristate ' Keyboard support' CONFIG_INPUT_KEYBDEV $CONFIG_INPUT
>
> -if [ "$CONFIG_INPUT_KEYBDEV" == "n" ]; then
> +if [ "$CONFIG_INPUT_KEYBDEV" = "n" ]; then
> bool ' Use dummy keyboard driver' CONFIG_DUMMY_KEYB $CONFIG_INPUT
> fi

This was my patch, and after I saw that a bit later (Duh!), I did ask:

http://marc.theaimsgroup.com/?l=linux-kernel&m=112966037407189&w=2

But got no feedback, and it was accepted, so I presumed all was OK.

So it looks like breaks in xconfig, and not menuconfig (what I use).

Nick

2006-03-04 18:44:47

by Jan Engelhardt

Subject: Re: [2.4 patch] Corrected faulty syntax in drivers/input/Config.in

>> If statement in drivers/input/Config.in for "make xconfig" corrected.
>>
>> Signed-off-by: Stefan-W. Hahn <[email protected]>
>> Signed-off-by: Adrian Bunk <[email protected]>
>>
>> --- a/drivers/input/Config.in
>> +++ b/drivers/input/Config.in
>> @@ -8,7 +8,7 @@ comment 'Input core support'
>> tristate 'Input core support' CONFIG_INPUT
>> dep_tristate ' Keyboard support' CONFIG_INPUT_KEYBDEV $CONFIG_INPUT
>>
>> -if [ "$CONFIG_INPUT_KEYBDEV" == "n" ]; then
>> +if [ "$CONFIG_INPUT_KEYBDEV" = "n" ]; then
>> bool ' Use dummy keyboard driver' CONFIG_DUMMY_KEYB $CONFIG_INPUT
>> fi

If this is sh compatible code, then == is just as valid -- if xconfig
breaks then, then xconfig is broken, not the file.


Jan Engelhardt
--

2006-03-04 18:56:14

by Adrian Bunk

Subject: Re: [2.4 patch] Corrected faulty syntax in drivers/input/Config.in

On Sat, Mar 04, 2006 at 07:44:01PM +0100, Jan Engelhardt wrote:
> >> If statement in drivers/input/Config.in for "make xconfig" corrected.
> >>
> >> Signed-off-by: Stefan-W. Hahn <[email protected]>
> >> Signed-off-by: Adrian Bunk <[email protected]>
> >>
> >> --- a/drivers/input/Config.in
> >> +++ b/drivers/input/Config.in
> >> @@ -8,7 +8,7 @@ comment 'Input core support'
> >> tristate 'Input core support' CONFIG_INPUT
> >> dep_tristate ' Keyboard support' CONFIG_INPUT_KEYBDEV $CONFIG_INPUT
> >>
> >> -if [ "$CONFIG_INPUT_KEYBDEV" == "n" ]; then
> >> +if [ "$CONFIG_INPUT_KEYBDEV" = "n" ]; then
> >> bool ' Use dummy keyboard driver' CONFIG_DUMMY_KEYB $CONFIG_INPUT
> >> fi
>
> If this is sh compatible code, then == is just as valid -- if xconfig

It is not.

> breaks then, then xconfig is broken, not the file.

Please read at least the section "Introduction" of
Documentation/kbuild/config-language.txt in kernel 2.4
instead of falsely accusing xconfig of being broken.

> Jan Engelhardt

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed