2023-09-12 13:05:01

by Mathias Nyman

[permalink] [raw]
Subject: Re: [PATCH] usb: xhci: xhci-ring: Use sysdev for mapping bounce buffer

On 12.9.2023 2.41, Wesley Cheng wrote:
> As mentioned in:
> commit 474ed23a6257 ("xhci: align the last trb before link if it is
> easily splittable.")
>
> A bounce buffer is utilized for ensuring that transfers that span across
> ring segments are aligned to the EP's max packet size. However, the device
> that is used to map the DMA buffer to is currently using the XHCI HCD,
> which does not carry any DMA operations in certain configrations.
> Migration to using the sysdev entry was introduced for DWC3 based
> implementations where the IOMMU operations are present.
>
> Replace the reference to the controller device to sysdev instead. This
> allows the bounce buffer to be properly mapped to any implementations that
> have an IOMMU involved.
>
> cc: <[email protected]>
> Fixes: 4c39d4b949d3 ("usb: xhci: use bus->sysdev for DMA configuration")
> Signed-off-by: Wesley Cheng <[email protected]>
> ---

Thanks, adding to queue

-Mathias