2015-04-08 11:27:46

by Rupesh Tatiya

[permalink] [raw]
Subject: Re: [PATCH] usb: Enable LPM for USB 2.01+ full-speed devices

> On Wed, Mar 25, 2015 at 12:23:19PM +0530, [email protected] wrote:
>> From: Rupesh Tatiya <[email protected]>
>>
>> USB 2.01+ full-speed devices can have extended descriptor as well
>> and can support LPM.
>>
>> Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b
>
> We can't take patches with this in it, as it makes no sense in a kernel
> changelog :(
>
>

Sorry this is my first time (I read as much as I can before sending patch
but not enough I guess). Should I remove "From" line or rephrase commit
message?

Thanks,
Rupesh


2015-04-08 11:38:03

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] usb: Enable LPM for USB 2.01+ full-speed devices

On Wed, Apr 08, 2015 at 11:27:40AM -0000, [email protected] wrote:
> > On Wed, Mar 25, 2015 at 12:23:19PM +0530, [email protected] wrote:
> >> From: Rupesh Tatiya <[email protected]>
> >>
> >> USB 2.01+ full-speed devices can have extended descriptor as well
> >> and can support LPM.
> >>
> >> Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b
> >
> > We can't take patches with this in it, as it makes no sense in a kernel
> > changelog :(
> >
> >
>
> Sorry this is my first time (I read as much as I can before sending patch
> but not enough I guess). Should I remove "From" line or rephrase commit
> message?

>From line is fine.

2015-04-08 13:24:25

by Pramod Gurav

[permalink] [raw]
Subject: Re: [PATCH] usb: Enable LPM for USB 2.01+ full-speed devices

>> On Wed, Mar 25, 2015 at 12:23:19PM +0530, [email protected] wrote:
>>> From: Rupesh Tatiya <[email protected]>
>>>
>>> USB 2.01+ full-speed devices can have extended descriptor as well
>>> and can support LPM.
>>>
>>> Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b
>>
>> We can't take patches with this in it, as it makes no sense in a kernel
>> changelog :(
>>
>>
>
> Sorry this is my first time (I read as much as I can before sending patch
> but not enough I guess). Should I remove "From" line or rephrase commit
> message?

Rupesh, Just remove below line from commit message:

>>> Change-Id: Ic055d51c02651810d3eb7141bab20a090fe8453b

>
> Thanks,
> Rupesh
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
-
Pramod

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project



2015-04-14 11:07:35

by Rupesh Tatiya

[permalink] [raw]
Subject: [PATCH v2] usb: Enable LPM for USB 2.01+ full-speed devices

USB 2.01+ full-speed devices can have extended descriptor as well
and can support LPM.

Signed-off-by: Rupesh Tatiya <[email protected]>
---
drivers/usb/core/hub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 9ef2d2c..1ed7b5d 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -140,7 +140,7 @@ static int usb_device_supports_lpm(struct usb_device *udev)
/* USB 2.1 (and greater) devices indicate LPM support through
* their USB 2.0 Extended Capabilities BOS descriptor.
*/
- if (udev->speed == USB_SPEED_HIGH) {
+ if (udev->speed == USB_SPEED_HIGH || udev->speed == USB_SPEED_FULL) {
if (udev->bos->ext_cap &&
(USB_LPM_SUPPORT &
le32_to_cpu(udev->bos->ext_cap->bmAttributes)))
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project