2022-10-28 13:38:25

by Maarten Zanders

Subject: [PATCH 1/2] dt-bindings: leds-lp55xx: add ti,disable-charge-pump

Add a binding to disable the internal charge pump for lp55xx.

Signed-off-by: Maarten Zanders <[email protected]>
---
Documentation/devicetree/bindings/leds/leds-lp55xx.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
index 7ec676e53851..9eb8d1017402 100644
--- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
@@ -64,6 +64,11 @@ properties:
'#size-cells':
const: 0

+ ti,disable-charge-pump:
+ description: |
+ Disable the internal charge pump.
+ type: boolean
+
patternProperties:
"(^led@[0-9a-f]$|led)":
type: object
--
2.37.3

2022-10-28 22:39:29

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/2] dt-bindings: leds-lp55xx: add ti,disable-charge-pump

On 28/10/2022 09:34, Maarten Zanders wrote:
> Add a binding to disable the internal charge pump for lp55xx.
>
> Signed-off-by: Maarten Zanders <[email protected]>
> ---
> Documentation/devicetree/bindings/leds/leds-lp55xx.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
> index 7ec676e53851..9eb8d1017402 100644
> --- a/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-lp55xx.yaml
> @@ -64,6 +64,11 @@ properties:
> '#size-cells':
> const: 0
>
> + ti,disable-charge-pump:
> + description: |

Drop |

> + Disable the internal charge pump.

Does it mean that it is enabled by default?

Best regards,
Krzysztof

2022-10-29 08:07:12

by Maarten Zanders

Subject: Re: [PATCH 1/2] dt-bindings: leds-lp55xx: add ti,disable-charge-pump

On 10/29/22 00:07, Krzysztof Kozlowski wrote:
> Drop |
OK.
>> + Disable the internal charge pump.
> Does it mean that it is enabled by default?

The device default after reset is "off".
The current implementation sets it to "auto".
Other possible modes are "bypass" and "boost".

Should I change to an optional "ti,charge_pump_mode" as string and set
default to "auto"?

Thanks!

2022-11-02 17:31:36

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/2] dt-bindings: leds-lp55xx: add ti,disable-charge-pump

On 29/10/2022 03:48, Maarten Zanders wrote:
>
> On 10/29/22 00:07, Krzysztof Kozlowski wrote:
>> Drop |
> OK.
>>> + Disable the internal charge pump.
>> Does it mean that it is enabled by default?
>
> The device default after reset is "off".
> The current implementation sets it to "auto".
> Other possible modes are "bypass" and "boost".
>
> Should I change to an optional "ti,charge_pump_mode" as string and set
> default to "auto"?

enum makes more sense in that case. Just don't user underscores in
property names.

Best regards,
Krzysztof