2019-12-08 17:20:58

by Martin Blumenstingl

[permalink] [raw]
Subject: [PATCH v2 0/2] Meson VPU: fix CVBS output

The goal of this series is to fix the CVBS output with the Meson VPU
driver. Prior to this series kmscube reported:
failed to set mode: Invalid argument

Changes since v1 at [0]:
- add patch to remove duplicate code (to match patch #2 easier)
- use drm_mode_match without DRM_MODE_MATCH_ASPECT_RATIO as suggested
by Neil


[0] https://patchwork.kernel.org/patch/11268161/


Martin Blumenstingl (2):
drm: meson: venc: cvbs: deduplicate the meson_cvbs_mode lookup code
drm: meson: venc: cvbs: fix CVBS mode matching

drivers/gpu/drm/meson/meson_venc_cvbs.c | 48 ++++++++++++++-----------
1 file changed, 27 insertions(+), 21 deletions(-)

--
2.24.0


2019-12-09 07:24:42

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH v2 0/2] Meson VPU: fix CVBS output

Hi Martin !

On 08/12/2019 18:18, Martin Blumenstingl wrote:
> The goal of this series is to fix the CVBS output with the Meson VPU
> driver. Prior to this series kmscube reported:
> failed to set mode: Invalid argument
>
> Changes since v1 at [0]:
> - add patch to remove duplicate code (to match patch #2 easier)
> - use drm_mode_match without DRM_MODE_MATCH_ASPECT_RATIO as suggested
> by Neil
>
>
> [0] https://patchwork.kernel.org/patch/11268161/
>
>
> Martin Blumenstingl (2):
> drm: meson: venc: cvbs: deduplicate the meson_cvbs_mode lookup code
> drm: meson: venc: cvbs: fix CVBS mode matching
>
> drivers/gpu/drm/meson/meson_venc_cvbs.c | 48 ++++++++++++++-----------
> 1 file changed, 27 insertions(+), 21 deletions(-)
>

For both:
Acked-by: Neil Armstrong <[email protected]>

I'll squash them to permit an easier backporting to stable kernel !

Neil

2019-12-09 07:26:58

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH v2 0/2] Meson VPU: fix CVBS output

On 08/12/2019 18:18, Martin Blumenstingl wrote:
> The goal of this series is to fix the CVBS output with the Meson VPU
> driver. Prior to this series kmscube reported:
> failed to set mode: Invalid argument
>
> Changes since v1 at [0]:
> - add patch to remove duplicate code (to match patch #2 easier)
> - use drm_mode_match without DRM_MODE_MATCH_ASPECT_RATIO as suggested
> by Neil
>
>
> [0] https://patchwork.kernel.org/patch/11268161/
>
>
> Martin Blumenstingl (2):
> drm: meson: venc: cvbs: deduplicate the meson_cvbs_mode lookup code
> drm: meson: venc: cvbs: fix CVBS mode matching
>
> drivers/gpu/drm/meson/meson_venc_cvbs.c | 48 ++++++++++++++-----------
> 1 file changed, 27 insertions(+), 21 deletions(-)
>

Hmm seems you are not registered to the dri-devel ML, so I must wait for the ML moderator to accept your mails so they appear on https://patchwork.freedesktop.org/.

Could you register and disable emails reception from dri-devel ? I will be easier in the future.

Neil

2019-12-09 09:45:24

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH v2 0/2] Meson VPU: fix CVBS output

On 08/12/2019 18:18, Martin Blumenstingl wrote:
> The goal of this series is to fix the CVBS output with the Meson VPU
> driver. Prior to this series kmscube reported:
> failed to set mode: Invalid argument
>
> Changes since v1 at [0]:
> - add patch to remove duplicate code (to match patch #2 easier)
> - use drm_mode_match without DRM_MODE_MATCH_ASPECT_RATIO as suggested
> by Neil
>
>
> [0] https://patchwork.kernel.org/patch/11268161/
>
>
> Martin Blumenstingl (2):
> drm: meson: venc: cvbs: deduplicate the meson_cvbs_mode lookup code
> drm: meson: venc: cvbs: fix CVBS mode matching
>
> drivers/gpu/drm/meson/meson_venc_cvbs.c | 48 ++++++++++++++-----------
> 1 file changed, 27 insertions(+), 21 deletions(-)
>

Applied to drm-misc-fixes

Thanks !

Neil