2013-10-28 11:48:47

by Rashika Kheria

[permalink] [raw]
Subject: [PATCH v5 3/3] Staging: zram: Fix decrement of variable by calling bdput()

As suggested by Jerome Marchand "The code in reset_store get the block device
(bdget_disk()) but it does not put it (bdput()) when it's done using it.
The usage count is therefor incremented but never decremented."

Hence, this patch introduces a call to bdput() to decrement the variable after usage.

Signed-off-by: Rashika Kheria <[email protected]>
---
drivers/staging/zram/zram_drv.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c
index 9027975..98dac15 100644
--- a/drivers/staging/zram/zram_drv.c
+++ b/drivers/staging/zram/zram_drv.c
@@ -664,6 +664,7 @@ static ssize_t reset_store(struct device *dev,

/* Make sure all pending I/O is finished */
fsync_bdev(bdev);
+ bdput(bdev);

zram_reset_device(zram, true);
return len;
--
1.7.9.5