2020-01-21 20:17:07

by Justin Swartz

Subject: [PATCH v2 1/2] ARM: dts: rockchip: add rga node for rk322x

Add a node to define the presence of RGA, a 2D raster graphic
acceleration unit.

Signed-off-by: Justin Swartz <[email protected]>
---
arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
index 340ed6ccb..efa733207 100644
--- a/arch/arm/boot/dts/rk322x.dtsi
+++ b/arch/arm/boot/dts/rk322x.dtsi
@@ -566,6 +566,17 @@
status = "disabled";
};

+ rga: rga@20060000 {
+ compatible = "rockchip,rk3228-rga", "rockchip,rk3288-rga";
+ reg = <0x20060000 0x1000>;
+ interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA>;
+ clock-names = "aclk", "hclk", "sclk";
+ resets = <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru SRST_RGA_H>;
+ reset-names = "core", "axi", "ahb";
+ status = "disabled";
+ };
+
vpu_mmu: iommu@20020800 {
compatible = "rockchip,iommu";
reg = <0x20020800 0x100>;
--
2.11.0

2020-01-21 21:36:03

by Johan Jonker

Subject: Re: [PATCH v2 1/2] ARM: dts: rockchip: add rga node for rk322x

Hi Justin,

rga is now inserted above vpu_mmu.
Please check the address.

rga: rga@20060000 {
vpu_mmu: iommu@20020800 {

Should go between vop_mmu and iep_mmu.

vop_mmu: iommu@20053f00 {
rga: rga@20060000 {
iep_mmu: iommu@20070800 {

> Add a node to define the presence of RGA, a 2D raster graphic
> acceleration unit.
>
> Signed-off-by: Justin Swartz <[email protected]>
> ---
> arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi
> index 340ed6ccb..efa733207 100644
> --- a/arch/arm/boot/dts/rk322x.dtsi
> +++ b/arch/arm/boot/dts/rk322x.dtsi
> @@ -566,6 +566,17 @@
> status = "disabled";
> };
>
> + rga: rga@20060000 {
> + compatible = "rockchip,rk3228-rga", "rockchip,rk3288-rga";
> + reg = <0x20060000 0x1000>;
> + interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA>;
> + clock-names = "aclk", "hclk", "sclk";
> + resets = <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru SRST_RGA_H>;
> + reset-names = "core", "axi", "ahb";
> + status = "disabled";
> + };
> +
> vpu_mmu: iommu@20020800 {
> compatible = "rockchip,iommu";
> reg = <0x20020800 0x100>;
> --
> 2.11.0

2020-01-21 21:46:59

by Justin Swartz

Subject: Re: [PATCH v2 1/2] ARM: dts: rockchip: add rga node for rk322x

Hi Johan,

On 2020-01-21 23:34, Johan Jonker wrote:

> Hi Justin,
>
> rga is now inserted above vpu_mmu.
> Please check the address.
>
> rga: rga@20060000 {
> vpu_mmu: iommu@20020800 {
>
> Should go between vop_mmu and iep_mmu.
>
> vop_mmu: iommu@20053f00 {
> rga: rga@20060000 {
> iep_mmu: iommu@20070800 {

Thanks!

>> Add a node to define the presence of RGA, a 2D raster graphic
>> acceleration unit.
>>
>> Signed-off-by: Justin Swartz <[email protected]>
>> ---
>> arch/arm/boot/dts/rk322x.dtsi | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk322x.dtsi
>> b/arch/arm/boot/dts/rk322x.dtsi
>> index 340ed6ccb..efa733207 100644
>> --- a/arch/arm/boot/dts/rk322x.dtsi
>> +++ b/arch/arm/boot/dts/rk322x.dtsi
>> @@ -566,6 +566,17 @@
>> status = "disabled";
>> };
>>
>> + rga: rga@20060000 {
>> + compatible = "rockchip,rk3228-rga", "rockchip,rk3288-rga";
>> + reg = <0x20060000 0x1000>;
>> + interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
>> + clocks = <&cru ACLK_RGA>, <&cru HCLK_RGA>, <&cru SCLK_RGA>;
>> + clock-names = "aclk", "hclk", "sclk";
>> + resets = <&cru SRST_RGA>, <&cru SRST_RGA_A>, <&cru
>> SRST_RGA_H>;
>> + reset-names = "core", "axi", "ahb";
>> + status = "disabled";
>> + };
>> +
>> vpu_mmu: iommu@20020800 {
>> compatible = "rockchip,iommu";
>> reg = <0x20020800 0x100>;
>> --
>> 2.11.0