2022-04-12 20:06:15

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH v3] usb: usbip: fix a refcount leak in stub_probe()

On 4/11/22 8:02 PM, Hangyu Hua wrote:
> usb_get_dev() is called in stub_device_alloc(). When stub_probe() fails
> after that, usb_put_dev() needs to be called to release the reference.
>
> Fix this by moving usb_put_dev() to sdev_free error path handling.
>
> Find this by code review.
>
> Fixes: 3ff67445750a ("usbip: fix error handling in stub_probe()")
> Signed-off-by: Hangyu Hua <[email protected]>
> Reviewed-by: Shuah Khan <[email protected]>
> ---
>
> v2: add more description of this patch.
>
> v3: add how to find the problem.
>

Thank you.

Greg, Please pick this patch up.

thanks,
-- Shuah