2023-07-18 06:05:31

by shijie001

Subject: [PATCH] net: Fix errors in af_llc.c

The following checkpatch errors are removed:
ERROR: "foo* bar" should be "foo *bar"
ERROR: space required before the open parenthesis '('

Signed-off-by: Jie Shi <[email protected]>
---
net/llc/af_llc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/llc/af_llc.c b/net/llc/af_llc.c
index 9ffbc667be6c..f0891088e7be 100644
--- a/net/llc/af_llc.c
+++ b/net/llc/af_llc.c
@@ -124,9 +124,9 @@ static inline u8 llc_ui_header_len(struct sock *sk,
struct sockaddr_llc *addr)
*
* This function always consumes a reference to the skb.
*/
-static int llc_ui_send_data(struct sock* sk, struct sk_buff *skb, int
noblock)
+static int llc_ui_send_data(struct sock *sk, struct sk_buff *skb, int
noblock)
{
- struct llc_sock* llc = llc_sk(sk);
+ struct llc_sock *llc = llc_sk(sk);

if (unlikely(llc_data_accept_state(llc->state) ||
llc->remote_busy_flag ||
@@ -1030,7 +1030,7 @@ static int llc_ui_getname(struct socket *sock,
struct sockaddr *uaddr,
rc = -ENOTCONN;
if (sk->sk_state != TCP_ESTABLISHED)
goto out;
- if(llc->dev)
+ if (llc->dev)
sllc.sllc_arphrd = llc->dev->type;
sllc.sllc_sap = llc->daddr.lsap;
memcpy(&sllc.sllc_mac, &llc->daddr.mac, IFHWADDRLEN);

2023-07-18 20:43:18

by Jakub Kicinski

Subject: Re: [PATCH] net: Fix errors in af_llc.c

On Tue, 18 Jul 2023 13:48:33 +0800 [email protected] wrote:
> The following checkpatch errors are removed:
> ERROR: "foo* bar" should be "foo *bar"
> ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Jie Shi <[email protected]>

Please don't send checkpatch fixes to networking.
Your patches are whitespace damaged.

We had an influx of similar changes recently.
Are you part of some organized effort?
--
pw-bot: reject