2017-12-15 10:20:43

by Vladimir Murzin

Subject: [PATCH] phy: rcar-gen3-usb2: add dependency on USB

Following error showed up:

drivers/phy/renesas/phy-rcar-gen3-usb2.o: In function `rcar_gen3_phy_usb2_probe':
/work/tools/linux/drivers/phy/renesas/phy-rcar-gen3-usb2.c:444: undefined reference to `of_usb_get_dr_mode_by_phy'
Makefile:993: recipe for target 'vmlinux' failed
make: *** [vmlinux] Error 1

with CONFIG_USB_SUPPORT=n

Add dependency on USB_SUPPORT and select USB_COMMON to make sure that
of_usb_get_dr_mode_by_phy() is available.

Signed-off-by: Vladimir Murzin <[email protected]>
---
drivers/phy/renesas/Kconfig | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/phy/renesas/Kconfig b/drivers/phy/renesas/Kconfig
index cb09245..c845fac 100644
--- a/drivers/phy/renesas/Kconfig
+++ b/drivers/phy/renesas/Kconfig
@@ -12,7 +12,9 @@ config PHY_RCAR_GEN3_USB2
tristate "Renesas R-Car generation 3 USB 2.0 PHY driver"
depends on ARCH_RENESAS
depends on EXTCON
+ depends on USB_SUPPORT
select GENERIC_PHY
+ select USB_COMMON
help
Support for USB 2.0 PHY found on Renesas R-Car generation 3 SoCs.

--
1.9.1

2017-12-15 10:27:17

by Yoshihiro Shimoda

Subject: RE: [PATCH] phy: rcar-gen3-usb2: add dependency on USB

Hi,

> -----Original Message-----
> From: Vladimir Murzin, Sent: Friday, December 15, 2017 7:20 PM
>
> Following error showed up:
>
> drivers/phy/renesas/phy-rcar-gen3-usb2.o: In function `rcar_gen3_phy_usb2_probe':
> /work/tools/linux/drivers/phy/renesas/phy-rcar-gen3-usb2.c:444: undefined reference to `of_usb_get_dr_mode_by_phy'
> Makefile:993: recipe for target 'vmlinux' failed
> make: *** [vmlinux] Error 1
>
> with CONFIG_USB_SUPPORT=n
>
> Add dependency on USB_SUPPORT and select USB_COMMON to make sure that
> of_usb_get_dr_mode_by_phy() is available.
>
> Signed-off-by: Vladimir Murzin <[email protected]>

Thank you for the patch! However, Arnd already sent such a patch before.

https://lkml.org/lkml/2017/11/2/373

The latest Linux-phy.git doesn't apply it yet though...

Best regards,
Yoshihiro Shimoda

2017-12-15 10:29:08

by Vladimir Murzin

Subject: Re: [PATCH] phy: rcar-gen3-usb2: add dependency on USB

Hi,

On 15/12/17 10:27, Yoshihiro Shimoda wrote:
> Hi,
>
>> -----Original Message-----
>> From: Vladimir Murzin, Sent: Friday, December 15, 2017 7:20 PM
>>
>> Following error showed up:
>>
>> drivers/phy/renesas/phy-rcar-gen3-usb2.o: In function `rcar_gen3_phy_usb2_probe':
>> /work/tools/linux/drivers/phy/renesas/phy-rcar-gen3-usb2.c:444: undefined reference to `of_usb_get_dr_mode_by_phy'
>> Makefile:993: recipe for target 'vmlinux' failed
>> make: *** [vmlinux] Error 1
>>
>> with CONFIG_USB_SUPPORT=n
>>
>> Add dependency on USB_SUPPORT and select USB_COMMON to make sure that
>> of_usb_get_dr_mode_by_phy() is available.
>>
>> Signed-off-by: Vladimir Murzin <[email protected]>
>
> Thank you for the patch! However, Arnd already sent such a patch before.
>
> https://lkml.org/lkml/2017/11/2/373
>
> The latest Linux-phy.git doesn't apply it yet though...

Ahh, good!

Sorry for the noise!

Vladimir

>
> Best regards,
> Yoshihiro Shimoda
>