2014-02-08 16:24:51

by Rashika Kheria

Subject: [PATCH 1/2] block: Mark function as static in blk-lib.c

Mark function as static in blk-lib.c because it is not used outside this
file.

This eliminates the following warning in blk-lib.c:
block/blk-lib.c:221:5: warning: no previous prototype for ‘__blkdev_issue_zeroout’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <[email protected]>
---
block/blk-lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/blk-lib.c b/block/blk-lib.c
index 2da76c9..332e7a9 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -218,7 +218,7 @@ EXPORT_SYMBOL(blkdev_issue_write_same);
* Generate and issue number of bios with zerofiled pages.
*/

-int __blkdev_issue_zeroout(struct block_device *bdev, sector_t sector,
+static int __blkdev_issue_zeroout(struct block_device *bdev, sector_t sector,
sector_t nr_sects, gfp_t gfp_mask)
{
int ret;
--
1.7.9.5

2014-02-08 16:26:27

by Rashika Kheria

Subject: [PATCH 2/2] block: Mark function as static in blk-throttle.c

Mark functions as static in blk-throttle.c because it is not used
outside this file.

This eliminates the following warning in blk-throttle.c:
block/blk-throttle.c:1261:6: warning: no previous prototype for ‘blk_throtl_dispatch_work_fn’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <[email protected]>
---
block/blk-throttle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/blk-throttle.c b/block/blk-throttle.c
index 1474c3a..0face33 100644
--- a/block/blk-throttle.c
+++ b/block/blk-throttle.c
@@ -1258,7 +1258,7 @@ out_unlock:
* of throtl_data->service_queue. Those bio's are ready and issued by this
* function.
*/
-void blk_throtl_dispatch_work_fn(struct work_struct *work)
+static void blk_throtl_dispatch_work_fn(struct work_struct *work)
{
struct throtl_data *td = container_of(work, struct throtl_data,
dispatch_work);
--
1.7.9.5

2014-02-08 18:37:51

by Josh Triplett

Subject: Re: [PATCH 1/2] block: Mark function as static in blk-lib.c

On Sat, Feb 08, 2014 at 09:54:44PM +0530, Rashika Kheria wrote:
> Mark function as static in blk-lib.c because it is not used outside this
> file.
>
> This eliminates the following warning in blk-lib.c:
> block/blk-lib.c:221:5: warning: no previous prototype for ‘__blkdev_issue_zeroout’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <[email protected]>

Reviewed-by: Josh Triplett <[email protected]>

> block/blk-lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-lib.c b/block/blk-lib.c
> index 2da76c9..332e7a9 100644
> --- a/block/blk-lib.c
> +++ b/block/blk-lib.c
> @@ -218,7 +218,7 @@ EXPORT_SYMBOL(blkdev_issue_write_same);
> * Generate and issue number of bios with zerofiled pages.
> */
>
> -int __blkdev_issue_zeroout(struct block_device *bdev, sector_t sector,
> +static int __blkdev_issue_zeroout(struct block_device *bdev, sector_t sector,
> sector_t nr_sects, gfp_t gfp_mask)
> {
> int ret;
> --
> 1.7.9.5
>

2014-02-08 18:38:11

by Josh Triplett

Subject: Re: [PATCH 2/2] block: Mark function as static in blk-throttle.c

On Sat, Feb 08, 2014 at 09:56:21PM +0530, Rashika Kheria wrote:
> Mark functions as static in blk-throttle.c because it is not used
> outside this file.
>
> This eliminates the following warning in blk-throttle.c:
> block/blk-throttle.c:1261:6: warning: no previous prototype for ‘blk_throtl_dispatch_work_fn’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <[email protected]>

Reviewed-by: Josh Triplett <[email protected]>

> block/blk-throttle.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/blk-throttle.c b/block/blk-throttle.c
> index 1474c3a..0face33 100644
> --- a/block/blk-throttle.c
> +++ b/block/blk-throttle.c
> @@ -1258,7 +1258,7 @@ out_unlock:
> * of throtl_data->service_queue. Those bio's are ready and issued by this
> * function.
> */
> -void blk_throtl_dispatch_work_fn(struct work_struct *work)
> +static void blk_throtl_dispatch_work_fn(struct work_struct *work)
> {
> struct throtl_data *td = container_of(work, struct throtl_data,
> dispatch_work);
> --
> 1.7.9.5
>