2020-03-26 00:00:06

by Leo Li

[permalink] [raw]
Subject: [linux-next PATCH] ata: sata_fsl: fix a compile error

drivers/ata/sata_fsl.c: In function 'sata_fsl_init_controller':
drivers/ata/sata_fsl.c:1365:15: error: 'ap' undeclared (first use in this function)
ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
^

Fixes: b3f06231 ("sata_fsl: move DPRINTK to ata debugging")

Cc: Hannes Reinecke <[email protected]>
Signed-off-by: Li Yang <[email protected]>
---
drivers/ata/sata_fsl.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c
index 45c15c4e9f8a..c43a97d63e6c 100644
--- a/drivers/ata/sata_fsl.c
+++ b/drivers/ata/sata_fsl.c
@@ -1340,6 +1340,7 @@ static int sata_fsl_init_controller(struct ata_host *host)
{
struct sata_fsl_host_priv *host_priv = host->private_data;
void __iomem *hcr_base = host_priv->hcr_base;
+ struct ata_port *ap = host->ports[0];
u32 temp;

/*
--
2.17.1


2020-03-26 09:06:52

by Sergei Shtylyov

[permalink] [raw]
Subject: Re: [linux-next PATCH] ata: sata_fsl: fix a compile error

Hello!

On 26.03.2020 2:59, Li Yang wrote:

> drivers/ata/sata_fsl.c: In function 'sata_fsl_init_controller':
> drivers/ata/sata_fsl.c:1365:15: error: 'ap' undeclared (first use in this function)
> ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
> ^

Another fix has been posted yesterday.

> Fixes: b3f06231 ("sata_fsl: move DPRINTK to ata debugging")

12 digits SHA1 is needed here.

> Cc: Hannes Reinecke <[email protected]>
> Signed-off-by: Li Yang <[email protected]>
[...]

MBR, Sergei

2020-03-26 15:18:05

by Jens Axboe

[permalink] [raw]
Subject: Re: [linux-next PATCH] ata: sata_fsl: fix a compile error

On 3/26/20 3:06 AM, Sergei Shtylyov wrote:
> Hello!
>
> On 26.03.2020 2:59, Li Yang wrote:
>
>> drivers/ata/sata_fsl.c: In function 'sata_fsl_init_controller':
>> drivers/ata/sata_fsl.c:1365:15: error: 'ap' undeclared (first use in this function)
>> ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
> > ^
>
> Another fix has been posted yesterday.

I also dropped the series yesterday, so we don't need any of these
patches anymore.

--
Jens Axboe