2024-05-24 03:55:01

by Mohammad Rafi Shaik

[permalink] [raw]
Subject: [PATCH v2 0/2] Add support for QCM6490 and QCS6490

This patchset adds support for sound card on Qualcomm QCM6490 IDP and
QCS6490 RB3Gen2 boards.

Changes since v1:
- Use existing sc8280xp machine driver instead of separate driver.
- Modify qcs6490 compatible name as qcs6490-rb3gen2.

Mohammad Rafi Shaik (2):
ASoC: dt-bindings: qcom,sm8250: Add QCM6490 snd QCS6490 sound card
ASoC: qcom: sc8280xp: Add support for QCM6490 and QCS6490

Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 2 ++
sound/soc/qcom/sc8280xp.c | 2 ++
2 files changed, 4 insertions(+)

--
2.25.1



2024-05-24 03:55:09

by Mohammad Rafi Shaik

[permalink] [raw]
Subject: [PATCH v2 1/2] ASoC: dt-bindings: qcom,sm8250: Add QCM6490 snd QCS6490 sound card

Document the bindings for the Qualcomm QCM6490 IDP and QCS6490 RB3Gen2
soc platforms sound card.

The bindings are the same as for other newer Qualcomm ADSP sound cards,
thus keep them in existing qcom,sm8250.yaml file, even though Linux driver
is separate.

Signed-off-by: Mohammad Rafi Shaik <[email protected]>
---
Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
index 2ab6871e89e5..ff1a27f26bc2 100644
--- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
+++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml
@@ -29,6 +29,8 @@ properties:
- enum:
- qcom,apq8016-sbc-sndcard
- qcom,msm8916-qdsp6-sndcard
+ - qcom,qcm6490-sndcard
+ - qcom,qcs6490-rb3gen2-sndcard
- qcom,qrb5165-rb5-sndcard
- qcom,sc7180-qdsp6-sndcard
- qcom,sc8280xp-sndcard
--
2.25.1


2024-05-24 03:55:33

by Mohammad Rafi Shaik

[permalink] [raw]
Subject: [PATCH v2 2/2] ASoC: qcom: sc8280xp: Add support for QCM6490 and QCS6490

Add compatibles for sound card on Qualcomm QCM6490 IDP and
QCS6490 RB3Gen2 boards.

Signed-off-by: Mohammad Rafi Shaik <[email protected]>
---
sound/soc/qcom/sc8280xp.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c
index b7fd503a1666..09c949e01479 100644
--- a/sound/soc/qcom/sc8280xp.c
+++ b/sound/soc/qcom/sc8280xp.c
@@ -169,6 +169,8 @@ static int sc8280xp_platform_probe(struct platform_device *pdev)
}

static const struct of_device_id snd_sc8280xp_dt_match[] = {
+ {.compatible = "qcom,qcm6490-sndcard", "qcm6490"},
+ {.compatible = "qcom,qcs6490-rb3gen2-sndcard", "qcs6490"},
{.compatible = "qcom,sc8280xp-sndcard", "sc8280xp"},
{.compatible = "qcom,sm8450-sndcard", "sm8450"},
{.compatible = "qcom,sm8550-sndcard", "sm8550"},
--
2.25.1


2024-05-24 04:06:46

by Mohammad Rafi Shaik

[permalink] [raw]
Subject: Re: [PATCH v2 0/2] Add support for QCM6490 and QCS6490

On 5/24/2024 9:23 AM, Mohammad Rafi Shaik wrote:
> This patchset adds support for sound card on Qualcomm QCM6490 IDP and
> QCS6490 RB3Gen2 boards.

Please ignore this abounded patch series. No need for review.

Thanks,
Rafi.
>
> Changes since v1:
> - Use existing sc8280xp machine driver instead of separate driver.
> - Modify qcs6490 compatible name as qcs6490-rb3gen2.
>
> Mohammad Rafi Shaik (2):
> ASoC: dt-bindings: qcom,sm8250: Add QCM6490 snd QCS6490 sound card
> ASoC: qcom: sc8280xp: Add support for QCM6490 and QCS6490
>
> Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 2 ++
> sound/soc/qcom/sc8280xp.c | 2 ++
> 2 files changed, 4 insertions(+)
>


2024-05-24 09:20:43

by Dmitry Baryshkov

[permalink] [raw]
Subject: Re: [PATCH v2 0/2] Add support for QCM6490 and QCS6490

On Fri, 24 May 2024 at 07:06, Mohammad Rafi Shaik <[email protected]> wrote:
>
> On 5/24/2024 9:23 AM, Mohammad Rafi Shaik wrote:
> > This patchset adds support for sound card on Qualcomm QCM6490 IDP and
> > QCS6490 RB3Gen2 boards.
>
> Please ignore this abounded patch series. No need for review.

In future please use a logical prefix for the cover letter too. This
helps other developers to understand whether they are interested or
not.

>
> Thanks,
> Rafi.
> >
> > Changes since v1:
> > - Use existing sc8280xp machine driver instead of separate driver.
> > - Modify qcs6490 compatible name as qcs6490-rb3gen2.
> >
> > Mohammad Rafi Shaik (2):
> > ASoC: dt-bindings: qcom,sm8250: Add QCM6490 snd QCS6490 sound card
> > ASoC: qcom: sc8280xp: Add support for QCM6490 and QCS6490
> >
> > Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 2 ++
> > sound/soc/qcom/sc8280xp.c | 2 ++
> > 2 files changed, 4 insertions(+)
> >
>
>


--
With best wishes
Dmitry

2024-05-25 17:03:19

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] ASoC: dt-bindings: qcom,sm8250: Add QCM6490 snd QCS6490 sound card

On 24/05/2024 05:53, Mohammad Rafi Shaik wrote:
> Document the bindings for the Qualcomm QCM6490 IDP and QCS6490 RB3Gen2
> soc platforms sound card.
>
> The bindings are the same as for other newer Qualcomm ADSP sound cards,
> thus keep them in existing qcom,sm8250.yaml file, even though Linux driver
> is separate.
>

Acked-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2024-05-27 09:50:59

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v2 1/2] ASoC: dt-bindings: qcom,sm8250: Add QCM6490 snd QCS6490 sound card

On Fri, May 24, 2024 at 09:23:49AM +0530, Mohammad Rafi Shaik wrote:
> Document the bindings for the Qualcomm QCM6490 IDP and QCS6490 RB3Gen2
> soc platforms sound card.

This doesn't apply against current code, please check and resend.


Attachments:
(No filename) (242.00 B)
signature.asc (499.00 B)
Download all attachments