2023-07-19 20:16:14

by Naresh Solanki

[permalink] [raw]
Subject: [PATCH v3 1/3] peci: cpu: Add Intel Sapphire Rapids support

Add support for detection of Intel Sapphire Rapids processor based on
CPU family & model.

Sapphire Rapids Xeon processors with the family set to 6 and the
model set to INTEL_FAM6_SAPPHIRERAPIDS_X. The data field for this entry
is "spr".

Tested the patch series with AST2600 BMC with 4S Intel Sapphire Rapids
processors & verified by reading cpu & dimm temperature.

Signed-off-by: Patrick Rudolph <[email protected]>
Signed-off-by: Naresh Solanki <[email protected]>
---
Changes in V3:
- Move spr entry at end of struct peci_cpu_device_ids
- Mention test with the patch.
Changes in V2:
- Refactored from previous patchset as seperate patch based on subsystem.
---
drivers/peci/cpu.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/peci/cpu.c b/drivers/peci/cpu.c
index de4a7b3e5966..bd990acd92b8 100644
--- a/drivers/peci/cpu.c
+++ b/drivers/peci/cpu.c
@@ -323,6 +323,11 @@ static const struct peci_device_id peci_cpu_device_ids[] = {
.model = INTEL_FAM6_ICELAKE_D,
.data = "icxd",
},
+ { /* Sapphire Rapids Xeon */
+ .family = 6,
+ .model = INTEL_FAM6_SAPPHIRERAPIDS_X,
+ .data = "spr",
+ },
{ }
};
MODULE_DEVICE_TABLE(peci, peci_cpu_device_ids);

base-commit: 4dbbaf8fbdbd13adc80731b2452257857e4c2d8b
--
2.41.0



2023-07-19 20:17:38

by Winiarska, Iwona

[permalink] [raw]
Subject: Re: [PATCH v3 1/3] peci: cpu: Add Intel Sapphire Rapids support

On Wed, 2023-07-19 at 20:41 +0200, Naresh Solanki wrote:
> Add support for detection of Intel Sapphire Rapids processor based on
> CPU family & model.
>
> Sapphire Rapids Xeon processors with the family set to 6 and the
> model set to INTEL_FAM6_SAPPHIRERAPIDS_X. The data field for this entry
> is "spr".
>
> Tested the patch series with AST2600 BMC with 4S Intel Sapphire Rapids
> processors & verified by reading cpu & dimm temperature.
>
> Signed-off-by: Patrick Rudolph <[email protected]>
> Signed-off-by: Naresh Solanki <[email protected]>

Reviewed-by: Iwona Winiarska <[email protected]>

Thanks
-Iwona

> ---
> Changes in V3:
> - Move spr entry at end of struct peci_cpu_device_ids
> - Mention test with the patch.
> Changes in V2:
> - Refactored from previous patchset as seperate patch based on subsystem.
> ---
>  drivers/peci/cpu.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/peci/cpu.c b/drivers/peci/cpu.c
> index de4a7b3e5966..bd990acd92b8 100644
> --- a/drivers/peci/cpu.c
> +++ b/drivers/peci/cpu.c
> @@ -323,6 +323,11 @@ static const struct peci_device_id peci_cpu_device_ids[]
> = {
>                 .model  = INTEL_FAM6_ICELAKE_D,
>                 .data   = "icxd",
>         },
> +       { /* Sapphire Rapids Xeon */
> +               .family = 6,
> +               .model  = INTEL_FAM6_SAPPHIRERAPIDS_X,
> +               .data   = "spr",
> +       },
>         { }
>  };
>  MODULE_DEVICE_TABLE(peci, peci_cpu_device_ids);
>
> base-commit: 4dbbaf8fbdbd13adc80731b2452257857e4c2d8b