2021-01-13 03:39:32

by Bhaskar Chowdhury

Subject: [PATCH V4] arch: kernel: cpu: x86/resctrl: Takes a letter away and append a colon to match below struct member

s/kernlfs/kernfs/
s/@mon_data_kn/@mon_data_kn:/

Signed-off-by: Bhaskar Chowdhury <[email protected]>
---
Changes from V3: Fix the subject line typo stuc to struct and mention cpu architecture
arch/x86/kernel/cpu/resctrl/internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
index ee71c47844cb..ef9e2c0809b8 100644
--- a/arch/x86/kernel/cpu/resctrl/internal.h
+++ b/arch/x86/kernel/cpu/resctrl/internal.h
@@ -142,7 +142,7 @@ enum rdtgrp_mode {

/**
* struct mongroup - store mon group's data in resctrl fs.
- * @mon_data_kn kernlfs node for the mon_data directory
+ * @mon_data_kn: kernfs node for the mon_data directory
* @parent: parent rdtgrp
* @crdtgrp_list: child rdtgroup node list
* @rmid: rmid for this rdtgroup
--
2.20.1

2021-01-13 17:13:25

by Reinette Chatre

Subject: Re: [PATCH V4] arch: kernel: cpu: x86/resctrl: Takes a letter away and append a colon to match below struct member

Hi Bhaskar,

The prefix in the subject line should be "x86/resctrl:" only. The
subject line could be (also taking liberty to shorten it here):
x86/resctrl: Fix typo and append a colon to match struct member

I would like to repeat my suggestion made in response to your previous
version, especially if you are planning cleanup in many areas of the
kernel: Use "git log" to take a look at the custom of patches in the
area you are contributing to. While the kernel may appear to be a single
code base there can be different customs in the various subsystems.

On 1/12/2021 6:03 PM, Bhaskar Chowdhury wrote:
> s/kernlfs/kernfs/
> s/@mon_data_kn/@mon_data_kn:/
>
> Signed-off-by: Bhaskar Chowdhury <[email protected]>
> ---
> Changes from V3: Fix the subject line typo stuc to struct and mention cpu architecture
> arch/x86/kernel/cpu/resctrl/internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index ee71c47844cb..ef9e2c0809b8 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -142,7 +142,7 @@ enum rdtgrp_mode {
>
> /**
> * struct mongroup - store mon group's data in resctrl fs.
> - * @mon_data_kn kernlfs node for the mon_data directory
> + * @mon_data_kn: kernfs node for the mon_data directory
> * @parent: parent rdtgrp
> * @crdtgrp_list: child rdtgroup node list
> * @rmid: rmid for this rdtgroup
> --
> 2.20.1
>

Reinette

2021-01-13 17:45:44

by Fenghua Yu

Subject: Re: [PATCH V4] arch: kernel: cpu: x86/resctrl: Takes a letter away and append a colon to match below struct member

On Wed, Jan 13, 2021 at 07:33:33AM +0530, Bhaskar Chowdhury wrote:
> s/kernlfs/kernfs/
> s/@mon_data_kn/@mon_data_kn:/

May change the message to describe the problems like:

Fix typo "kernlfs" and add missing ":" to match with other comments.

>
> Signed-off-by: Bhaskar Chowdhury <[email protected]>
> ---
> Changes from V3: Fix the subject line typo stuc to struct and mention cpu architecture
>

Please read Documentation/process/submitting-patches.rst.
It talks about the subject, description of problem, changelog, etc
for submitting a patch.

Thanks.

-Fenghua