2022-02-16 06:38:34

by Helge Deller

Subject: Re: [PATCH 22/23] video: omapfb: dss: Make use of the helper component_compare_dev

On 2/14/22 07:08, Yong Wu wrote:
> Use the common compare helper from component.
>
> Cc: Helge Deller <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Yong Wu <[email protected]>

Applied to the fbdev for-next branch.

Thanks!
Helge

> drivers/video/fbdev/omap2/omapfb/dss/dss.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss.c b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> index a6b1c1598040..45b9d3cf3860 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> @@ -1193,12 +1193,6 @@ static const struct component_master_ops dss_component_ops = {
> .unbind = dss_unbind,
> };
>
> -static int dss_component_compare(struct device *dev, void *data)
> -{
> - struct device *child = data;
> - return dev == child;
> -}
> -
> static int dss_add_child_component(struct device *dev, void *data)
> {
> struct component_match **match = data;
> @@ -1212,7 +1206,7 @@ static int dss_add_child_component(struct device *dev, void *data)
> if (strstr(dev_name(dev), "rfbi"))
> return 0;
>
> - component_match_add(dev->parent, match, dss_component_compare, dev);
> + component_match_add(dev->parent, match, component_compare_dev, dev);
>
> return 0;
> }
>

2022-02-25 18:04:33

by Greg Kroah-Hartman

Subject: Re: [PATCH 22/23] video: omapfb: dss: Make use of the helper component_compare_dev

On Tue, Feb 15, 2022 at 09:46:24PM +0100, Helge Deller wrote:
> On 2/14/22 07:08, Yong Wu wrote:
> > Use the common compare helper from component.
> >
> > Cc: Helge Deller <[email protected]>
> > Cc: [email protected]
> > Cc: [email protected]
> > Signed-off-by: Yong Wu <[email protected]>
>
> Applied to the fbdev for-next branch.

That will break the build, it needs patch 1/23 to build properly :(