2020-07-22 07:55:12

by Chunfeng Yun

Subject: [PATCH 4/7] usb: dwc3: convert to devm_platform_ioremap_resource_byname

Use devm_platform_ioremap_resource_byname() to simplify code

Cc: Patrice Chotard <[email protected]>
Signed-off-by: Chunfeng Yun <[email protected]>
---
drivers/usb/dwc3/dwc3-st.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
index c682420..e733be8 100644
--- a/drivers/usb/dwc3/dwc3-st.c
+++ b/drivers/usb/dwc3/dwc3-st.c
@@ -206,8 +206,8 @@ static int st_dwc3_probe(struct platform_device *pdev)
if (!dwc3_data)
return -ENOMEM;

- res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "reg-glue");
- dwc3_data->glue_base = devm_ioremap_resource(dev, res);
+ dwc3_data->glue_base =
+ devm_platform_ioremap_resource_byname(pdev, "reg-glue");
if (IS_ERR(dwc3_data->glue_base))
return PTR_ERR(dwc3_data->glue_base);

--
1.9.1

2020-07-27 12:59:00

by Patrice CHOTARD

Subject: Re: [PATCH 4/7] usb: dwc3: convert to devm_platform_ioremap_resource_byname

Hi Chunfeng

On 7/22/20 9:51 AM, Chunfeng Yun wrote:
> Use devm_platform_ioremap_resource_byname() to simplify code
>
> Cc: Patrice Chotard <[email protected]>
> Signed-off-by: Chunfeng Yun <[email protected]>
> ---
> drivers/usb/dwc3/dwc3-st.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
> index c682420..e733be8 100644
> --- a/drivers/usb/dwc3/dwc3-st.c
> +++ b/drivers/usb/dwc3/dwc3-st.c
> @@ -206,8 +206,8 @@ static int st_dwc3_probe(struct platform_device *pdev)
> if (!dwc3_data)
> return -ENOMEM;
>
> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "reg-glue");
> - dwc3_data->glue_base = devm_ioremap_resource(dev, res);
> + dwc3_data->glue_base =
> + devm_platform_ioremap_resource_byname(pdev, "reg-glue");
> if (IS_ERR(dwc3_data->glue_base))
> return PTR_ERR(dwc3_data->glue_base);
>

Reviewed-by: Patrice Chotard <[email protected]>

Thanks

Patrice