2017-06-29 11:02:26

by Arvind Yadav

Subject: [PATCH] net: constify attribute_group structures.

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/device.h> work with const
attribute_group. So mark the non-const structs as const.

File size before:
text data bss dec hex filename
9968 3168 16 13152 3360 net/core/net-sysfs.o

File size After adding 'const':
text data bss dec hex filename
10160 2976 16 13152 3360 net/core/net-sysfs.o

Signed-off-by: Arvind Yadav <[email protected]>
---
net/core/net-sysfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index 65ea0ff..85daa29 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -622,7 +622,7 @@ static DEVICE_ATTR_RO(name)
};


-static struct attribute_group netstat_group = {
+static const struct attribute_group netstat_group = {
.name = "statistics",
.attrs = netstat_attrs,
};
@@ -632,7 +632,7 @@ static DEVICE_ATTR_RO(name)
NULL
};

-static struct attribute_group wireless_group = {
+static const struct attribute_group wireless_group = {
.name = "wireless",
.attrs = wireless_attrs,
};
@@ -1200,7 +1200,7 @@ static ssize_t bql_show_inflight(struct netdev_queue *queue,
NULL
};

-static struct attribute_group dql_group = {
+static const struct attribute_group dql_group = {
.name = "byte_queue_limits",
.attrs = dql_attrs,
};
--
1.9.1

2017-06-29 19:50:11

by David Miller

Subject: Re: [PATCH] net: constify attribute_group structures.

From: Arvind Yadav <[email protected]>
Date: Thu, 29 Jun 2017 16:31:26 +0530

> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/device.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 9968 3168 16 13152 3360 net/core/net-sysfs.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 10160 2976 16 13152 3360 net/core/net-sysfs.o
>
> Signed-off-by: Arvind Yadav <[email protected]>

Applied.