When reviewing the various SPMI PMIC bindings, I noticed that several
examples were incorrect and misleading and could also use some cleanup.
This series addresses the related hisilicon SPMI controller binding.
Johan
Johan Hovold (2):
dt-bindings: spmi: hisilicon,hisi-spmi-controller: fix binding
references
dt-bindings: spmi: hisilicon,hisi-spmi-controller: clean up example
.../spmi/hisilicon,hisi-spmi-controller.yaml | 17 +++++++----------
1 file changed, 7 insertions(+), 10 deletions(-)
--
2.41.0
Clean up the binding example by dropping the unnecessary parent bus
node, using a define for the second register value of the PMIC child and
increasing indentation to four spaces.
Signed-off-by: Johan Hovold <[email protected]>
---
.../spmi/hisilicon,hisi-spmi-controller.yaml | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.yaml b/Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.yaml
index eee7c8d4cf4a..3ccf35de3719 100644
--- a/Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.yaml
+++ b/Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.yaml
@@ -54,20 +54,17 @@ unevaluatedProperties: false
examples:
- |
- bus {
- #address-cells = <2>;
- #size-cells = <2>;
+ #include <dt-bindings/spmi/spmi.h>
- spmi: spmi@fff24000 {
+ spmi@fff24000 {
compatible = "hisilicon,kirin970-spmi-controller";
+ reg = <0xfff24000 0x1000>;
#address-cells = <2>;
#size-cells = <0>;
- reg = <0x0 0xfff24000 0x0 0x1000>;
hisilicon,spmi-channel = <2>;
pmic@0 {
- reg = <0 0>;
- /* pmic properties */
+ reg = <0 SPMI_USID>;
+ /* pmic properties */
};
- };
};
--
2.41.0
Fix up the free text binding references which were not updated when
moving the bindings out of staging and which had a leading current
directory component, respectively.
Fixes: 9bd9e0de1cf5 ("mfd: hi6421-spmi-pmic: move driver from staging")
Signed-off-by: Johan Hovold <[email protected]>
---
.../bindings/spmi/hisilicon,hisi-spmi-controller.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.yaml b/Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.yaml
index f882903769f9..eee7c8d4cf4a 100644
--- a/Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.yaml
+++ b/Documentation/devicetree/bindings/spmi/hisilicon,hisi-spmi-controller.yaml
@@ -14,7 +14,7 @@ description: |
It is a MIPI System Power Management (SPMI) controller.
The PMIC part is provided by
- ./Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml.
+ Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml.
allOf:
- $ref: spmi.yaml#
@@ -48,7 +48,7 @@ patternProperties:
PMIC properties, which are specific to the used SPMI PMIC device(s).
When used in combination with HiSilicon 6421v600, the properties
are documented at
- drivers/staging/hikey9xx/hisilicon,hi6421-spmi-pmic.yaml.
+ Documentation/devicetree/bindings/mfd/hisilicon,hi6421-spmi-pmic.yaml
unevaluatedProperties: false
--
2.41.0
On 30/11/2023 18:37, Johan Hovold wrote:
> Fix up the free text binding references which were not updated when
> moving the bindings out of staging and which had a leading current
> directory component, respectively.
>
> Fixes: 9bd9e0de1cf5 ("mfd: hi6421-spmi-pmic: move driver from staging")
> Signed-off-by: Johan Hovold <[email protected]>
> ---
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On 30/11/2023 18:37, Johan Hovold wrote:
> Clean up the binding example by dropping the unnecessary parent bus
> node, using a define for the second register value of the PMIC child and
> increasing indentation to four spaces.
>
> Signed-off-by: Johan Hovold <[email protected]>
> ---
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
Hi Stephen,
On Thu, Nov 30, 2023 at 06:37:55PM +0100, Johan Hovold wrote:
> When reviewing the various SPMI PMIC bindings, I noticed that several
> examples were incorrect and misleading and could also use some cleanup.
>
> This series addresses the related hisilicon SPMI controller binding.
> Johan Hovold (2):
> dt-bindings: spmi: hisilicon,hisi-spmi-controller: fix binding
> references
> dt-bindings: spmi: hisilicon,hisi-spmi-controller: clean up example
I noticed that these are not yet in linux-next so sending a reminder.
Johan
Hi Stephen,
On Tue, Dec 19, 2023 at 04:53:48PM +0100, Johan Hovold wrote:
> On Thu, Nov 30, 2023 at 06:37:55PM +0100, Johan Hovold wrote:
> > When reviewing the various SPMI PMIC bindings, I noticed that several
> > examples were incorrect and misleading and could also use some cleanup.
> >
> > This series addresses the related hisilicon SPMI controller binding.
>
> > Johan Hovold (2):
> > dt-bindings: spmi: hisilicon,hisi-spmi-controller: fix binding
> > references
> > dt-bindings: spmi: hisilicon,hisi-spmi-controller: clean up example
>
> I noticed that these are not yet in linux-next so sending a reminder.
This series never made it into 6.8, but could you pick it up for 6.9?
Johan
Hi Stephen,
On Fri, Jan 26, 2024 at 09:29:14AM +0100, Johan Hovold wrote:
> On Tue, Dec 19, 2023 at 04:53:48PM +0100, Johan Hovold wrote:
> > On Thu, Nov 30, 2023 at 06:37:55PM +0100, Johan Hovold wrote:
> > > When reviewing the various SPMI PMIC bindings, I noticed that several
> > > examples were incorrect and misleading and could also use some cleanup.
> > >
> > > This series addresses the related hisilicon SPMI controller binding.
> >
> > > Johan Hovold (2):
> > > dt-bindings: spmi: hisilicon,hisi-spmi-controller: fix binding
> > > references
> > > dt-bindings: spmi: hisilicon,hisi-spmi-controller: clean up example
> >
> > I noticed that these are not yet in linux-next so sending a reminder.
>
> This series never made it into 6.8, but could you pick it up for 6.9?
It's now been three months since I posted this series. Could you please
pick it up for 6.9?
Johan
Quoting Johan Hovold (2023-11-30 09:37:56)
> Fix up the free text binding references which were not updated when
> moving the bindings out of staging and which had a leading current
> directory component, respectively.
>
> Fixes: 9bd9e0de1cf5 ("mfd: hi6421-spmi-pmic: move driver from staging")
> Signed-off-by: Johan Hovold <[email protected]>
> ---
Applied to spmi-next
Quoting Johan Hovold (2023-11-30 09:37:57)
> Clean up the binding example by dropping the unnecessary parent bus
> node, using a define for the second register value of the PMIC child and
> increasing indentation to four spaces.
>
> Signed-off-by: Johan Hovold <[email protected]>
> ---
Applied to spmi-next