2022-12-05 06:50:19

by zhang.songyi

Subject: [PATCH net-next] net/mlx5: remove redundant ret variable

From: zhang songyi <[email protected]>

Return value from mlx5dr_send_postsend_action() directly instead of taking
this in another redundant variable.

Signed-off-by: zhang songyi <[email protected]>
---
drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c
index a4476cb4c3b3..fd2d31cdbcf9 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c
@@ -724,7 +724,6 @@ int mlx5dr_send_postsend_action(struct mlx5dr_domain *dmn,
struct mlx5dr_action *action)
{
struct postsend_info send_info = {};
- int ret;

send_info.write.addr = (uintptr_t)action->rewrite->data;
send_info.write.length = action->rewrite->num_of_actions *
@@ -734,9 +733,7 @@ int mlx5dr_send_postsend_action(struct mlx5dr_domain *dmn,
mlx5dr_icm_pool_get_chunk_mr_addr(action->rewrite->chunk);
send_info.rkey = mlx5dr_icm_pool_get_chunk_rkey(action->rewrite->chunk);

- ret = dr_postsend_icm_data(dmn, &send_info);
-
- return ret;
+ return dr_postsend_icm_data(dmn, &send_info);
}

static int dr_modify_qp_rst2init(struct mlx5_core_dev *mdev,
--
2.15.2

2022-12-05 08:54:27

by Roi Dayan

Subject: Re: [PATCH net-next] net/mlx5: remove redundant ret variable

On 05/12/2022 8:24, [email protected] wrote:
> From: zhang songyi <[email protected]>
>
> Return value from mlx5dr_send_postsend_action() directly instead of taking
> this in another redundant variable.
>
> Signed-off-by: zhang songyi <[email protected]>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c
> index a4476cb4c3b3..fd2d31cdbcf9 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c
> @@ -724,7 +724,6 @@ int mlx5dr_send_postsend_action(struct mlx5dr_domain *dmn,
> struct mlx5dr_action *action)
> {
> struct postsend_info send_info = {};
> - int ret;
>
> send_info.write.addr = (uintptr_t)action->rewrite->data;
> send_info.write.length = action->rewrite->num_of_actions *
> @@ -734,9 +733,7 @@ int mlx5dr_send_postsend_action(struct mlx5dr_domain *dmn,
> mlx5dr_icm_pool_get_chunk_mr_addr(action->rewrite->chunk);
> send_info.rkey = mlx5dr_icm_pool_get_chunk_rkey(action->rewrite->chunk);
>
> - ret = dr_postsend_icm_data(dmn, &send_info);
> -
> - return ret;
> + return dr_postsend_icm_data(dmn, &send_info);
> }
>
> static int dr_modify_qp_rst2init(struct mlx5_core_dev *mdev,


Reviewed-by: Roi Dayan <[email protected]>

2022-12-06 14:56:32

by Jiri Pirko

Subject: Re: [PATCH net-next] net/mlx5: remove redundant ret variable

Mon, Dec 05, 2022 at 07:24:01AM CET, [email protected] wrote:
>From: zhang songyi <[email protected]>
>
>Return value from mlx5dr_send_postsend_action() directly instead of taking
>this in another redundant variable.
>
>Signed-off-by: zhang songyi <[email protected]>

Reviewed-by: Jiri Pirko <[email protected]>