2022-03-29 17:03:55

by Johan Jonker

Subject: [PATCH v2 4/6] dt-bindings: clock: fix rk3399 cru clock issues

The current rk3399 cru DT node gives warnings like:
'clocks' is a dependency of 'assigned-clocks'.

With the YAML conversion somehow "assigned-xxx" properties where added.
If a proper clock is added to the cru node these properties are no longer
needed, so removed them. Currently only one clock will be added, so limit
the clock maxItems to 1. Add a clock name to be able to differentiate
and filter bogus entries.

Signed-off-by: Johan Jonker <[email protected]>
---
.../bindings/clock/rockchip,rk3399-cru.yaml | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml b/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml
index 18a009311..54da1e31e 100644
--- a/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml
+++ b/Documentation/devicetree/bindings/clock/rockchip,rk3399-cru.yaml
@@ -46,19 +46,10 @@ properties:
const: 1

clocks:
- minItems: 1
-
- assigned-clocks:
- minItems: 1
- maxItems: 64
-
- assigned-clock-parents:
- minItems: 1
- maxItems: 64
+ maxItems: 1

- assigned-clock-rates:
- minItems: 1
- maxItems: 64
+ clock-names:
+ const: xin24m

rockchip,grf:
$ref: /schemas/types.yaml#/definitions/phandle
--
2.20.1

2022-03-29 18:19:54

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 4/6] dt-bindings: clock: fix rk3399 cru clock issues

On 29/03/2022 17:07, Johan Jonker wrote:
> The current rk3399 cru DT node gives warnings like:
> 'clocks' is a dependency of 'assigned-clocks'.
>
> With the YAML conversion somehow "assigned-xxx" properties where added.
> If a proper clock is added to the cru node these properties are no longer
> needed, so removed them. Currently only one clock will be added, so limit
> the clock maxItems to 1. Add a clock name to be able to differentiate
> and filter bogus entries.
>
> Signed-off-by: Johan Jonker <[email protected]>
> ---
> .../bindings/clock/rockchip,rk3399-cru.yaml | 15 +++------------
> 1 file changed, 3 insertions(+), 12 deletions(-)
>


Acked-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof