Subject: [PATCH] sh: j2: Use ioremap() to translate device tree address into kernel memory

Addresses the following warning when building j2_defconfig:

arch/sh/kernel/cpu/sh2/probe.c: In function 'scan_cache':
arch/sh/kernel/cpu/sh2/probe.c:24:16: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
24 | j2_ccr_base = (u32 __iomem *)of_flat_dt_translate_address(node);
|

Signed-off-by: John Paul Adrian Glaubitz <[email protected]>
---
arch/sh/kernel/cpu/sh2/probe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/sh/kernel/cpu/sh2/probe.c b/arch/sh/kernel/cpu/sh2/probe.c
index d342ea08843f..70a07f4f2142 100644
--- a/arch/sh/kernel/cpu/sh2/probe.c
+++ b/arch/sh/kernel/cpu/sh2/probe.c
@@ -21,7 +21,7 @@ static int __init scan_cache(unsigned long node, const char *uname,
if (!of_flat_dt_is_compatible(node, "jcore,cache"))
return 0;

- j2_ccr_base = (u32 __iomem *)of_flat_dt_translate_address(node);
+ j2_ccr_base = ioremap(of_flat_dt_translate_address(node), 4);

return 1;
}
--
2.39.2


2023-05-03 13:56:00

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] sh: j2: Use ioremap() to translate device tree address into kernel memory

On Wed, May 3, 2023 at 2:59 PM John Paul Adrian Glaubitz
<[email protected]> wrote:
> Addresses the following warning when building j2_defconfig:
>
> arch/sh/kernel/cpu/sh2/probe.c: In function 'scan_cache':
> arch/sh/kernel/cpu/sh2/probe.c:24:16: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> 24 | j2_ccr_base = (u32 __iomem *)of_flat_dt_translate_address(node);
> |
>
> Signed-off-by: John Paul Adrian Glaubitz <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2023-05-05 07:30:56

by Rob Landley

[permalink] [raw]
Subject: Re: [PATCH] sh: j2: Use ioremap() to translate device tree address into kernel memory

On 5/3/23 07:57, John Paul Adrian Glaubitz wrote:
> Addresses the following warning when building j2_defconfig:

Tested-by: Rob Landley <[email protected]>

Rob