2018-11-26 14:37:30

by Frank Lee

Subject: [PATCH] workqueue: remove some duplicated includes

workqueue.h and kthread.h are included twice.It's unnecessary.
hence just remove them.

Signed-off-by: Yangtao Li <[email protected]>
---
kernel/workqueue.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 0280deac392e..7c62391ed5e5 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -30,11 +30,9 @@
#include <linux/init.h>
#include <linux/signal.h>
#include <linux/completion.h>
-#include <linux/workqueue.h>
#include <linux/slab.h>
#include <linux/cpu.h>
#include <linux/notifier.h>
-#include <linux/kthread.h>
#include <linux/hardirq.h>
#include <linux/mempolicy.h>
#include <linux/freezer.h>
--
2.17.0

2018-11-30 18:37:28

by Tejun Heo

Subject: Re: [PATCH] workqueue: remove some duplicated includes

On Mon, Nov 26, 2018 at 09:33:26AM -0500, Yangtao Li wrote:
> workqueue.h and kthread.h are included twice.It's unnecessary.
> hence just remove them.
>
> Signed-off-by: Yangtao Li <[email protected]>

Acked-by: Tejun Heo <[email protected]>

Can you route this through the trivial tree?

Thanks.

--
tejun

2018-12-01 06:47:11

by Frank Lee

Subject: Re: [PATCH] workqueue: remove some duplicated includes

It seems that the trivial tree has not been maintained for some time.
Are there aother tree to choose?

MBR,
Yangtao
On Sat, Dec 1, 2018 at 2:36 AM Tejun Heo <[email protected]> wrote:
>
> On Mon, Nov 26, 2018 at 09:33:26AM -0500, Yangtao Li wrote:
> > workqueue.h and kthread.h are included twice.It's unnecessary.
> > hence just remove them.
> >
> > Signed-off-by: Yangtao Li <[email protected]>
>
> Acked-by: Tejun Heo <[email protected]>
>
> Can you route this through the trivial tree?
>
> Thanks.
>
> --
> tejun

2018-12-01 20:58:48

by Nikolay Borisov

Subject: Re: [PATCH] workqueue: remove some duplicated includes

On 1.12.18 г. 8:46 ч., Frank Lee wrote:
> It seems that the trivial tree has not been maintained for some time.
> Are there aother tree to choose?


perhaps mmotm, maintained by Andrew (cc'ed)
>
> MBR,
> Yangtao
> On Sat, Dec 1, 2018 at 2:36 AM Tejun Heo <[email protected]> wrote:
>>
>> On Mon, Nov 26, 2018 at 09:33:26AM -0500, Yangtao Li wrote:
>>> workqueue.h and kthread.h are included twice.It's unnecessary.
>>> hence just remove them.
>>>
>>> Signed-off-by: Yangtao Li <[email protected]>
>>
>> Acked-by: Tejun Heo <[email protected]>
>>
>> Can you route this through the trivial tree?
>>
>> Thanks.
>>
>> --
>> tejun

2018-12-26 17:17:42

by Frank Lee

Subject: Re: [PATCH] workqueue: remove some duplicated includes

ping......