On 10/26/2019 12:47 PM, Saurav Girepunje wrote:
> mempool_destroy has taken null pointer check into account.
> so remove the redundant check.
>
> Signed-off-by: Saurav Girepunje <[email protected]>
> ---
> drivers/scsi/lpfc/lpfc_init.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c
> index e91377a4cafe..f620ecae3428 100644
> --- a/drivers/scsi/lpfc/lpfc_init.c
> +++ b/drivers/scsi/lpfc/lpfc_init.c
> @@ -13346,8 +13346,7 @@ lpfc_sli4_oas_verify(struct lpfc_hba *phba)
> phba->cfg_fof = 1;
> } else {
> phba->cfg_fof = 0;
> - if (phba->device_data_mem_pool)
> - mempool_destroy(phba->device_data_mem_pool);
> + mempool_destroy(phba->device_data_mem_pool);
> phba->device_data_mem_pool = NULL;
> }
>
Looks fine.
Thanks
Reviewed-by: James Smart <[email protected]>
-- james