2018-08-14 08:18:37

by Dongbo Cao

Subject: [PATCH 2/2] bcache: add undef for macro in function

add undef for macro d_strtoul,d_strtoul_nonzero and d_strtoi_h

Signed-off-by: Dongbo Cao <[email protected]>
---
drivers/md/bcache/sysfs.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
index 225b15aa..ed67a290 100644
--- a/drivers/md/bcache/sysfs.c
+++ b/drivers/md/bcache/sysfs.c
@@ -349,6 +349,9 @@ STORE(__cached_dev)
if (attr == &sysfs_stop)
bcache_device_stop(&dc->disk);

+#undef d_strtoul
+#undef d_strtoul_nonzero
+#undef d_strtoi_h
return size;
}

--
2.17.1

2018-08-14 12:18:12

by Coly Li

Subject: Re: [PATCH 2/2] bcache: add undef for macro in function

On 2018/8/14 4:16 PM, Dongbo Cao wrote:
> add undef for macro d_strtoul,d_strtoul_nonzero and d_strtoi_h
>
> Signed-off-by: Dongbo Cao <[email protected]>
> ---
> drivers/md/bcache/sysfs.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
> index 225b15aa..ed67a290 100644
> --- a/drivers/md/bcache/sysfs.c
> +++ b/drivers/md/bcache/sysfs.c
> @@ -349,6 +349,9 @@ STORE(__cached_dev)
> if (attr == &sysfs_stop)
> bcache_device_stop(&dc->disk);
>
> +#undef d_strtoul
> +#undef d_strtoul_nonzero
> +#undef d_strtoi_h
> return size;
> }
>
>

Hi Dongbo,

Could you please to provide the motivation why you make this change ?

Thanks.

Coly Li

2018-08-14 16:27:50

by Coly Li

Subject: Re: [PATCH 2/2] bcache: add undef for macro in function

On 2018/8/14 10:59 PM, [email protected] wrote:
> Hi Coly，
> The three macros is only locally used in func "__cached_dev"，I think
> they should be undefined before leaving the func.
>

Hi Dongbo,

It is worthy to do this if there is a potential conflict. But they are
defined in sysfs.c and not exported to anywhere else, I guess there
won't be any symbol conflict. Then we don't need to worry about this.

Coly Li


> ---Original---
> *From:* "Coly Li"<[email protected]>
> *Date:* Tue, Aug 14, 2018 20:16 PM
> *To:* "Dongbo Cao"<[email protected]>;
> *Cc:*
> "linux-kernel"<[email protected]>;"linux-bcache"<[email protected]>;"kent.overstreet"<[email protected]>;
> *Subject:* Re: [PATCH 2/2] bcache: add undef for macro in function
>
> On 2018/8/14 4:16 PM, Dongbo Cao wrote:
>> add undef for macro d_strtoul,d_strtoul_nonzero and d_strtoi_h
>> 
>> Signed-off-by: Dongbo Cao 
>> ---
>>  drivers/md/bcache/sysfs.c | 3 +++
>>  1 file changed, 3 insertions(+)
>> 
>> diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
>> index 225b15aa..ed67a290 100644
>> --- a/drivers/md/bcache/sysfs.c
>> +++ b/drivers/md/bcache/sysfs.c
>> @@ -349,6 +349,9 @@ STORE(__cached_dev)
>>   if (attr == &sysfs_stop)
>>   bcache_device_stop(&dc->disk);
>>  
>> +#undef d_strtoul
>> +#undef d_strtoul_nonzero
>> +#undef d_strtoi_h
>>   return size;
>>  }
>>  
>> 
>
> Hi Dongbo,
>
> Could you please to provide the motivation why you make this change ?
>
> Thanks.
>
> Coly Li