2018-09-10 18:34:55

by Neil Armstrong

[permalink] [raw]
Subject: [PATCH] arm64: dts: meson-axg-s400: Add chosen and memory nodes

Add missing chosen and memory nodes.

Signed-off-by: Neil Armstrong <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-axg-s400.dts | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
index d399078..f0de884 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
@@ -60,6 +60,15 @@
serial1 = &uart_A;
};

+ chosen {
+ stdout-path = "serial0:115200n8";
+ };
+
+ memory@0 {
+ device_type = "memory";
+ reg = <0x0 0x0 0x0 0x40000000>;
+ };
+
main_12v: regulator-main_12v {
compatible = "regulator-fixed";
regulator-name = "12V";
--
2.7.4



2018-09-10 18:47:50

by Martin Blumenstingl

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: meson-axg-s400: Add chosen and memory nodes

On Mon, Sep 10, 2018 at 8:33 PM Neil Armstrong <[email protected]> wrote:
>
> Add missing chosen and memory nodes.
>
> Signed-off-by: Neil Armstrong <[email protected]>
out of curiosity:
- does the bootloader add the memory node (meaning that this is just a
cosmetic bit)?
- setting stdout-path is always a good idea, without it you can't use
earlycon (without parameters)

Acked-by: Martin Blumenstingl <[email protected]>

2018-09-11 13:29:27

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: meson-axg-s400: Add chosen and memory nodes

Hi Martin,

On 10/09/2018 20:45, Martin Blumenstingl wrote:
> On Mon, Sep 10, 2018 at 8:33 PM Neil Armstrong <[email protected]> wrote:
>>
>> Add missing chosen and memory nodes.
>>
>> Signed-off-by: Neil Armstrong <[email protected]>
> out of curiosity:
> - does the bootloader add the memory node (meaning that this is just a
> cosmetic bit)?

Yes, but it's always better to already have the node so it only change the memory,
otherwise it has to relocate and insert a node in the middle of the dtb.

> - setting stdout-path is always a good idea, without it you can't use
> earlycon (without parameters)
>
> Acked-by: Martin Blumenstingl <[email protected]>
>

Thanks,
Neil

2018-09-13 04:59:20

by Kevin Hilman

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: meson-axg-s400: Add chosen and memory nodes

Neil Armstrong <[email protected]> writes:

> Add missing chosen and memory nodes.
>
> Signed-off-by: Neil Armstrong <[email protected]>

Applied to v4.20/dt64 with Martin's ack.

Thanks,

Kevin